New issue
Advanced search Search tips

Issue 777576 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

DownloadTaskScheduler parameter sequence is incorrect

Project Member Reported by xingliu@chromium.org, Oct 23 2017

Issue description

DownloadTaskScheduler parameter sequence should be network requirement first, then battery requirement. 

The whole pipe line from native to jni bridge to the Java layer should use the same sequence.

The bug may result in background task ran in incorrect circumstances.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/caa10203e2a0ea6cb668f024364ecd167a758d97

commit caa10203e2a0ea6cb668f024364ecd167a758d97
Author: Xing Liu <xingliu@chromium.org>
Date: Tue Oct 24 01:13:13 2017

Fix DownloadTaskScheduler::scheduleTask  parameters order.

TBR=dtrainor@chromium.org, shaktisahu@chromium.org

Bug:  777576 
Change-Id: I8124e4fe1d2e82e8843d53169b941201dfef7a49
Reviewed-on: https://chromium-review.googlesource.com/734301
Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510971}
[modify] https://crrev.com/caa10203e2a0ea6cb668f024364ecd167a758d97/chrome/android/java/src/org/chromium/chrome/browser/download/service/DownloadTaskScheduler.java

Labels: Merge-Request-63
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 25 2017

Labels: -Merge-Request-63 Hotlist-Merge-Approved Merge-Approved-63
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 25 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d620fac1bbb9bee15280814089e0b2b618883793

commit d620fac1bbb9bee15280814089e0b2b618883793
Author: Xing Liu <xingliu@chromium.org>
Date: Wed Oct 25 16:55:46 2017

Fix DownloadTaskScheduler::scheduleTask  parameters order.

TBR=dtrainor@chromium.org, shaktisahu@chromium.org, xingliu@chromium.org

(cherry picked from commit caa10203e2a0ea6cb668f024364ecd167a758d97)

Bug:  777576 
Change-Id: I8124e4fe1d2e82e8843d53169b941201dfef7a49
Reviewed-on: https://chromium-review.googlesource.com/734301
Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#510971}
Reviewed-on: https://chromium-review.googlesource.com/737541
Cr-Commit-Position: refs/branch-heads/3239@{#220}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/d620fac1bbb9bee15280814089e0b2b618883793/chrome/android/java/src/org/chromium/chrome/browser/download/service/DownloadTaskScheduler.java

Status: Fixed (was: Assigned)

Sign in to add a comment