Old plugin: https://chromium.googlesource.com/chromium/src/+/master/tools/android/findbugs_plugin Instructions from errorprone: http://errorprone.info/docs/plugins
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d092bcd2de5a080ecbe9be269751c503d55e5b9f commit d092bcd2de5a080ecbe9be269751c503d55e5b9f Author: Peter Wen <wnwen@chromium.org> Date: Thu Nov 02 12:59:09 2017 Android: Add third_party/auto for errorprone The two new NoSynchronized*Checks in our custom errorprone plugin replace our custom findbugs plugin checks. This prepares us for turning down findbugs. Add AutoService library to third_party/auto as a dependency for errorprone custom plugins. When creating jars, use all the files in the directory instead of just the .class files. This allows AutoService to work for the errorprone plugins. See: https://chromium.googlesource.com/chromium/src/+/master/tools/android/findbugs_plugin/README BUG= 777572 Change-Id: I1d8dab685a192eaaf30088fe8452027aed06991b Reviewed-on: https://chromium-review.googlesource.com/739725 Reviewed-by: Filip Gorski <fgorski@chromium.org> Reviewed-by: Brett Wilson <brettw@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#513470} [modify] https://crrev.com/d092bcd2de5a080ecbe9be269751c503d55e5b9f/BUILD.gn [modify] https://crrev.com/d092bcd2de5a080ecbe9be269751c503d55e5b9f/DEPS [modify] https://crrev.com/d092bcd2de5a080ecbe9be269751c503d55e5b9f/android_webview/glue/java/src/com/android/webview/chromium/ContentSettingsAdapter.java [modify] https://crrev.com/d092bcd2de5a080ecbe9be269751c503d55e5b9f/android_webview/glue/java/src/com/android/webview/chromium/CookieManagerAdapter.java [modify] https://crrev.com/d092bcd2de5a080ecbe9be269751c503d55e5b9f/android_webview/glue/java/src/com/android/webview/chromium/ServiceWorkerSettingsAdapter.java [modify] https://crrev.com/d092bcd2de5a080ecbe9be269751c503d55e5b9f/android_webview/glue/java/src/com/android/webview/chromium/WebBackForwardListChromium.java [modify] https://crrev.com/d092bcd2de5a080ecbe9be269751c503d55e5b9f/android_webview/glue/java/src/com/android/webview/chromium/WebHistoryItemChromium.java [modify] https://crrev.com/d092bcd2de5a080ecbe9be269751c503d55e5b9f/base/android/java/src/org/chromium/base/NonThreadSafe.java [modify] https://crrev.com/d092bcd2de5a080ecbe9be269751c503d55e5b9f/build/android/gyp/jar.py [modify] https://crrev.com/d092bcd2de5a080ecbe9be269751c503d55e5b9f/build/android/gyp/javac.py [modify] https://crrev.com/d092bcd2de5a080ecbe9be269751c503d55e5b9f/build/config/android/internal_rules.gni [modify] https://crrev.com/d092bcd2de5a080ecbe9be269751c503d55e5b9f/chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java [modify] https://crrev.com/d092bcd2de5a080ecbe9be269751c503d55e5b9f/components/gcm_driver/instance_id/android/java/src/org/chromium/components/gcm_driver/instance_id/InstanceIDBridge.java [modify] https://crrev.com/d092bcd2de5a080ecbe9be269751c503d55e5b9f/third_party/.gitignore [add] https://crrev.com/d092bcd2de5a080ecbe9be269751c503d55e5b9f/third_party/auto/BUILD.gn [add] https://crrev.com/d092bcd2de5a080ecbe9be269751c503d55e5b9f/third_party/auto/OWNERS [add] https://crrev.com/d092bcd2de5a080ecbe9be269751c503d55e5b9f/third_party/auto/README.chromium [modify] https://crrev.com/d092bcd2de5a080ecbe9be269751c503d55e5b9f/third_party/errorprone/BUILD.gn [modify] https://crrev.com/d092bcd2de5a080ecbe9be269751c503d55e5b9f/third_party/errorprone/OWNERS [modify] https://crrev.com/d092bcd2de5a080ecbe9be269751c503d55e5b9f/third_party/errorprone/README.chromium [modify] https://crrev.com/d092bcd2de5a080ecbe9be269751c503d55e5b9f/third_party/guava/BUILD.gn [add] https://crrev.com/d092bcd2de5a080ecbe9be269751c503d55e5b9f/tools/android/errorprone_plugin/BUILD.gn [add] https://crrev.com/d092bcd2de5a080ecbe9be269751c503d55e5b9f/tools/android/errorprone_plugin/OWNERS [add] https://crrev.com/d092bcd2de5a080ecbe9be269751c503d55e5b9f/tools/android/errorprone_plugin/src/org/chromium/tools/errorprone/plugin/NoSynchronizedMethodCheck.java [add] https://crrev.com/d092bcd2de5a080ecbe9be269751c503d55e5b9f/tools/android/errorprone_plugin/src/org/chromium/tools/errorprone/plugin/NoSynchronizedThisCheck.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4d1bca74e14cf69203617c70b5e54b8ac08257d3 commit 4d1bca74e14cf69203617c70b5e54b8ac08257d3 Author: Peter Wen <wnwen@chromium.org> Date: Thu Nov 02 13:20:51 2017 Revert "Android: Add third_party/auto for errorprone" This reverts commit d092bcd2de5a080ecbe9be269751c503d55e5b9f. Reason for revert: Broke Android Cronet Marshmallow 64bit Builder Original change's description: > Android: Add third_party/auto for errorprone > > The two new NoSynchronized*Checks in our custom errorprone plugin > replace our custom findbugs plugin checks. This prepares us for turning > down findbugs. > > Add AutoService library to third_party/auto as a dependency for > errorprone custom plugins. > > When creating jars, use all the files in the directory instead of just > the .class files. This allows AutoService to work for the errorprone > plugins. > > See: > https://chromium.googlesource.com/chromium/src/+/master/tools/android/findbugs_plugin/README > > BUG= 777572 > > Change-Id: I1d8dab685a192eaaf30088fe8452027aed06991b > Reviewed-on: https://chromium-review.googlesource.com/739725 > Reviewed-by: Filip Gorski <fgorski@chromium.org> > Reviewed-by: Brett Wilson <brettw@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Commit-Queue: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#513470} TBR=yfriedman@chromium.org,peter@chromium.org,brettw@chromium.org,wnwen@chromium.org,fgorski@chromium.org,torne@chromium.org,agrieve@chromium.org,jbudorick@chromium.org Change-Id: Ie4ea91aa268f8ebaf9a3669878db1d31668c7576 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 777572 Reviewed-on: https://chromium-review.googlesource.com/751021 Reviewed-by: Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#513473} [modify] https://crrev.com/4d1bca74e14cf69203617c70b5e54b8ac08257d3/BUILD.gn [modify] https://crrev.com/4d1bca74e14cf69203617c70b5e54b8ac08257d3/DEPS [modify] https://crrev.com/4d1bca74e14cf69203617c70b5e54b8ac08257d3/android_webview/glue/java/src/com/android/webview/chromium/ContentSettingsAdapter.java [modify] https://crrev.com/4d1bca74e14cf69203617c70b5e54b8ac08257d3/android_webview/glue/java/src/com/android/webview/chromium/CookieManagerAdapter.java [modify] https://crrev.com/4d1bca74e14cf69203617c70b5e54b8ac08257d3/android_webview/glue/java/src/com/android/webview/chromium/ServiceWorkerSettingsAdapter.java [modify] https://crrev.com/4d1bca74e14cf69203617c70b5e54b8ac08257d3/android_webview/glue/java/src/com/android/webview/chromium/WebBackForwardListChromium.java [modify] https://crrev.com/4d1bca74e14cf69203617c70b5e54b8ac08257d3/android_webview/glue/java/src/com/android/webview/chromium/WebHistoryItemChromium.java [modify] https://crrev.com/4d1bca74e14cf69203617c70b5e54b8ac08257d3/base/android/java/src/org/chromium/base/NonThreadSafe.java [modify] https://crrev.com/4d1bca74e14cf69203617c70b5e54b8ac08257d3/build/android/gyp/jar.py [modify] https://crrev.com/4d1bca74e14cf69203617c70b5e54b8ac08257d3/build/android/gyp/javac.py [modify] https://crrev.com/4d1bca74e14cf69203617c70b5e54b8ac08257d3/build/config/android/internal_rules.gni [modify] https://crrev.com/4d1bca74e14cf69203617c70b5e54b8ac08257d3/chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java [modify] https://crrev.com/4d1bca74e14cf69203617c70b5e54b8ac08257d3/components/gcm_driver/instance_id/android/java/src/org/chromium/components/gcm_driver/instance_id/InstanceIDBridge.java [modify] https://crrev.com/4d1bca74e14cf69203617c70b5e54b8ac08257d3/third_party/.gitignore [delete] https://crrev.com/d05563e79739d8d2943d0996de32f2e99f93893b/third_party/auto/BUILD.gn [delete] https://crrev.com/d05563e79739d8d2943d0996de32f2e99f93893b/third_party/auto/OWNERS [delete] https://crrev.com/d05563e79739d8d2943d0996de32f2e99f93893b/third_party/auto/README.chromium [modify] https://crrev.com/4d1bca74e14cf69203617c70b5e54b8ac08257d3/third_party/errorprone/BUILD.gn [modify] https://crrev.com/4d1bca74e14cf69203617c70b5e54b8ac08257d3/third_party/errorprone/OWNERS [modify] https://crrev.com/4d1bca74e14cf69203617c70b5e54b8ac08257d3/third_party/errorprone/README.chromium [modify] https://crrev.com/4d1bca74e14cf69203617c70b5e54b8ac08257d3/third_party/guava/BUILD.gn [delete] https://crrev.com/d05563e79739d8d2943d0996de32f2e99f93893b/tools/android/errorprone_plugin/BUILD.gn [delete] https://crrev.com/d05563e79739d8d2943d0996de32f2e99f93893b/tools/android/errorprone_plugin/OWNERS [delete] https://crrev.com/d05563e79739d8d2943d0996de32f2e99f93893b/tools/android/errorprone_plugin/src/org/chromium/tools/errorprone/plugin/NoSynchronizedMethodCheck.java [delete] https://crrev.com/d05563e79739d8d2943d0996de32f2e99f93893b/tools/android/errorprone_plugin/src/org/chromium/tools/errorprone/plugin/NoSynchronizedThisCheck.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0cc6d63e5a1e8d825bf8bf775b0473466b47a22 commit d0cc6d63e5a1e8d825bf8bf775b0473466b47a22 Author: Peter Wen <wnwen@chromium.org> Date: Thu Nov 02 16:32:30 2017 Reland "Android: Add third_party/auto for errorprone"" Original CL: https://crrev.com/c/739725 Fix: - errorprone_plugin_java depends on errorprone_java, which is only available on $default_toolchain. BUG= 777572 TBR=fgorski@chromium.org,brettw@chromium.org,yfriedman@chromium.org,jbudorick@chromium.org,peter@chromium.org,torne@chromium.org,agrieve@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2dceece332036a98014943cff4ec82b152075622 Reviewed-on: https://chromium-review.googlesource.com/750645 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#513513} [modify] https://crrev.com/d0cc6d63e5a1e8d825bf8bf775b0473466b47a22/BUILD.gn [modify] https://crrev.com/d0cc6d63e5a1e8d825bf8bf775b0473466b47a22/DEPS [modify] https://crrev.com/d0cc6d63e5a1e8d825bf8bf775b0473466b47a22/android_webview/glue/java/src/com/android/webview/chromium/ContentSettingsAdapter.java [modify] https://crrev.com/d0cc6d63e5a1e8d825bf8bf775b0473466b47a22/android_webview/glue/java/src/com/android/webview/chromium/CookieManagerAdapter.java [modify] https://crrev.com/d0cc6d63e5a1e8d825bf8bf775b0473466b47a22/android_webview/glue/java/src/com/android/webview/chromium/ServiceWorkerSettingsAdapter.java [modify] https://crrev.com/d0cc6d63e5a1e8d825bf8bf775b0473466b47a22/android_webview/glue/java/src/com/android/webview/chromium/WebBackForwardListChromium.java [modify] https://crrev.com/d0cc6d63e5a1e8d825bf8bf775b0473466b47a22/android_webview/glue/java/src/com/android/webview/chromium/WebHistoryItemChromium.java [modify] https://crrev.com/d0cc6d63e5a1e8d825bf8bf775b0473466b47a22/base/android/java/src/org/chromium/base/NonThreadSafe.java [modify] https://crrev.com/d0cc6d63e5a1e8d825bf8bf775b0473466b47a22/build/android/gyp/jar.py [modify] https://crrev.com/d0cc6d63e5a1e8d825bf8bf775b0473466b47a22/build/android/gyp/javac.py [modify] https://crrev.com/d0cc6d63e5a1e8d825bf8bf775b0473466b47a22/build/config/android/internal_rules.gni [modify] https://crrev.com/d0cc6d63e5a1e8d825bf8bf775b0473466b47a22/chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java [modify] https://crrev.com/d0cc6d63e5a1e8d825bf8bf775b0473466b47a22/components/gcm_driver/instance_id/android/java/src/org/chromium/components/gcm_driver/instance_id/InstanceIDBridge.java [modify] https://crrev.com/d0cc6d63e5a1e8d825bf8bf775b0473466b47a22/third_party/.gitignore [add] https://crrev.com/d0cc6d63e5a1e8d825bf8bf775b0473466b47a22/third_party/auto/BUILD.gn [add] https://crrev.com/d0cc6d63e5a1e8d825bf8bf775b0473466b47a22/third_party/auto/OWNERS [add] https://crrev.com/d0cc6d63e5a1e8d825bf8bf775b0473466b47a22/third_party/auto/README.chromium [modify] https://crrev.com/d0cc6d63e5a1e8d825bf8bf775b0473466b47a22/third_party/errorprone/BUILD.gn [modify] https://crrev.com/d0cc6d63e5a1e8d825bf8bf775b0473466b47a22/third_party/errorprone/OWNERS [modify] https://crrev.com/d0cc6d63e5a1e8d825bf8bf775b0473466b47a22/third_party/errorprone/README.chromium [modify] https://crrev.com/d0cc6d63e5a1e8d825bf8bf775b0473466b47a22/third_party/guava/BUILD.gn [add] https://crrev.com/d0cc6d63e5a1e8d825bf8bf775b0473466b47a22/tools/android/errorprone_plugin/BUILD.gn [add] https://crrev.com/d0cc6d63e5a1e8d825bf8bf775b0473466b47a22/tools/android/errorprone_plugin/OWNERS [add] https://crrev.com/d0cc6d63e5a1e8d825bf8bf775b0473466b47a22/tools/android/errorprone_plugin/src/org/chromium/tools/errorprone/plugin/NoSynchronizedMethodCheck.java [add] https://crrev.com/d0cc6d63e5a1e8d825bf8bf775b0473466b47a22/tools/android/errorprone_plugin/src/org/chromium/tools/errorprone/plugin/NoSynchronizedThisCheck.java
Comment 1 by wnwen@chromium.org
, Nov 1 2017