New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 777571 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

mushrome: Cannot switch to VT2, screen is black

Project Member Reported by jamescook@chromium.org, Oct 23 2017

Issue description

Tested on caroline on M63 dev (63.0.3239.7, 10032.4.0)

* Turn on --mus in about:flags
* Click Restart
* After restart, hit Ctrl-Alt-F2 to switch to VT2

Screen goes black. Console never appears. You can switch back with Ctrl-Alt-F1 but I could never get frecon to appear.

[8041:8041:1023/135204.306049:VERBOSE1:display_configurator.cc(1016)] OnConfigured: success=1 new_display_state=SINGLE new_power_state=ALL_OFF 
[8041:8081:1023/135204.306828:ERROR:drm_display_host_manager.cc(192)] TakeDisplayControl called while display already owned [8041:8081:1023/135206.830625:ERROR:drm_display_host_manager.cc(192)] TakeDisplayControl called while display already owned [8041:8041:1023/135206.830846:VERBOSE1:display_configurator.cc(864)] SetDisplayPower: power_state=ALL_ON flags=0, configure timer=Stopped [8041:8086:1023/135206.845157:WARNING:screen_manager.cc(114)] Display controller (crtc=26) already present. [8041:8041:1023/135206.845519:VERBOSE1:display_configurator.cc(912)] Display snapshots invalidated.

"TakeDisplayControl called when display already owned" -> maybe something is not releasing the display to frecon?

Fady, do you know if this is fixed in ToT? If not, can you find an owner? This makes on-device debugging harder.
 

Comment 1 by derat@chromium.org, Oct 23 2017

Cc: marc...@chromium.org dbehr@chromium.org

Comment 2 by fsamuel@google.com, Oct 23 2017

Owner: kylec...@chromium.org
Status: WontFix (was: Assigned)
I just tried to reproduce on link with a fresh M64 10063.0.0 image. I was able to turn on --mus, restart and switch to VT2. It also worked with --mash. I don't have a caroline device to test with here.

If this is a board specific problem and not fixed at ToT please reopen.
Status: Assigned (was: WontFix)
It's broken for me on caroline with a M64 10063.0.0 test image (same version as you). I used /etc/chrome_dev.conf to add --mus and --mash, both are broken.

Maybe Peng has a caroline?

Status: Started (was: Assigned)
Wasn't able to find a caroline, but the bug also reproduces on kevin.
It looks like the DRM implementation on some boards (eg. link_) doesn't care if the display controller gets freed up by Chrome for VT2 to use. We accidentally call TakeDisplayControl() instead of RelinquishDisplayControl() so I'm surprised it works at all on link. Fix out for review.
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66782d2a8d72c4b2126c481d410983e86b35d6dc

commit 66782d2a8d72c4b2126c481d410983e86b35d6dc
Author: kylechar <kylechar@chromium.org>
Date: Wed Nov 01 17:04:43 2017

Fix switching to VT2 with mus/mash.

Switching to VT2 on Chrome OS with --mus or --mash was broken on some
boards due to copy and paste errors calling the wrong function.

Bug:  777571 ,  772023 
Change-Id: I4f77ae795bd5cd19b767e6bb9e40c4a28d08c2c3
Reviewed-on: https://chromium-review.googlesource.com/748812
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513160}
[modify] https://crrev.com/66782d2a8d72c4b2126c481d410983e86b35d6dc/ui/display/manager/forwarding_display_delegate.cc
[modify] https://crrev.com/66782d2a8d72c4b2126c481d410983e86b35d6dc/ui/ozone/platform/drm/host/host_drm_device.cc

Status: Fixed (was: Started)

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 10 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment