mushrome: Stylus icon does not appear in shelf status area |
||||||
Issue descriptionTested on caroline on M63 dev (63.0.3239.7, 10032.4.0) * Boot and log in with --mus * Stylus icon does not appear * Stylus menu does not open on stylus eject * Stylus section does not appear in settings I don't see much in the UI logs, just "touch_devices_controller.cc(22) Failed to set touchpad enabled state". I suspect the stylus just isn't being detected, or if it is then the browser process/ash aren't being notified.
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e580c764d6ce523a2cbd2b6502b196e9efcf121 commit 5e580c764d6ce523a2cbd2b6502b196e9efcf121 Author: James Cook <jamescook@chromium.org> Date: Wed Oct 25 23:03:53 2017 cros: Fix stylus detection for chrome --mus The field ui::TouchscreenDevice::is_stylus was not being serialized over mojo, so code in ash didn't detect the stylus. * Add mojo field and serialization * Rename TouchscreenDevice::is_stylus to has_stylus * Add has_stylus to TouchscreenDevice constructors, in the hope that the next person who adds a field will do the same and audit all the call sites. Bug: 777570 Test: events_unittests, manual test on device with stylus Change-Id: Iae4715a474dac58063a138c7816ab2f56bec8532 Reviewed-on: https://chromium-review.googlesource.com/738489 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#511629} [modify] https://crrev.com/5e580c764d6ce523a2cbd2b6502b196e9efcf121/ash/public/cpp/stylus_utils.cc [modify] https://crrev.com/5e580c764d6ce523a2cbd2b6502b196e9efcf121/ash/system/ime/tray_ime_chromeos_unittest.cc [modify] https://crrev.com/5e580c764d6ce523a2cbd2b6502b196e9efcf121/ash/system/power/peripheral_battery_notifier.cc [modify] https://crrev.com/5e580c764d6ce523a2cbd2b6502b196e9efcf121/ash/system/power/peripheral_battery_notifier_unittest.cc [modify] https://crrev.com/5e580c764d6ce523a2cbd2b6502b196e9efcf121/ash/virtual_keyboard_controller_unittest.cc [modify] https://crrev.com/5e580c764d6ce523a2cbd2b6502b196e9efcf121/ui/events/devices/mojo/device_struct_traits_unittest.cc [modify] https://crrev.com/5e580c764d6ce523a2cbd2b6502b196e9efcf121/ui/events/devices/mojo/input_device_struct_traits.cc [modify] https://crrev.com/5e580c764d6ce523a2cbd2b6502b196e9efcf121/ui/events/devices/mojo/input_device_struct_traits.h [modify] https://crrev.com/5e580c764d6ce523a2cbd2b6502b196e9efcf121/ui/events/devices/mojo/input_devices.mojom [modify] https://crrev.com/5e580c764d6ce523a2cbd2b6502b196e9efcf121/ui/events/devices/touchscreen_device.cc [modify] https://crrev.com/5e580c764d6ce523a2cbd2b6502b196e9efcf121/ui/events/devices/touchscreen_device.h [modify] https://crrev.com/5e580c764d6ce523a2cbd2b6502b196e9efcf121/ui/events/ozone/evdev/input_device_factory_evdev.cc [modify] https://crrev.com/5e580c764d6ce523a2cbd2b6502b196e9efcf121/ui/events/platform/x11/x11_hotplug_event_handler.cc
,
Oct 25 2017
,
Nov 2 2017
Issue 717674 has been merged into this issue.
,
Jan 22 2018
,
Jan 23 2018
,
Feb 26 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jamescook@chromium.org
, Oct 25 2017