New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 777567 link

Starred by 2 users
Status: Fixed
Owner:
█ offenwanger@chromium.org
Last visit > 30 days ago
Closed: Feb 2018
Cc:
bajones@chromium.org
bsheedy@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task
Proj-XR


Show other hotlists

Hotlists containing this issue:
VR-Automated-Tests


Sign in to add a comment

add vr_promise_test and switch WebVR tests to it

Project Member Reported by ddorwin@chromium.org, Oct 23 2017 
Currently, the WebVR tests us vr_test, which is a wrapper around async_test. Since WebVR uses promises heavily, we should use the promise_test mechanism. This should simplify the tests since we don't need to catch every rejection.

When we first implemented WebVR tests for the 1.1 API, there was a problem where promise tests could unintentionally pass. We should check whether this is still the case, and if so, how we can mitigate this.

Comment 1 by ddorwin@chromium.org, Nov 17 2017

Cc: bajones@chromium.org
We should do this before we add more latest API tests.

Comment 2 by ddorwin@chromium.org, Jan 8 2018

Cc: -offenwanger@chromium.org
Labels: -M-64 M-65
Owner: offenwanger@chromium.org
Status: Assigned (was: Available)

Comment 3 by offenwanger@chromium.org, Jan 25 2018

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/986227d3774873cb7d8c8ed8ec4b93885363d4d1

commit 986227d3774873cb7d8c8ed8ec4b93885363d4d1
Author: Anna Offenwanger <offenwanger@chromium.org>
Date: Tue Jan 30 19:22:46 2018

Clean up the WebXR test folder

Detached the xr test folder from the vr test folder by creating its own
set of helper classes. Converted all tests to promise tests where it
made sense. As much as possible detached chrome specific code for when
we convert tests to WPTs.

Bug:  777567 
Change-Id: I90e7800cbf86b09f72937033e4a840d1f5719b61
Reviewed-on: https://chromium-review.googlesource.com/889652
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532987}
[modify] https://crrev.com/986227d3774873cb7d8c8ed8ec4b93885363d4d1/third_party/WebKit/LayoutTests/xr/events_deviceconnect.html
[modify] https://crrev.com/986227d3774873cb7d8c8ed8ec4b93885363d4d1/third_party/WebKit/LayoutTests/xr/events_session_end.html
[modify] https://crrev.com/986227d3774873cb7d8c8ed8ec4b93885363d4d1/third_party/WebKit/LayoutTests/xr/exclusive_requestFrame_called.html
[modify] https://crrev.com/986227d3774873cb7d8c8ed8ec4b93885363d4d1/third_party/WebKit/LayoutTests/xr/exclusive_requestFrame_invalidhandle.html
[modify] https://crrev.com/986227d3774873cb7d8c8ed8ec4b93885363d4d1/third_party/WebKit/LayoutTests/xr/exclusive_requestFrame_nolayer.html
[modify] https://crrev.com/986227d3774873cb7d8c8ed8ec4b93885363d4d1/third_party/WebKit/LayoutTests/xr/exclusive_requestFrame_unregister.html
[modify] https://crrev.com/986227d3774873cb7d8c8ed8ec4b93885363d4d1/third_party/WebKit/LayoutTests/xr/getDevicePose_oneframeupdate.html
[modify] https://crrev.com/986227d3774873cb7d8c8ed8ec4b93885363d4d1/third_party/WebKit/LayoutTests/xr/navigator_xr_blocked_by_getVRDisplays.html
[modify] https://crrev.com/986227d3774873cb7d8c8ed8ec4b93885363d4d1/third_party/WebKit/LayoutTests/xr/navigator_xr_blocks_getVRDisplays.html
[modify] https://crrev.com/986227d3774873cb7d8c8ed8ec4b93885363d4d1/third_party/WebKit/LayoutTests/xr/navigator_xr_detached.html
[modify] https://crrev.com/986227d3774873cb7d8c8ed8ec4b93885363d4d1/third_party/WebKit/LayoutTests/xr/requestDevice_one_device.html
[modify] https://crrev.com/986227d3774873cb7d8c8ed8ec4b93885363d4d1/third_party/WebKit/LayoutTests/xr/requestDevice_two_devices.html
[modify] https://crrev.com/986227d3774873cb7d8c8ed8ec4b93885363d4d1/third_party/WebKit/LayoutTests/xr/requestDevice_zero_devices.html
[add] https://crrev.com/986227d3774873cb7d8c8ed8ec4b93885363d4d1/third_party/WebKit/LayoutTests/xr/resources/test-constants.js
[add] https://crrev.com/986227d3774873cb7d8c8ed8ec4b93885363d4d1/third_party/WebKit/LayoutTests/xr/resources/xr-device-mocking.js
[add] https://crrev.com/986227d3774873cb7d8c8ed8ec4b93885363d4d1/third_party/WebKit/LayoutTests/xr/resources/xr-test-utils.js
[modify] https://crrev.com/986227d3774873cb7d8c8ed8ec4b93885363d4d1/third_party/WebKit/LayoutTests/xr/xrDevice_requestSession_exclusive_no_gesture.html
[modify] https://crrev.com/986227d3774873cb7d8c8ed8ec4b93885363d4d1/third_party/WebKit/LayoutTests/xr/xrDevice_requestSession_exclusive_supported.html
[modify] https://crrev.com/986227d3774873cb7d8c8ed8ec4b93885363d4d1/third_party/WebKit/LayoutTests/xr/xrDevice_requestSession_exclusive_unsupported.html
[modify] https://crrev.com/986227d3774873cb7d8c8ed8ec4b93885363d4d1/third_party/WebKit/LayoutTests/xr/xrDevice_supportsSession_exclusive_rejects.html
[modify] https://crrev.com/986227d3774873cb7d8c8ed8ec4b93885363d4d1/third_party/WebKit/LayoutTests/xr/xrDevice_supportsSession_exclusive_resolves.html
[modify] https://crrev.com/986227d3774873cb7d8c8ed8ec4b93885363d4d1/third_party/WebKit/LayoutTests/xr/xrDevice_supportsSession_non_exclusive.html
[modify] https://crrev.com/986227d3774873cb7d8c8ed8ec4b93885363d4d1/third_party/WebKit/LayoutTests/xr/xrSession_exclusive.html
[modify] https://crrev.com/986227d3774873cb7d8c8ed8ec4b93885363d4d1/third_party/WebKit/LayoutTests/xr/xrSession_prevent_multiple_exclusive.html
[modify] https://crrev.com/986227d3774873cb7d8c8ed8ec4b93885363d4d1/third_party/WebKit/LayoutTests/xr/xrSession_requestFrameOfReference.html
[modify] https://crrev.com/986227d3774873cb7d8c8ed8ec4b93885363d4d1/third_party/WebKit/LayoutTests/xr/xrView_match.html
[modify] https://crrev.com/986227d3774873cb7d8c8ed8ec4b93885363d4d1/third_party/WebKit/LayoutTests/xr/xrView_oneframeupdate.html
[modify] https://crrev.com/986227d3774873cb7d8c8ed8ec4b93885363d4d1/third_party/WebKit/LayoutTests/xr/xrViewport_valid.html
[modify] https://crrev.com/986227d3774873cb7d8c8ed8ec4b93885363d4d1/third_party/WebKit/LayoutTests/xr/xrWebGLLayer_constructor.html
[modify] https://crrev.com/986227d3774873cb7d8c8ed8ec4b93885363d4d1/third_party/WebKit/LayoutTests/xr/xrWebGLLayer_dirty_framebuffer.html
[modify] https://crrev.com/986227d3774873cb7d8c8ed8ec4b93885363d4d1/third_party/WebKit/LayoutTests/xr/xrWebGLLayer_framebuffer_draw.html
[modify] https://crrev.com/986227d3774873cb7d8c8ed8ec4b93885363d4d1/third_party/WebKit/LayoutTests/xr/xrWebGLLayer_opaque_framebuffer.html

Comment 5 by offenwanger@chromium.org, Feb 1 2018

Status: Fixed (was: Started)
We have moved over all the new tests, which are WebXR tests. The original 1.1 tests will soon be obsolete, so they won't be moved over.

Comment 6 by dougman@chromium.org, Feb 7 2018

Labels: Test-Complete

Comment 7 by btebbs@chromium.org, Jul 4

Components: Blink>WebXR
►

Sign in to add a comment