mushrome: Stylus taps not handled in UI |
|||||
Issue description
Tested on caroline on M63 dev (63.0.3239.7, 10032.4.0)
* Tap on window close button
* Hover effect happens, but tap is not processed and window does not close
Same is true on any UI element. It looks like the events are not be handled at all. Logs complain about this NOTREACHED in event_struct_traits.cc
switch (pointer_details->pointer_type) {
case ui::EventPointerType::POINTER_TYPE_MOUSE:
pointer_data->kind = ui::mojom::PointerKind::MOUSE;
break;
case ui::EventPointerType::POINTER_TYPE_TOUCH:
pointer_data->kind = ui::mojom::PointerKind::TOUCH;
break;
default:
NOTREACHED(); <---------
}
So I suspect we're never transporting EventPointerType::PEN events. I can take a look this week (sky@ asked me to look into stylus). Advice welcome.
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce371f4b2ec4c6e1472773d9edc869322e9d35b8 commit ce371f4b2ec4c6e1472773d9edc869322e9d35b8 Author: James Cook <jamescook@chromium.org> Date: Wed Oct 25 21:07:27 2017 cros: Fix stylus input for chrome --mus * Ensure pen pointer events are serialized over mojo * Ensure pen events are converted to TouchEvent before dispatch into views UI code, which is how classic ash handles pen events Bug: 777561 Test: events_unittests, aura_unittests, manual test on device with stylus Change-Id: Ifb4672682d63923b89d0749021b21ca0ed71b8a9 Reviewed-on: https://chromium-review.googlesource.com/736856 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#511588} [modify] https://crrev.com/ce371f4b2ec4c6e1472773d9edc869322e9d35b8/ui/aura/mus/window_tree_client.cc [modify] https://crrev.com/ce371f4b2ec4c6e1472773d9edc869322e9d35b8/ui/aura/mus/window_tree_client_unittest.cc [modify] https://crrev.com/ce371f4b2ec4c6e1472773d9edc869322e9d35b8/ui/events/event.cc [modify] https://crrev.com/ce371f4b2ec4c6e1472773d9edc869322e9d35b8/ui/events/event.h [modify] https://crrev.com/ce371f4b2ec4c6e1472773d9edc869322e9d35b8/ui/events/mojo/event_constants.mojom [modify] https://crrev.com/ce371f4b2ec4c6e1472773d9edc869322e9d35b8/ui/events/mojo/event_struct_traits.cc [modify] https://crrev.com/ce371f4b2ec4c6e1472773d9edc869322e9d35b8/ui/events/mojo/struct_traits_unittest.cc
,
Oct 25 2017
Above CL fixes it for mash too.
,
Jan 22 2018
,
Jan 23 2018
,
Feb 26 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jamescook@chromium.org
, Oct 25 2017