New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 777560 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
Omnibox-Bugs-on-mpearson-Radar


Sign in to add a comment

URL bar moves down permanently when copying URL (MIUI 8.5, Android 7.0)

Reported by animedud...@gmail.com, Oct 23 2017

Issue description

Steps to reproduce the problem:
1. Open the URL bar, try to copy a URL
2. When the MIUI context menu appears, the URL bar will slide down
3. Use chrome normally, the URL bar is still in it's moved down position, this persists permanently now untill a force close

What is the expected behavior?
The URL bar to not slide down, or to slide back up after tapping off it.

What went wrong?
The URL bar stays permanently moved down untill a force stop.

Did this work before? N/A 

Chrome version: 61.0.3163.98  Channel: n/a
OS Version: 
Flash Version: 

This happens on MIUI 8.5 which is Android 7.0 based on the Xiaomi Redmi Note 4 (Global Variant)
 
Added an extra screenshot
Added correct screenshots
Screenshot_2017-10-23-21-33-52-904_com.android.chrome.png
157 KB View Download
Screenshot_2017-10-23-21-46-34-382_com.chrome.dev.png
103 KB View Download
Labels: Needs-triage-Mobile
Cc: msrchandra@chromium.org nyerramilli@chromium.org ligim...@chromium.org sandeepkumars@chromium.org
Labels: TE-NeedsTriageFromMTV
Tested the issue using #61.0.3163.98 on Android 6.0.1; Redmi Note 3 Build/MMB29M and could not reproduce the issue as per the steps mentioned below.

Steps Followed:
1. Launched Browser
2. Navigated to random sites
3. Tried copying the URL, long tapped, context menu appeared 
4. Observed URL bar is slide down and getting back on tapping on it.

Requesting MTV team to check the issue on Xiaomi Redmi Note 4 with 7.0 device as it's not available with Clank-Hyd Team.

Thanks!!

Comment 5 Deleted

Cc: tedc...@chromium.org
Components: UI>Browser>Omnibox
Labels: -TE-NeedsTriageFromMTV
Status: Available (was: Unconfirmed)
animedude008@, thanks for your report. However, we were unable to repro this issue on Redmi Note 4/NRD90M on both Chrome Stable:61.0.3163.98 & Chrome Beta:63.0.3239.20. The context menu toolbar appears below the URL bar and not above it(as mentioned in the issue).
I understand but I have that device and have the issue. I am using MIUI 8.5.8.0 which is the latest official stable MIUI Global build available and is 7.0 based. I have attached a screen recording to prove I am having this problem. I show version info as well.
2017_10_27_19_31_40.mp4
4.7 MB View Download
I have tried Chrome Beta, Dev and Canary, this issue occurs on all of them. You have to make the menu appear by selecting/highlighting text. Occurs both in normal and incognito mode.
To me, this looks like an issue with the Android version you're using.

On older versions of Android, we'd move the toolbar down because the selection action mode (i.e. the copy/paste bar) would appear at the top of the screen.  In Android M, they introduced the floating action mode:
https://developer.android.com/reference/android/view/ActionMode.html#TYPE_FLOATING

We have code in Chrome to move the toolbar down if the mode isn't floating:
https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarActionModeCallback.java?l=40

With the similar logic to move the toolbar back when the action mode is destroyed:
https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarActionModeCallback.java?l=34

To me, it looks like the action mode is saying that it isn't FLOATING in onCreate but that it was floating in onDestroy.  This would create this problem.

But, I can't really be confident that changing this would address the issue as we don't have test device.

Comment 10 Deleted

I did not have this issue before my phone updated from MIUI 8.2 which is Android 6.0 Marshmallow based so this could be a problem with the latest MIUI update but I am hoping a fix is possible.
I've found some bug reports for this device showing the issue on the official MIUI forums

http://en.miui.com/thread-800439-1-1.html

http://en.miui.com/thread-905074-1-1.html
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39112406d775cab9b5655eea72fd4072dacec566

commit 39112406d775cab9b5655eea72fd4072dacec566
Author: Ted Choc <tedchoc@google.com>
Date: Fri Nov 03 20:11:42 2017

Add Toolbar ActionMode fix for MIUI device.

Speculatively fix an issue where the toolbar is being moved
when triggering the select action mode, but not hidden when
the action mode is destroyed.

The guess here is that isFloatingActionMode is true in
onCreateActionMode, but false in onDestroyActionMode.  This
checks only in onCreateActionMode and otherwise just ensures
the toolbar is moved back (if needed) in destroy.

BUG= 777560 

Change-Id: Ibc38505105f781aaa9d77af1daa6ce95a38cb898
Reviewed-on: https://chromium-review.googlesource.com/752543
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513888}
[modify] https://crrev.com/39112406d775cab9b5655eea72fd4072dacec566/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarActionModeCallback.java

Owner: tedc...@chromium.org
Status: Started (was: Available)
@animedude008 - I just landed a speculative fix for this.  It will be available in the Chrome Canary build on Monday, could you download it next week and try it out to see if it is addressed?
Sure no problem, I will download it on Monday and let you know of the outcome.
After trying the 6th Nov build of Chrome Canary, the bug still occurs. Using Chrome Canary 64.0.3260.0
Hmm...that is unfortunate.

I'm worried that the MIUI framework changes might not be calling ActionMode.Callback#onDestroyActionMode.

We rely on that to move the toolbar and if they never call it then we're in a bad way.

I looked on the forum and couldn't find a way to file a bug against them as this doesn't appear (on the surface) as something Chrome can likely fix.
I recently updated my Redmi Note 4 to MIUI 9.0.3.0 now, but the bug also still exists. I submitted a bug report to Xiaomi with the new feedback section in the settings app, but no idea if they will fix it on their end.
Status: ExternalDependency (was: Started)
Xiaomi have fixed this issue in the latest China developer ROM, it's expected to be in global stable ROM at some point. You may close this issue now.
Status: Fixed (was: ExternalDependency)
Will do, thanks for the update!

Sign in to add a comment