New issue
Advanced search Search tips

Issue 777542 link

Starred by 2 users
Status: Fixed
Owner:
cjgrant@chromium.org
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature
Proj-XR
Proj-XR-VR


Show other hotlists

Hotlists containing this issue:
VR-Automated-Tests


Sign in to add a comment

Support autocomplete suggestions in response to text input

Project Member Reported by cjgrant@chromium.org, Oct 23 2017 
This issue tracks the generation and rendering of omnibox suggestions in VR, and the navigation resulting from one of those suggestions being clicked.

It does not cover the wiring of the autocomplete system to voice input or omnibox text input - that will be tracked separately.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/397c593954735d9db30a9946d0f945491db89ad5

commit 397c593954735d9db30a9946d0f945491db89ad5
Author: Christopher Grant <cjgrant@chromium.org>
Date: Thu Oct 26 21:56:23 2017

VR: Generalize linear layout to be any direction.

Primarily, this lets a linear layout be up or down.

BUG= 777542 

Change-Id: Ice0bca83bd7f0484a985e8a813d37796a807dc14
Reviewed-on: https://chromium-review.googlesource.com/740143
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511980}
[modify] https://crrev.com/397c593954735d9db30a9946d0f945491db89ad5/chrome/browser/vr/elements/linear_layout.cc
[modify] https://crrev.com/397c593954735d9db30a9946d0f945491db89ad5/chrome/browser/vr/elements/linear_layout.h
[modify] https://crrev.com/397c593954735d9db30a9946d0f945491db89ad5/chrome/browser/vr/elements/linear_layout_unittest.cc
[modify] https://crrev.com/397c593954735d9db30a9946d0f945491db89ad5/chrome/browser/vr/ui_scene_manager.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea1fee74334f23881de5dd06996f7d0f55a389b9

commit ea1fee74334f23881de5dd06996f7d0f55a389b9
Author: Christopher Grant <cjgrant@chromium.org>
Date: Fri Oct 27 22:01:48 2017

VR: Support nested linear layouts.

Make scene layout a recursive operation. Layout relies on element size,
but also sets the size of layout-related elements (a linear layout
resizes itself to fit its children).

BUG= 777542 

Change-Id: I03af634f961c7f82829a85954098b214adc77b94
Reviewed-on: https://chromium-review.googlesource.com/741332
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512302}
[modify] https://crrev.com/ea1fee74334f23881de5dd06996f7d0f55a389b9/chrome/browser/vr/elements/linear_layout.cc
[modify] https://crrev.com/ea1fee74334f23881de5dd06996f7d0f55a389b9/chrome/browser/vr/elements/linear_layout_unittest.cc
[modify] https://crrev.com/ea1fee74334f23881de5dd06996f7d0f55a389b9/chrome/browser/vr/ui_scene.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12ed8a7b3112ecc572be1dd52a6704863b4c9115

commit 12ed8a7b3112ecc572be1dd52a6704863b4c9115
Author: Christopher Grant <cjgrant@chromium.org>
Date: Tue Oct 31 17:41:44 2017

VR: Add initial rendering of omnibox suggestions.

This CL does not cover generation of suggestions, but rather rendering
of suggestions that exist in the UI model. Suggestions are also not yet
properly rendered WRT to alignment, sizing, etc. Proper formatting and
layout can be added after supporting capabilities are added to the UI.

BUG= 777542 

Change-Id: Ib10b7a1bf05be629322a3db81650324102e2fbfa
Reviewed-on: https://chromium-review.googlesource.com/734222
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512865}
[modify] https://crrev.com/12ed8a7b3112ecc572be1dd52a6704863b4c9115/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/12ed8a7b3112ecc572be1dd52a6704863b4c9115/chrome/browser/vr/elements/ui_element_name.h
[add] https://crrev.com/12ed8a7b3112ecc572be1dd52a6704863b4c9115/chrome/browser/vr/model/model.cc
[modify] https://crrev.com/12ed8a7b3112ecc572be1dd52a6704863b4c9115/chrome/browser/vr/model/model.h
[add] https://crrev.com/12ed8a7b3112ecc572be1dd52a6704863b4c9115/chrome/browser/vr/model/omnibox_suggestions.cc
[add] https://crrev.com/12ed8a7b3112ecc572be1dd52a6704863b4c9115/chrome/browser/vr/model/omnibox_suggestions.h
[modify] https://crrev.com/12ed8a7b3112ecc572be1dd52a6704863b4c9115/chrome/browser/vr/test/ui_scene_manager_test.cc
[modify] https://crrev.com/12ed8a7b3112ecc572be1dd52a6704863b4c9115/chrome/browser/vr/test/ui_scene_manager_test.h
[modify] https://crrev.com/12ed8a7b3112ecc572be1dd52a6704863b4c9115/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/12ed8a7b3112ecc572be1dd52a6704863b4c9115/chrome/browser/vr/testapp/vr_test_context.h
[modify] https://crrev.com/12ed8a7b3112ecc572be1dd52a6704863b4c9115/chrome/browser/vr/ui.cc
[modify] https://crrev.com/12ed8a7b3112ecc572be1dd52a6704863b4c9115/chrome/browser/vr/ui.h
[modify] https://crrev.com/12ed8a7b3112ecc572be1dd52a6704863b4c9115/chrome/browser/vr/ui_scene.cc
[modify] https://crrev.com/12ed8a7b3112ecc572be1dd52a6704863b4c9115/chrome/browser/vr/ui_scene_constants.h
[modify] https://crrev.com/12ed8a7b3112ecc572be1dd52a6704863b4c9115/chrome/browser/vr/ui_scene_manager.cc
[modify] https://crrev.com/12ed8a7b3112ecc572be1dd52a6704863b4c9115/chrome/browser/vr/ui_scene_manager.h
[modify] https://crrev.com/12ed8a7b3112ecc572be1dd52a6704863b4c9115/chrome/browser/vr/ui_scene_manager_unittest.cc
[modify] https://crrev.com/12ed8a7b3112ecc572be1dd52a6704863b4c9115/components/omnibox/browser/BUILD.gn
[modify] https://crrev.com/12ed8a7b3112ecc572be1dd52a6704863b4c9115/components/omnibox/browser/autocomplete_match.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3269dc6d217f328b525de23f4e6e0cef67030cf0

commit 3269dc6d217f328b525de23f4e6e0cef67030cf0
Author: Christopher Grant <cjgrant@chromium.org>
Date: Thu Nov 02 15:15:03 2017

VR: Let elements align themselves relative to their own edges

Similar to how an element can align to the edge of a parent, it should
be able to align itself relative to its own edges, rather than its
center.  Combining these abilities lets a child element align its edge
with its parent's edge.

BUG= 777542 
R=vollick

Change-Id: I04796cb09ea123264aa25c4a26e1b86c835dd11e
Reviewed-on: https://chromium-review.googlesource.com/749871
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513492}
[modify] https://crrev.com/3269dc6d217f328b525de23f4e6e0cef67030cf0/chrome/browser/vr/elements/ui_element.cc
[modify] https://crrev.com/3269dc6d217f328b525de23f4e6e0cef67030cf0/chrome/browser/vr/elements/ui_element.h
[modify] https://crrev.com/3269dc6d217f328b525de23f4e6e0cef67030cf0/chrome/browser/vr/ui_scene_manager.cc
[modify] https://crrev.com/3269dc6d217f328b525de23f4e6e0cef67030cf0/chrome/browser/vr/ui_scene_unittest.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b38b120c4903e824013f3cb16f5077532c41bb63

commit b38b120c4903e824013f3cb16f5077532c41bb63
Author: Christopher Grant <cjgrant@chromium.org>
Date: Fri Nov 17 19:51:22 2017

VR: Add plumbing between UI and browser omnibox sites

This paves the way to plug in an AutocompleteController, and associated
UI.  Also, drive URL bar and WebVR toast state via model, as omnibox
will require some of the same data.

BUG= 777542 
R=vollick

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I29e96b5318e0d90b5530c12166db9fe780dba276
Reviewed-on: https://chromium-review.googlesource.com/772393
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517519}
[modify] https://crrev.com/b38b120c4903e824013f3cb16f5077532c41bb63/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/b38b120c4903e824013f3cb16f5077532c41bb63/chrome/browser/android/vr_shell/vr_gl_thread.h
[modify] https://crrev.com/b38b120c4903e824013f3cb16f5077532c41bb63/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/b38b120c4903e824013f3cb16f5077532c41bb63/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/b38b120c4903e824013f3cb16f5077532c41bb63/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/b38b120c4903e824013f3cb16f5077532c41bb63/chrome/browser/vr/browser_ui_interface.h
[modify] https://crrev.com/b38b120c4903e824013f3cb16f5077532c41bb63/chrome/browser/vr/elements/url_bar_texture.h
[modify] https://crrev.com/b38b120c4903e824013f3cb16f5077532c41bb63/chrome/browser/vr/elements/url_bar_texture_unittest.cc
[modify] https://crrev.com/b38b120c4903e824013f3cb16f5077532c41bb63/chrome/browser/vr/elements/webvr_url_toast_texture.h
[modify] https://crrev.com/b38b120c4903e824013f3cb16f5077532c41bb63/chrome/browser/vr/model/model.h
[modify] https://crrev.com/b38b120c4903e824013f3cb16f5077532c41bb63/chrome/browser/vr/model/omnibox_suggestions.cc
[modify] https://crrev.com/b38b120c4903e824013f3cb16f5077532c41bb63/chrome/browser/vr/model/omnibox_suggestions.h
[rename] https://crrev.com/b38b120c4903e824013f3cb16f5077532c41bb63/chrome/browser/vr/model/toolbar_state.cc
[rename] https://crrev.com/b38b120c4903e824013f3cb16f5077532c41bb63/chrome/browser/vr/model/toolbar_state.h
[modify] https://crrev.com/b38b120c4903e824013f3cb16f5077532c41bb63/chrome/browser/vr/test/mock_browser_interface.h
[modify] https://crrev.com/b38b120c4903e824013f3cb16f5077532c41bb63/chrome/browser/vr/test/ui_pixel_test.h
[modify] https://crrev.com/b38b120c4903e824013f3cb16f5077532c41bb63/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/b38b120c4903e824013f3cb16f5077532c41bb63/chrome/browser/vr/testapp/vr_test_context.h
[modify] https://crrev.com/b38b120c4903e824013f3cb16f5077532c41bb63/chrome/browser/vr/toolbar_helper.h
[modify] https://crrev.com/b38b120c4903e824013f3cb16f5077532c41bb63/chrome/browser/vr/ui.cc
[modify] https://crrev.com/b38b120c4903e824013f3cb16f5077532c41bb63/chrome/browser/vr/ui.h
[modify] https://crrev.com/b38b120c4903e824013f3cb16f5077532c41bb63/chrome/browser/vr/ui_browser_interface.h
[modify] https://crrev.com/b38b120c4903e824013f3cb16f5077532c41bb63/chrome/browser/vr/ui_pixeltest.cc
[modify] https://crrev.com/b38b120c4903e824013f3cb16f5077532c41bb63/chrome/browser/vr/ui_scene_manager.cc
[modify] https://crrev.com/b38b120c4903e824013f3cb16f5077532c41bb63/chrome/browser/vr/ui_scene_manager.h
[modify] https://crrev.com/b38b120c4903e824013f3cb16f5077532c41bb63/chrome/browser/vr/ui_scene_manager_unittest.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a3927423e4acafd32f5d480c6a04cc4a940a48f

commit 7a3927423e4acafd32f5d480c6a04cc4a940a48f
Author: Christopher Grant <cjgrant@chromium.org>
Date: Tue Nov 21 13:50:02 2017

VR: Let omnibox suggestion clicks trigger navigation

BUG= 777542 
R=vollick

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id4035f03e99d3219c9427c13db0e466f2923d75e
Reviewed-on: https://chromium-review.googlesource.com/777583
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518237}
[modify] https://crrev.com/7a3927423e4acafd32f5d480c6a04cc4a940a48f/chrome/browser/vr/BUILD.gn
[add] https://crrev.com/7a3927423e4acafd32f5d480c6a04cc4a940a48f/chrome/browser/vr/elements/suggestion.cc
[add] https://crrev.com/7a3927423e4acafd32f5d480c6a04cc4a940a48f/chrome/browser/vr/elements/suggestion.h
[modify] https://crrev.com/7a3927423e4acafd32f5d480c6a04cc4a940a48f/chrome/browser/vr/model/model.h
[modify] https://crrev.com/7a3927423e4acafd32f5d480c6a04cc4a940a48f/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/7a3927423e4acafd32f5d480c6a04cc4a940a48f/chrome/browser/vr/ui_scene_manager.cc
[modify] https://crrev.com/7a3927423e4acafd32f5d480c6a04cc4a940a48f/chrome/browser/vr/ui_scene_manager_unittest.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a21546ea3d2cf6a69c8fa6698446171e02128140

commit a21546ea3d2cf6a69c8fa6698446171e02128140
Author: Christopher Grant <cjgrant@chromium.org>
Date: Wed Nov 22 23:38:40 2017

VR: Add omnibox element subtree

This change adds more of the tree necessary to show the omnibox and
suggestions, but does not enable anything. Element sizes and positions are not
yet correct.

BUG= 777542 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ia0450e7218fb4c58a4ced0cbbfe86f9d94913a2c
Reviewed-on: https://chromium-review.googlesource.com/786301
Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518803}
[modify] https://crrev.com/a21546ea3d2cf6a69c8fa6698446171e02128140/chrome/browser/vr/elements/ui_element_name.cc
[modify] https://crrev.com/a21546ea3d2cf6a69c8fa6698446171e02128140/chrome/browser/vr/elements/ui_element_name.h
[modify] https://crrev.com/a21546ea3d2cf6a69c8fa6698446171e02128140/chrome/browser/vr/test/ui_scene_manager_test.cc
[modify] https://crrev.com/a21546ea3d2cf6a69c8fa6698446171e02128140/chrome/browser/vr/test/ui_scene_manager_test.h
[modify] https://crrev.com/a21546ea3d2cf6a69c8fa6698446171e02128140/chrome/browser/vr/ui_renderer_unittest.cc
[modify] https://crrev.com/a21546ea3d2cf6a69c8fa6698446171e02128140/chrome/browser/vr/ui_scene_constants.h
[modify] https://crrev.com/a21546ea3d2cf6a69c8fa6698446171e02128140/chrome/browser/vr/ui_scene_manager.cc
[modify] https://crrev.com/a21546ea3d2cf6a69c8fa6698446171e02128140/chrome/browser/vr/ui_scene_manager.h
[modify] https://crrev.com/a21546ea3d2cf6a69c8fa6698446171e02128140/chrome/browser/vr/ui_scene_manager_unittest.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9ab2fcda0538f56bb05c71a0d6c6375cb80ed71

commit d9ab2fcda0538f56bb05c71a0d6c6375cb80ed71
Author: Christopher Grant <cjgrant@chromium.org>
Date: Thu Dec 07 19:22:34 2017

VR: Final tweaks to make omnibox work.

- Hit testing on suggestions works.
- GL init is fixed.
- AutocompleteController is started/stopped properly.

BUG= 777542 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I7f5fb2273ad43258d22b7f36a9d648578b2bffb1
Reviewed-on: https://chromium-review.googlesource.com/813059
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522504}
[modify] https://crrev.com/d9ab2fcda0538f56bb05c71a0d6c6375cb80ed71/chrome/browser/android/vr_shell/autocomplete_controller.cc
[modify] https://crrev.com/d9ab2fcda0538f56bb05c71a0d6c6375cb80ed71/chrome/browser/vr/model/omnibox_suggestions.h
[modify] https://crrev.com/d9ab2fcda0538f56bb05c71a0d6c6375cb80ed71/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/d9ab2fcda0538f56bb05c71a0d6c6375cb80ed71/chrome/browser/vr/ui_scene.cc
[modify] https://crrev.com/d9ab2fcda0538f56bb05c71a0d6c6375cb80ed71/chrome/browser/vr/ui_scene_constants.h
[modify] https://crrev.com/d9ab2fcda0538f56bb05c71a0d6c6375cb80ed71/chrome/browser/vr/ui_scene_creator.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0b588897f57b10a4c8774021a9fa442ddc6d1fe

commit c0b588897f57b10a4c8774021a9fa442ddc6d1fe
Author: Ian Vollick <vollick@chromium.org>
Date: Thu Dec 14 20:41:38 2017

[vr] Generalize buttons and use for omnibox suggestions

With this change, button becomes disc button and the base class can be
used as a generic button (a thing with hover, press states and a
callback). This was used to get hover states in the omnibox suggestions.

This change also includes some color scheme changes (mostly for these
new buttons, but also brings a number of other colors up to spec).

Bug:  777542 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id0262e5c677d2022593e9bf3574dd92c12cfe7f0
Reviewed-on: https://chromium-review.googlesource.com/827034
Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524165}
[modify] https://crrev.com/c0b588897f57b10a4c8774021a9fa442ddc6d1fe/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/c0b588897f57b10a4c8774021a9fa442ddc6d1fe/chrome/browser/vr/elements/button.cc
[modify] https://crrev.com/c0b588897f57b10a4c8774021a9fa442ddc6d1fe/chrome/browser/vr/elements/button.h
[add] https://crrev.com/c0b588897f57b10a4c8774021a9fa442ddc6d1fe/chrome/browser/vr/elements/disc_button.cc
[add] https://crrev.com/c0b588897f57b10a4c8774021a9fa442ddc6d1fe/chrome/browser/vr/elements/disc_button.h
[rename] https://crrev.com/c0b588897f57b10a4c8774021a9fa442ddc6d1fe/chrome/browser/vr/elements/disc_button_unittest.cc
[delete] https://crrev.com/62033fbf3495d2eb4067729638399997dce71fd5/chrome/browser/vr/elements/suggestion.cc
[delete] https://crrev.com/62033fbf3495d2eb4067729638399997dce71fd5/chrome/browser/vr/elements/suggestion.h
[modify] https://crrev.com/c0b588897f57b10a4c8774021a9fa442ddc6d1fe/chrome/browser/vr/elements/text_input.cc
[modify] https://crrev.com/c0b588897f57b10a4c8774021a9fa442ddc6d1fe/chrome/browser/vr/elements/ui_element.cc
[modify] https://crrev.com/c0b588897f57b10a4c8774021a9fa442ddc6d1fe/chrome/browser/vr/elements/ui_element.h
[modify] https://crrev.com/c0b588897f57b10a4c8774021a9fa442ddc6d1fe/chrome/browser/vr/elements/url_bar_texture_unittest.cc
[modify] https://crrev.com/c0b588897f57b10a4c8774021a9fa442ddc6d1fe/chrome/browser/vr/model/color_scheme.cc
[modify] https://crrev.com/c0b588897f57b10a4c8774021a9fa442ddc6d1fe/chrome/browser/vr/model/color_scheme.h
[modify] https://crrev.com/c0b588897f57b10a4c8774021a9fa442ddc6d1fe/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/c0b588897f57b10a4c8774021a9fa442ddc6d1fe/chrome/browser/vr/ui_unittest.cc

Comment 11 by cjgrant@chromium.org, Jan 4 2018

Status: Fixed (was: Started)
We now have basic suggestion support.  New bugs will be filed for feature refinement.

Comment 12 by dougman@chromium.org, Feb 8 2018

Labels: Test-Complete M-65
►

Sign in to add a comment