DevTools: Network.SetRequestInterception should filter requests that belong to agent's target |
||
Issue descriptionCurrently, Network.SetRequestInterception intercepts all requests related to WebContents of the inspected target. This is inconsistent with other agent functionality -- an agent should only have effect on the local frame tree that the agent is attached to.
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/417adfb818795738bf5b32afea457b4ffe6495e3 commit 417adfb818795738bf5b32afea457b4ffe6495e3 Author: Andrey Kosyakov <caseq@chromium.org> Date: Thu Nov 16 06:35:58 2017 DevTools: untangle request interceptor from network handler, make it reusable This removes the dependency of DevToolsURLRequestInterceptor from NetworkHandler (aside from couple of static methods) and replaces the instance of NetworkHandler with a single callback. This also fixes crbug.com.777516 (managing active interception job by target id), which would be a problem for multi-client mode. Bug: 758136, 777516 Change-Id: Ic065cb5c9683069ff115bbf06409f1e5cc7afcf4 Reviewed-on: https://chromium-review.googlesource.com/752502 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#517002} [modify] https://crrev.com/417adfb818795738bf5b32afea457b4ffe6495e3/content/browser/devtools/devtools_interceptor_controller.cc [modify] https://crrev.com/417adfb818795738bf5b32afea457b4ffe6495e3/content/browser/devtools/devtools_interceptor_controller.h [modify] https://crrev.com/417adfb818795738bf5b32afea457b4ffe6495e3/content/browser/devtools/devtools_url_interceptor_request_job.cc [modify] https://crrev.com/417adfb818795738bf5b32afea457b4ffe6495e3/content/browser/devtools/devtools_url_interceptor_request_job.h [modify] https://crrev.com/417adfb818795738bf5b32afea457b4ffe6495e3/content/browser/devtools/devtools_url_request_interceptor.cc [modify] https://crrev.com/417adfb818795738bf5b32afea457b4ffe6495e3/content/browser/devtools/devtools_url_request_interceptor.h [modify] https://crrev.com/417adfb818795738bf5b32afea457b4ffe6495e3/content/browser/devtools/protocol/network_handler.cc [modify] https://crrev.com/417adfb818795738bf5b32afea457b4ffe6495e3/content/browser/devtools/protocol/network_handler.h
,
Nov 22 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by paulir...@chromium.org
, Nov 16 2017