New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 777490 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

crash_sender: move cached os version files elsewhere

Project Member Reported by diand...@chromium.org, Oct 23 2017

Issue description

This is a task to do the work from review comments in <https://chromium-review.googlesource.com/c/chromiumos/platform2/+/728299>, AKA:

> +2 now to get the fix out there (and it'll be easy to cherry pick back)
> 
> but thinking bigger, this seems fragile.  any other files we try 
> to stash in here are going to run into the same problem.  how 
> about moving them to /var/lib/crash_sender/ instead ?
 
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/4aca7d605cb7693f0abcdbee4716e8523a467dc2

commit 4aca7d605cb7693f0abcdbee4716e8523a467dc2
Author: Benjamin Gordon <bmgordon@chromium.org>
Date: Mon Oct 30 17:44:58 2017

crash: Add /var/lib/crash_reporter to cached search path

crash_reporter currently caches lsb-release and os-release in
/var/spool/crash.  This directory isn't meant to store files that last
longer than 24 hours, so we're going to move them into
/var/lib/crash_reporter.  This CL makes crash_sender start looking in
the new directory to be ready for the change.

BUG= chromium:777490 
TEST=Manually created files in /var/lib/crash_reporter and ran
     crash_sender

Change-Id: Ib41bd6ee8ae34cdeecc3d6d5bae39188b565a5be
Reviewed-on: https://chromium-review.googlesource.com/740866
Commit-Ready: Benjamin Gordon <bmgordon@chromium.org>
Tested-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/4aca7d605cb7693f0abcdbee4716e8523a467dc2/crash-reporter/crash_sender

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/7661f9f680690b1443a8448e55a9046bb2b76e7d

commit 7661f9f680690b1443a8448e55a9046bb2b76e7d
Author: Benjamin Gordon <bmgordon@chromium.org>
Date: Wed Nov 08 01:52:16 2017

crash: Move cached version files out of crash spool

crash_reporter saves copies of /etc/lsb-release and /etc/os-release in
/var/spool/crash so it can match up kernel crash versions accurately.
Files in this directory aren't meant to stick around for more than 24
hours, so move these files to /var/lib/crash_reporter instead.

BUG= chromium:777490 
TEST=unit tests; generated dummy crashes on an eve.

Change-Id: I79669b33fc4632a6454eb1b90b9ea72953a033e2
Reviewed-on: https://chromium-review.googlesource.com/740867
Commit-Ready: Benjamin Gordon <bmgordon@chromium.org>
Tested-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/7661f9f680690b1443a8448e55a9046bb2b76e7d/crash-reporter/unclean_shutdown_collector_test.cc
[modify] https://crrev.com/7661f9f680690b1443a8448e55a9046bb2b76e7d/crash-reporter/unclean_shutdown_collector.cc
[modify] https://crrev.com/7661f9f680690b1443a8448e55a9046bb2b76e7d/crash-reporter/crash_collector.cc
[modify] https://crrev.com/7661f9f680690b1443a8448e55a9046bb2b76e7d/crash-reporter/crash_collector.h

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/88988552951e7c8457f23bbbcad85bee860bd746

commit 88988552951e7c8457f23bbbcad85bee860bd746
Author: Benjamin Gordon <bmgordon@chromium.org>
Date: Tue Nov 14 06:22:09 2017

Revert "crash: Preserve cached os version files"

This reverts commit 20a23362c557f400e221de9b3b39200b3b546e4c.  Cached
version files have been moved to /var/lib/crash_reporter, and we now
want the files in /var/spool/crash to be cleaned up again.

BUG= chromium:777490 
TEST=touched files in /var/spool/crash and verified they are deleted.

Change-Id: Ife7779f8f6b4b9d29f702baf6c867de0f61bb6c6
Reviewed-on: https://chromium-review.googlesource.com/740868
Commit-Ready: Benjamin Gordon <bmgordon@chromium.org>
Tested-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/88988552951e7c8457f23bbbcad85bee860bd746/crash-reporter/crash_sender

Status: Fixed (was: Assigned)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 7 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
Cc: josa...@chromium.org ka...@chromium.org sontis@chromium.org rpattumani@chromium.org harpreet@chromium.org dsunk...@chromium.org
 Issue 729843  has been merged into this issue.

Sign in to add a comment