New issue
Advanced search Search tips

Issue 777484 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: 7
NextAction: 2018-01-19
OS: ----
Pri: 1
Type: Bug


Sign in to add a comment

Roll FFmpeg for M66

Project Member Reported by xhw...@chromium.org, Oct 23 2017

Issue description

Tracking bug for FFmpeg roll.

 

Comment 1 by xhw...@chromium.org, Oct 23 2017

Description: Show this description
Labels: -Pri-2 Pri-1
The NextAction date has arrived: 2018-01-19

Comment 4 by xhw...@chromium.org, Jan 19 2018

Status: Started (was: Assigned)
Blockedon: 801821
Blockedon: 804070
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a568ded46a678eac8139cb06595819c5ae874177

commit a568ded46a678eac8139cb06595819c5ae874177
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Mon Jan 29 21:28:28 2018

media: Increase DecoderBuffer::kPaddingSize to 64

AV_INPUT_BUFFER_PADDING_SIZE has been increased to 64 in FFmpeg:
https://github.com/FFmpeg/FFmpeg/commit/6e80079a2840ee407c5d126030eb1066bcbfdfc5

BUG= 777484 

Change-Id: I1bd68d1c1b0c3131f28d6e07e1444b89800c09db
Reviewed-on: https://chromium-review.googlesource.com/889686
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532593}
[modify] https://crrev.com/a568ded46a678eac8139cb06595819c5ae874177/media/base/decoder_buffer.h

Blockedon: 806122
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/third_party/ffmpeg/+/d846135055e1a6e247c0f94391c913ee132b0078

commit d846135055e1a6e247c0f94391c913ee132b0078
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Tue Jan 30 00:07:05 2018

media: Update build_ffmpeg.py to pull Android API level

The variable name for Android API level in
build/config/android/config.gni has been changed:
  - _android_api_level -> android32_ndk_api_level
  - _android64_api_level -> android64_ndk_api_level
See https://chromium-review.googlesource.com/866841 for details.

This CL updates build_ffmpeg.py to use a new regex search string to
fetch the Android API level.

BUG= 777484 

Change-Id: I9e3389f044a3cdb65734b5c5186611b69dc7f6d4
Reviewed-on: https://chromium-review.googlesource.com/891643
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>

[modify] https://crrev.com/d846135055e1a6e247c0f94391c913ee132b0078/chromium/scripts/build_ffmpeg.py

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 31 2018

Labels: merge-merged-merge-m66
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/third_party/ffmpeg/+/69a2be8d04a28550541a6ee7029c8f1764b9c8f9

commit 69a2be8d04a28550541a6ee7029c8f1764b9c8f9
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Wed Jan 31 02:07:07 2018

Updating build configs for M66 roll

BUG= 777484 

Change-Id: Iccc4a0466c84a6d14c9c5675b5cde80c18dece17
Reviewed-on: https://chromium-review.googlesource.com/894612
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>

[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/linux/mipsel/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/mac/x64/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/linux/arm64/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/linux/arm/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/ChromeOS/linux/arm-neon/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/linux/mips64el/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/linux/ia32/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/android/mipsel/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/ChromeOS/linux/mips64el/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/win/ia32/config.asm
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/android/mipsel/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/mac/x64/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/win/x64/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/linux/x64/config.asm
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/ChromeOS/linux-noasm/x64/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/linux/arm-neon/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/ChromeOS/linux/mipsel/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/ChromeOS/linux/x64/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/android/x64/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/linux/arm/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/ChromeOS/linux/ia32/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/linux/x64/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/android/mips64el/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/win/x64/config.asm
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/android/arm-neon/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/linux/arm64/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/linux/mipsel/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/ChromeOS/linux/x64/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/ChromeOS/linux/arm/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/android/x64/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/ChromeOS/linux/mipsel/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/android/x64/config.asm
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/linux/mips64el/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/linux/mipsel/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/android/arm-neon/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/win/ia32/config.asm
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/linux/mips64el/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/ChromeOS/linux/x64/config.asm
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/win/ia32/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/linux/x64/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/ChromeOS/linux/ia32/config.asm
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/android/ia32/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/linux-noasm/x64/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/android/ia32/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/ChromeOS/linux/arm64/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/android/arm64/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/android/arm-neon/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/linux/ia32/config.asm
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/linux/x64/config.asm
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/linux/x64/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/android/ia32/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/android/arm64/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/linux/ia32/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/linux-noasm/x64/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/android/arm64/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/win/x64/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/linux/x64/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/linux/arm64/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/linux/arm-neon/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/linux/mipsel/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/CREDITS.chromium
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/mac/x64/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/ChromeOS/linux/arm-neon/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/android/mips64el/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/ChromeOS/linux/arm64/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/linux-noasm/x64/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/linux/arm/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/mac/x64/config.asm
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/linux-noasm/x64/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/android/mips64el/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/android/ia32/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/linux/ia32/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/android/mips64el/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/ChromeOS/linux/ia32/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/android/mipsel/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/win/x64/config.asm
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/android/mipsel/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/ChromeOS/linux-noasm/x64/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/mac/x64/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/android/x64/config.asm
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/android/arm64/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/win/ia32/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/linux/arm-neon/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/android/x64/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/linux/arm/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/linux/ia32/config.asm
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/mac/x64/config.asm
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/linux/mips64el/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/linux/arm64/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/ChromeOS/linux/mips64el/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/linux/ia32/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chrome/android/x64/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/ChromeOS/linux/arm/config.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/linux/arm-neon/libavutil/ffversion.h
[modify] https://crrev.com/69a2be8d04a28550541a6ee7029c8f1764b9c8f9/chromium/config/Chromium/android/arm-neon/config.h

Blockedon: 804097
Project Member

Comment 13 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7674370b235981e782b1b2d9032d5a228f1ddde

commit f7674370b235981e782b1b2d9032d5a228f1ddde
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Thu Feb 01 01:40:00 2018

Roll src/third_party/ffmpeg/ 3e444ad88..f5964c36e (116 commits)

https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/3e444ad8860b..f5964c36e1dc

$ git log 3e444ad88..f5964c36e --date=short --no-merges --format='%ad %ae %s'
2018-01-31 xhwang Remove carriage return (CR) in Windows CC_IDENT string
2018-01-30 xhwang Updating build configs for M66 roll
2018-01-29 xhwang media: Update build_ffmpeg.py to pull Android API level
2018-01-25 xhwang Merge FFmpeg for M66.
2018-01-19 chcunningham Remove ffmpegsumo.dll cruft.
2018-01-21 sw v4l2_m2m: Fix integer overflow in timestamp handling
2018-01-21 jamrial avcodec/mpeg12dec: fix preprocessor check for mpeg1_nvdec hwaccel
2018-01-21 sw v4l2_m2m: Fix free of the wrong pointer in an error path
2018-01-08 jun.zhao lavfi: add denoise and sharpness VAAPI video filters.
(...)

Created with:
  roll-dep src/third_party/ffmpeg

BUG= 777484 

Change-Id: I91e9bea380dc7782c7f7dee751e268a29d270c12
Reviewed-on: https://chromium-review.googlesource.com/896571
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533516}
[modify] https://crrev.com/f7674370b235981e782b1b2d9032d5a228f1ddde/DEPS

Blockedon: 806580
Blockedon: 808800
Sadly it doesn't look like any of the overflow/leak issues from the last roll are fixed yet either;  issue 771995 . Probably we should setup a hackathon for crunching through these.
+1 I am tracking three issues right now ( issue 804097 ,  issue 806122 ,  issue 806580 ). It'd be great if someone else can pickup one or two.
Blockedon: 804606
Blockedon: 812567
Status: Fixed (was: Started)
The roll has been finished and we are not seeing any regressions. Most issues found by ClusterFuzz are fixed. The fix for  issue 812567  is under discussion. With that I'll mark this issue as fixed.
Blockedon: 816787
Blockedon: -816787

Sign in to add a comment