Can't view cookies in about:net-internals |
|||
Issue descriptionThe option to enable cookie capturing in about:net-internals was on the export page, which has been removed. Seems like we should either restore that ability, or finally remove the page.
,
Oct 31 2017
"That page" meaning net-internals itself. I don't think we should keep around a half-functional page - and debugging cookie issues is part of it's core functionality.
,
Oct 31 2017
I still don't understand what you are referring to. Are you talking about a specific UI surface, or the underlying code? I tested and cookie capture from chrome://net-export/ seems to be working for me. Is there a specific repro case you can point me to? The net-internals javascript has some lingering references to auth/cookie stripping, that could be cleaned out (it still has much of the code for creating log files), but that shouldn't be UI visible.
,
Oct 31 2017
Oh, I suspect you mean that the realtime view on chrome://net-internals/#events does not show cookies (except if you enable byte-logging)
,
Oct 31 2017
Cookie capture in about:net-internals does not work. The option to view them was in the export tab, which was removed, so when capturing a log (Something net-internals still at least nominally supports), you can't view cookies. I think we should either finally rip out net-internals, or restore the broken functionality.
,
Oct 31 2017
I'll remove the privacy stripping from net-internals, as without export there isn't much use for it. (If user's choose to copy-paste rather than using net-export, eliding information is their responsibility).
,
Oct 31 2017
Works for me. Thanks!
,
Nov 1 2017
On removing chrome://net-internals/#events page, I talked to Eric during offsite. I am planning to give it a try later this quarter or the next so we don't have to maintain two copies of the UI code. Hopefully that'll be here soon :)
,
Nov 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65f9c3dc752c9ac1f9fc53ca22f858d34305d89f commit 65f9c3dc752c9ac1f9fc53ca22f858d34305d89f Author: Eric Roman <eroman@chromium.org> Date: Wed Nov 01 20:19:20 2017 Don't strip cookies/auth when viewing chrome://net-internals/#events It used to be that you could select whether to strip cookies and auth headers for export, with the default being to strip. The ability to export was since removed, which also lost the option to disable stripping. This change removes stripping all together. (With stripping removed from net-internals#events, users can inadvertently expose data when copy-pasting visualizations of the net log, however this is considered out of scope.) Ultimately this won't matter as net-internals#events is slated for eventual removal ( crbug.com/678391 ). Bug: 777473 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7833e3c1f15feab8acf8609a82cbc9e2f2dae422 Reviewed-on: https://chromium-review.googlesource.com/747864 Reviewed-by: Helen Li <xunjieli@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#513241} [modify] https://crrev.com/65f9c3dc752c9ac1f9fc53ca22f858d34305d89f/chrome/browser/resources/net_internals/events_view.js [modify] https://crrev.com/65f9c3dc752c9ac1f9fc53ca22f858d34305d89f/chrome/browser/resources/net_internals/log_util.js [modify] https://crrev.com/65f9c3dc752c9ac1f9fc53ca22f858d34305d89f/chrome/browser/resources/net_internals/log_view_painter.js [modify] https://crrev.com/65f9c3dc752c9ac1f9fc53ca22f858d34305d89f/chrome/browser/resources/net_internals/main.js [modify] https://crrev.com/65f9c3dc752c9ac1f9fc53ca22f858d34305d89f/chrome/browser/resources/net_internals/source_entry.js [modify] https://crrev.com/65f9c3dc752c9ac1f9fc53ca22f858d34305d89f/chrome/browser/resources/net_internals/source_tracker.js [modify] https://crrev.com/65f9c3dc752c9ac1f9fc53ca22f858d34305d89f/chrome/test/data/webui/net_internals/log_util.js [modify] https://crrev.com/65f9c3dc752c9ac1f9fc53ca22f858d34305d89f/chrome/test/data/webui/net_internals/log_view_painter.js
,
Nov 1 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by eroman@chromium.org
, Oct 31 2017