https://rsolomakhin.github.io/payment-handler/#filtering-of-payment-instruments
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95984a3b7d4cacbe2ff7ad4653302af75922973f commit 95984a3b7d4cacbe2ff7ad4653302af75922973f Author: gogerald <gogerald@google.com> Date: Tue Oct 31 23:20:24 2017 [Payments] Filtering service worker payment apps based on capabilities This CL parses and stores 'basic-card' specific capabilities, and uses them to filter service worker payment apps. The capabilities will also be used to filter modifiers. Bug: 777470 Change-Id: Ifab1054ec3bccd4f279cde5348cc68abf504a88d Reviewed-on: https://chromium-review.googlesource.com/730845 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Chris Palmer <palmer@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#512994} [modify] https://crrev.com/95984a3b7d4cacbe2ff7ad4653302af75922973f/chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentApp.java [modify] https://crrev.com/95984a3b7d4cacbe2ff7ad4653302af75922973f/chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java [modify] https://crrev.com/95984a3b7d4cacbe2ff7ad4653302af75922973f/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestServiceWorkerPaymentAppTest.java [modify] https://crrev.com/95984a3b7d4cacbe2ff7ad4653302af75922973f/chrome/browser/android/payments/service_worker_payment_app_bridge.cc [modify] https://crrev.com/95984a3b7d4cacbe2ff7ad4653302af75922973f/components/payments/core/BUILD.gn [modify] https://crrev.com/95984a3b7d4cacbe2ff7ad4653302af75922973f/components/test/data/payments/bobpay_and_basic_card_with_modifiers.js [add] https://crrev.com/95984a3b7d4cacbe2ff7ad4653302af75922973f/components/test/data/payments/bobpay_and_basic_card_with_optional_data.js [add] https://crrev.com/95984a3b7d4cacbe2ff7ad4653302af75922973f/components/test/data/payments/payment_request_bobpay_and_basic_card_with_optional_data_test.html [modify] https://crrev.com/95984a3b7d4cacbe2ff7ad4653302af75922973f/content/browser/payments/payment_app.proto [modify] https://crrev.com/95984a3b7d4cacbe2ff7ad4653302af75922973f/content/browser/payments/payment_app_database.cc [modify] https://crrev.com/95984a3b7d4cacbe2ff7ad4653302af75922973f/content/public/browser/stored_payment_app.cc [modify] https://crrev.com/95984a3b7d4cacbe2ff7ad4653302af75922973f/content/public/browser/stored_payment_app.h [modify] https://crrev.com/95984a3b7d4cacbe2ff7ad4653302af75922973f/third_party/WebKit/Source/modules/payments/BUILD.gn [add] https://crrev.com/95984a3b7d4cacbe2ff7ad4653302af75922973f/third_party/WebKit/Source/modules/payments/BasicCardHelper.cpp [add] https://crrev.com/95984a3b7d4cacbe2ff7ad4653302af75922973f/third_party/WebKit/Source/modules/payments/BasicCardHelper.h [modify] https://crrev.com/95984a3b7d4cacbe2ff7ad4653302af75922973f/third_party/WebKit/Source/modules/payments/PaymentInstruments.cpp [modify] https://crrev.com/95984a3b7d4cacbe2ff7ad4653302af75922973f/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp [modify] https://crrev.com/95984a3b7d4cacbe2ff7ad4653302af75922973f/third_party/WebKit/public/platform/modules/payments/payment_app.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9d06e19334c8ca618b642ffacfe0905ecb8e4e5 commit a9d06e19334c8ca618b642ffacfe0905ecb8e4e5 Author: Daniel Bratell <bratell@opera.com> Date: Wed Nov 01 14:01:27 2017 Unduplicate a kMaxListSize constant that broke jumbo builds The two kMaxListSize constants collided in jumbo builds where files are merged before compilation, for higher build performance. This patch makes the constants be shared. Bug: 777470 Change-Id: Idf90fcf389ba3895b4f0e28b4649f11ff5f8257e Reviewed-on: https://chromium-review.googlesource.com/749142 Commit-Queue: Daniel Bratell <bratell@opera.com> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#513119} [modify] https://crrev.com/a9d06e19334c8ca618b642ffacfe0905ecb8e4e5/third_party/WebKit/Source/modules/payments/BasicCardHelper.cpp [modify] https://crrev.com/a9d06e19334c8ca618b642ffacfe0905ecb8e4e5/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp [modify] https://crrev.com/a9d06e19334c8ca618b642ffacfe0905ecb8e4e5/third_party/WebKit/Source/modules/payments/PaymentRequest.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/baae088436460d3c04fde7e801b435f7a0d3f294 commit baae088436460d3c04fde7e801b435f7a0d3f294 Author: gogerald <gogerald@google.com> Date: Thu Nov 02 00:34:22 2017 [Payments] Filtering modifiers based on capabilities Bug: 777470 Change-Id: I46cb95ec97f2ca95c7bd18db2efac1d4badd7f76 Reviewed-on: https://chromium-review.googlesource.com/738434 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#513340} [modify] https://crrev.com/baae088436460d3c04fde7e801b435f7a0d3f294/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java [modify] https://crrev.com/baae088436460d3c04fde7e801b435f7a0d3f294/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java [add] https://crrev.com/baae088436460d3c04fde7e801b435f7a0d3f294/chrome/android/java/src/org/chromium/chrome/browser/payments/BasicCardUtils.java [modify] https://crrev.com/baae088436460d3c04fde7e801b435f7a0d3f294/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java [modify] https://crrev.com/baae088436460d3c04fde7e801b435f7a0d3f294/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java [modify] https://crrev.com/baae088436460d3c04fde7e801b435f7a0d3f294/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java [modify] https://crrev.com/baae088436460d3c04fde7e801b435f7a0d3f294/chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentApp.java [modify] https://crrev.com/baae088436460d3c04fde7e801b435f7a0d3f294/chrome/android/java_sources.gni [modify] https://crrev.com/baae088436460d3c04fde7e801b435f7a0d3f294/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppAndBasicCardWithModifiersTest.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/137f37a0077cd922da37338d79e51d65a428ff3a commit 137f37a0077cd922da37338d79e51d65a428ff3a Author: gogerald <gogerald@google.com> Date: Thu Nov 02 17:04:26 2017 [Payments] Format function names and remove redundant variable Bug: 777470 Change-Id: Ib73e1c9dd06e7d894dc7bc0f838fc2b99e308566 Reviewed-on: https://chromium-review.googlesource.com/751282 Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#513523} [modify] https://crrev.com/137f37a0077cd922da37338d79e51d65a428ff3a/chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentApp.java [modify] https://crrev.com/137f37a0077cd922da37338d79e51d65a428ff3a/third_party/WebKit/Source/modules/payments/BasicCardHelper.cpp [modify] https://crrev.com/137f37a0077cd922da37338d79e51d65a428ff3a/third_party/WebKit/Source/modules/payments/BasicCardHelper.h [modify] https://crrev.com/137f37a0077cd922da37338d79e51d65a428ff3a/third_party/WebKit/Source/modules/payments/PaymentInstruments.cpp [modify] https://crrev.com/137f37a0077cd922da37338d79e51d65a428ff3a/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9fb63265c9fae7e0b22420a01557682a47ea839f commit 9fb63265c9fae7e0b22420a01557682a47ea839f Author: gogerald <gogerald@google.com> Date: Thu Nov 02 17:06:38 2017 [Payments] Do not send canMakePayment event for basic-card Bug: 777470 Change-Id: I81c729020e5c3fc38ba2332dedd872dc878e08d4 Reviewed-on: https://chromium-review.googlesource.com/751561 Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#513524} [modify] https://crrev.com/9fb63265c9fae7e0b22420a01557682a47ea839f/chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentApp.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6cf12fe2d09c08bb4838cab932f18ba7527e15a8 commit 6cf12fe2d09c08bb4838cab932f18ba7527e15a8 Author: gogerald <gogerald@google.com> Date: Wed Nov 08 21:29:55 2017 [Payments] Filtering modifiers based on capabilities Bug: 777470 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9a143c2db2a1bb9989feb2464b25182bb4c5b702 Reviewed-on: https://chromium-review.googlesource.com/753793 Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#514944} [modify] https://crrev.com/6cf12fe2d09c08bb4838cab932f18ba7527e15a8/components/payments/content/payment_request_converter.cc [modify] https://crrev.com/6cf12fe2d09c08bb4838cab932f18ba7527e15a8/components/payments/content/payment_request_converter.h [modify] https://crrev.com/6cf12fe2d09c08bb4838cab932f18ba7527e15a8/components/payments/content/payment_request_spec.cc [modify] https://crrev.com/6cf12fe2d09c08bb4838cab932f18ba7527e15a8/components/payments/content/service_worker_payment_instrument.cc [modify] https://crrev.com/6cf12fe2d09c08bb4838cab932f18ba7527e15a8/components/payments/content/service_worker_payment_instrument.h [modify] https://crrev.com/6cf12fe2d09c08bb4838cab932f18ba7527e15a8/components/payments/content/service_worker_payment_instrument_unittest.cc [modify] https://crrev.com/6cf12fe2d09c08bb4838cab932f18ba7527e15a8/components/payments/core/autofill_payment_instrument.cc [modify] https://crrev.com/6cf12fe2d09c08bb4838cab932f18ba7527e15a8/components/payments/core/autofill_payment_instrument.h [modify] https://crrev.com/6cf12fe2d09c08bb4838cab932f18ba7527e15a8/components/payments/core/payment_instrument.h [modify] https://crrev.com/6cf12fe2d09c08bb4838cab932f18ba7527e15a8/ios/chrome/browser/payments/ios_payment_instrument.h [modify] https://crrev.com/6cf12fe2d09c08bb4838cab932f18ba7527e15a8/ios/chrome/browser/payments/ios_payment_instrument.mm [modify] https://crrev.com/6cf12fe2d09c08bb4838cab932f18ba7527e15a8/ios/chrome/browser/payments/payment_request.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a8e88e51b5e07ef25e1a7504447ed1b27f6e3e0 commit 0a8e88e51b5e07ef25e1a7504447ed1b27f6e3e0 Author: Rouslan Solomakhin <rouslan@chromium.org> Date: Tue Nov 14 14:25:15 2017 [Payments] Capability matching for payment handlers on desktop. Before this patch, payment handlers for "basic-card" would always be shown in desktop payments UI, even if their "capabilities" field did not match the merchant's request. This patch sends the full PaymentMethodData array to the ServiceWorkerPaymentAppFactory, so the factory can compare the "capabilities" of payment handlers for "basic-card" to the merchant's requested PaymentMethodData. The factory compares the capabilities only for "basic-card". After this patch, a payment handler for "basic-card" shows up in desktop payments UI only if its "capabilities" field matches the merchant request. Bug: 777470 Change-Id: I9b6c9f3371f8f3e2091d56aa087c0b98f0ff3278 Reviewed-on: https://chromium-review.googlesource.com/744541 Reviewed-by: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Ganggui Tang <gogerald@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#516295} [modify] https://crrev.com/0a8e88e51b5e07ef25e1a7504447ed1b27f6e3e0/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFactory.java [modify] https://crrev.com/0a8e88e51b5e07ef25e1a7504447ed1b27f6e3e0/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentAppFactory.java [modify] https://crrev.com/0a8e88e51b5e07ef25e1a7504447ed1b27f6e3e0/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java [modify] https://crrev.com/0a8e88e51b5e07ef25e1a7504447ed1b27f6e3e0/chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java [modify] https://crrev.com/0a8e88e51b5e07ef25e1a7504447ed1b27f6e3e0/chrome/browser/android/payments/service_worker_payment_app_bridge.cc [modify] https://crrev.com/0a8e88e51b5e07ef25e1a7504447ed1b27f6e3e0/chrome/browser/payments/service_worker_payment_app_factory_browsertest.cc [modify] https://crrev.com/0a8e88e51b5e07ef25e1a7504447ed1b27f6e3e0/components/payments/content/payment_request_state.cc [modify] https://crrev.com/0a8e88e51b5e07ef25e1a7504447ed1b27f6e3e0/components/payments/content/service_worker_payment_app_factory.cc [modify] https://crrev.com/0a8e88e51b5e07ef25e1a7504447ed1b27f6e3e0/components/payments/content/service_worker_payment_app_factory.h [modify] https://crrev.com/0a8e88e51b5e07ef25e1a7504447ed1b27f6e3e0/components/payments/content/service_worker_payment_app_factory_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a825624f6d44dc535a1aed7c3cd5718d95d06a01 commit a825624f6d44dc535a1aed7c3cd5718d95d06a01 Author: Rouslan Solomakhin <rouslan@chromium.org> Date: Tue Nov 14 15:26:35 2017 Revert "[Payments] Capability matching for payment handlers on desktop." This reverts commit 0a8e88e51b5e07ef25e1a7504447ed1b27f6e3e0. Reason for revert: Broke build. https://luci-milo.appspot.com/buildbot/internal.client.clank_tot/clang-clankium-tot-builder/52982 Original change's description: > [Payments] Capability matching for payment handlers on desktop. > > Before this patch, payment handlers for "basic-card" would always be > shown in desktop payments UI, even if their "capabilities" field did not > match the merchant's request. > > This patch sends the full PaymentMethodData array to the > ServiceWorkerPaymentAppFactory, so the factory can compare the > "capabilities" of payment handlers for "basic-card" to the merchant's > requested PaymentMethodData. The factory compares the capabilities only > for "basic-card". > > After this patch, a payment handler for "basic-card" shows up in desktop > payments UI only if its "capabilities" field matches the merchant > request. > > Bug: 777470 > Change-Id: I9b6c9f3371f8f3e2091d56aa087c0b98f0ff3278 > Reviewed-on: https://chromium-review.googlesource.com/744541 > Reviewed-by: Mathieu Perreault <mathp@chromium.org> > Reviewed-by: Ganggui Tang <gogerald@chromium.org> > Commit-Queue: Mathieu Perreault <mathp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#516295} TBR=rouslan@chromium.org,mathp@chromium.org,gogerald@chromium.org Change-Id: I25260d461ebd180c817c5cf2943faaaee74245f9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 777470 Reviewed-on: https://chromium-review.googlesource.com/768604 Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#516305} [modify] https://crrev.com/a825624f6d44dc535a1aed7c3cd5718d95d06a01/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFactory.java [modify] https://crrev.com/a825624f6d44dc535a1aed7c3cd5718d95d06a01/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentAppFactory.java [modify] https://crrev.com/a825624f6d44dc535a1aed7c3cd5718d95d06a01/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java [modify] https://crrev.com/a825624f6d44dc535a1aed7c3cd5718d95d06a01/chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java [modify] https://crrev.com/a825624f6d44dc535a1aed7c3cd5718d95d06a01/chrome/browser/android/payments/service_worker_payment_app_bridge.cc [modify] https://crrev.com/a825624f6d44dc535a1aed7c3cd5718d95d06a01/chrome/browser/payments/service_worker_payment_app_factory_browsertest.cc [modify] https://crrev.com/a825624f6d44dc535a1aed7c3cd5718d95d06a01/components/payments/content/payment_request_state.cc [modify] https://crrev.com/a825624f6d44dc535a1aed7c3cd5718d95d06a01/components/payments/content/service_worker_payment_app_factory.cc [modify] https://crrev.com/a825624f6d44dc535a1aed7c3cd5718d95d06a01/components/payments/content/service_worker_payment_app_factory.h [modify] https://crrev.com/a825624f6d44dc535a1aed7c3cd5718d95d06a01/components/payments/content/service_worker_payment_app_factory_unittest.cc
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/74d86bb3a5e7055b5bb432cbaf6e4077f8a9f957 commit 74d86bb3a5e7055b5bb432cbaf6e4077f8a9f957 Author: Rouslan Solomakhin <rouslan@chromium.org> Date: Tue Nov 14 17:24:40 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06df42d1896499a52c1ecf57c9847d846ba72a7d commit 06df42d1896499a52c1ecf57c9847d846ba72a7d Author: Rouslan Solomakhin <rouslan@chromium.org> Date: Tue Nov 14 20:35:11 2017 Reland "[Payments] Capability matching for payment handlers on desktop." This is a reland of 0a8e88e51b5e07ef25e1a7504447ed1b27f6e3e0 Original change's description: > [Payments] Capability matching for payment handlers on desktop. > > Before this patch, payment handlers for "basic-card" would always be > shown in desktop payments UI, even if their "capabilities" field did not > match the merchant's request. > > This patch sends the full PaymentMethodData array to the > ServiceWorkerPaymentAppFactory, so the factory can compare the > "capabilities" of payment handlers for "basic-card" to the merchant's > requested PaymentMethodData. The factory compares the capabilities only > for "basic-card". > > After this patch, a payment handler for "basic-card" shows up in desktop > payments UI only if its "capabilities" field matches the merchant > request. > > Bug: 777470 > Change-Id: I9b6c9f3371f8f3e2091d56aa087c0b98f0ff3278 > Reviewed-on: https://chromium-review.googlesource.com/744541 > Reviewed-by: Mathieu Perreault <mathp@chromium.org> > Reviewed-by: Ganggui Tang <gogerald@chromium.org> > Commit-Queue: Mathieu Perreault <mathp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#516295} TBR=gogerald@chromium.org, mathp@chromium.org Bug: 777470 Change-Id: Ib71a71a0e97fe5076c537aeed14bce11292f2433 Reviewed-on: https://chromium-review.googlesource.com/769188 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#516411} [modify] https://crrev.com/06df42d1896499a52c1ecf57c9847d846ba72a7d/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFactory.java [modify] https://crrev.com/06df42d1896499a52c1ecf57c9847d846ba72a7d/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentAppFactory.java [modify] https://crrev.com/06df42d1896499a52c1ecf57c9847d846ba72a7d/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java [modify] https://crrev.com/06df42d1896499a52c1ecf57c9847d846ba72a7d/chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java [modify] https://crrev.com/06df42d1896499a52c1ecf57c9847d846ba72a7d/chrome/browser/android/payments/service_worker_payment_app_bridge.cc [modify] https://crrev.com/06df42d1896499a52c1ecf57c9847d846ba72a7d/chrome/browser/payments/service_worker_payment_app_factory_browsertest.cc [modify] https://crrev.com/06df42d1896499a52c1ecf57c9847d846ba72a7d/components/payments/content/payment_request_state.cc [modify] https://crrev.com/06df42d1896499a52c1ecf57c9847d846ba72a7d/components/payments/content/service_worker_payment_app_factory.cc [modify] https://crrev.com/06df42d1896499a52c1ecf57c9847d846ba72a7d/components/payments/content/service_worker_payment_app_factory.h [modify] https://crrev.com/06df42d1896499a52c1ecf57c9847d846ba72a7d/components/payments/content/service_worker_payment_app_factory_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a849d4c73a1bebf01e653cca0f79ac2eb3e7b3aa commit a849d4c73a1bebf01e653cca0f79ac2eb3e7b3aa Author: gogerald <gogerald@google.com> Date: Tue Nov 28 17:38:42 2017 [Payments] Do not match capabilities again. Do not match capabilities again since it has been done in ServiceWorkerPaymentAppFactory. Note that, the capability related matching tests for getInstruments is not applicable anymore, so they have been modified to test matching modifiers which use the same matching rules. Bug: 777470 Change-Id: Ib01ad930b48b2ab5e78b13aa5b73c1e1fa4cf645 Reviewed-on: https://chromium-review.googlesource.com/788452 Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#519729} [modify] https://crrev.com/a849d4c73a1bebf01e653cca0f79ac2eb3e7b3aa/chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentApp.java [modify] https://crrev.com/a849d4c73a1bebf01e653cca0f79ac2eb3e7b3aa/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestServiceWorkerPaymentAppTest.java [modify] https://crrev.com/a849d4c73a1bebf01e653cca0f79ac2eb3e7b3aa/components/payments/core/BUILD.gn [add] https://crrev.com/a849d4c73a1bebf01e653cca0f79ac2eb3e7b3aa/components/test/data/payments/bobpay_and_basic_card_with_modifier_optional_data.js [delete] https://crrev.com/0bd5352f4973f3d84a8e09c0a5898cbb993d3310/components/test/data/payments/bobpay_and_basic_card_with_optional_data.js [add] https://crrev.com/a849d4c73a1bebf01e653cca0f79ac2eb3e7b3aa/components/test/data/payments/payment_request_bobpay_and_basic_card_with_modifier_optional_data_test.html [delete] https://crrev.com/0bd5352f4973f3d84a8e09c0a5898cbb993d3310/components/test/data/payments/payment_request_bobpay_and_basic_card_with_optional_data_test.html
Comment 1 by rouslan@chromium.org
, Oct 30 2017