New issue
Advanced search Search tips

Issue 777440 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Feb 2018
Cc:
wfh@chromium.org
creis@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Chrome , Mac , Fuchsia
Pri: 2
Type: Task

Blocking:
issue 598069



Sign in to add a comment

Convert Feature Policy IPCs to Mojo

Project Member Reported by iclell...@chromium.org, Oct 23 2017 
Feature Policy messages should be migrated from Chromium IPC to mojo.

Most of the feature-policy messages are tightly integrated with frame replication for OOPIF, so this may be blocked on 654991.

Feature policy messages are also tied with sandbox flags (combined as frame policy) in many cases, so that will need to be accounted for as well.

These IPCs are currently responsible for maintaining policy objects between browser and renderer:

* FrameHostMsg_DidSetFeaturePolicyHeader (probably changed soon to FrameHostMsg_DidSetFramePolicyHeaders)
* FrameMsg_DidUpdateFramePolicy
* FrameHostMsg_DidChangeFramePolicy
* FrameHostMsg_CreateChildFrame
* FrameMsg_SwapOut

Comment 1 by jam@chromium.org, Oct 23 2017

Blockedon: -654991
Summary: Feature Policy (was: Content Modularization Project: Feature Policy)
navigation service is orthogonal from IPC->mojo conversions (i.e. we can convert all IPCs to mojo independent of the navigation service).

I'm going to remove the blocker as a result; if you disagree we can chat more? Thanks!

PS also removing "Content Modularization Project" as that's for new services, while this is tracking IPC conversion.

Comment 2 by iclell...@chromium.org, Oct 23 2017

Summary: Convert Feature Policy IPCs to Mojo (was: Feature Policy)
SGTM, thanks -- I wasn't certain whether there were cross-IPC relationships between navigation and frame replication, esp wrt to cross-origin navigation and proxy creation, which might cause this to block on navigation service work.

(The "Content Modularization Project" prefix just looked like common nomenclature for all of the mojo conversion issues. I've added something a bit more descriptive now)

Comment 3 by jam@chromium.org, Oct 23 2017 

if by cross-IPC you mean the need to maintain ordering between mojo & old IPC, channel-associated interfaces solve that problem. more info at https://www.chromium.org/developers/design-documents/mojo/mojo-migration-guide

Comment 4 by laforge@google.com, Nov 7 2017

Components: Internals>Services
Labels: Type-Task
Appending component Internals>Services to S13N projects and changing the Type (for tracking sake) to Type=Task.

Comment 5 by lucmult@google.com, Nov 24 2017 

Hi,

I started on the conversion for FrameHostMsg_DidSetFramePolicyHeaders via crbug.com/786836.

CL:
https://chromium-review.googlesource.com/c/chromium/src/+/784372

Cheers.

Comment 6 by loonyb...@chromium.org, Feb 14 2018

Labels: -OS-Linux -OS-Android
Status: Fixed (was: Available)
►

Sign in to add a comment