libjingle_xmpp/xmpp/xmppengineimpl_iq.cc:32 private field 'engine_' is not used |
|||||
Issue descriptionWhen checking if webrtc could handle jumbo compilations (merged cc files for dramatically faster builds) one of the errors was that xmppengineimp-iq.cc:32 private field 'engine_' is not used Probably something trivial.
,
Nov 21 2017
,
Jan 18 2018
Ping for triaging.
,
Jan 18 2018
The problem isn't obvious and I haven't seen it for a while so closing WontFix for now. Will reopen if and when it appears again.
,
Jan 18 2018
Actually, I was wrong. It's quite obvious so reopening again. XmppIqEntry in third_party/libjingle_xmpp/xmpp/xmppengineimpl_iq.cc has an unused field engine_ phoglund, do you have a libjingle tree (it's almost Christmas still). Then this is a nice distraction. Though if there had been a lower priority than P3 this is probably it. Just 8 bytes per XmppIqEntry and I doubt there are many of those.
,
Jan 18 2018
Hi! That code is just straight checked in to the chromium tree - it doesn't come from WebRTC (at least not anymore). I think that's easy for you to fix yourself.
,
Jan 18 2018
So it is! Thanks!
,
Jan 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6475613c4b9089d7e70ae02b8e1a6d1ddbb19ec2 commit 6475613c4b9089d7e70ae02b8e1a6d1ddbb19ec2 Author: Daniel Bratell <bratell@opera.com> Date: Mon Jan 22 22:54:28 2018 Removing dead engine_ field i libjingle_xmpp Jumbo build experiments noticed that no code ever read engine_ in XmppIqEntry in libjingle_xmpp. Normal build didn't because "friend class XmppEngineImpl" required the compiler to know what XmppEngineImpl does as well. Bug: 777434 Change-Id: I661a5346617a92ee912060bebf35801dbe1a8797 Reviewed-on: https://chromium-review.googlesource.com/873371 Reviewed-by: Tommi <tommi@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#531039} [modify] https://crrev.com/6475613c4b9089d7e70ae02b8e1a6d1ddbb19ec2/third_party/libjingle_xmpp/xmpp/xmppengineimpl_iq.cc
,
Feb 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d69f8fb824ba8045669117f0c1b195b6c5691387 commit d69f8fb824ba8045669117f0c1b195b6c5691387 Author: Harald Alvestrand <hta@chromium.org> Date: Thu Feb 08 05:18:09 2018 Update README for libjingle_xmpp While discussing crbug.com/777434, it became obvious to the reviewers that this code is only used by Chrome. Making this obvious to people who read the README too. Bug: 777434 Change-Id: I0a9ee0f42f865ad96078cd4874642be6c11b83af Reviewed-on: https://chromium-review.googlesource.com/890448 Reviewed-by: Tommi <tommi@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#535308} [modify] https://crrev.com/d69f8fb824ba8045669117f0c1b195b6c5691387/third_party/libjingle_xmpp/README.chromium |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by guidou@chromium.org
, Oct 24 2017