Setting the ADS setting to the default value should not populate the ADS_DATA WebsiteSetting |
||||||
Issue descriptionThis happens now and is occurring when the ADS setting is being added to desktop Site Details.
,
Oct 23 2017
For context, we were using this to reset the "smart UI" which blocks the infobar from popping up on Android too many times. This is just a UI tweak and isn't really necessary.
,
Oct 23 2017
I confirmed that this bug manifests itself in Android site details, so this issue will probably need to be merged to M63. The fix is very simple so it should be easily merged.
,
Oct 23 2017
To be a bit more clear, the bug reproduction is: 1. Start Chrome with subresource filter enabled / experimental UI turned on. 2. Visit any site, go to the Site Details page 3. Press the "CLEAR & RESET" button 4. Go to page info, see that the site is marked as having intrusive ads. (BUG)
,
Oct 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/183ad2f45380b3ec4a4c2afc71e841e21fc5e6cb commit 183ad2f45380b3ec4a4c2afc71e841e21fc5e6cb Author: Charles Harrison <csharrison@chromium.org> Date: Mon Oct 23 16:11:51 2017 [subresource_filter] Setting ADS setting to default shouldn't populate metadata Bug: 777430 Change-Id: I85fc949e6257c00458533e2491f6d40fb5d12e2d Reviewed-on: https://chromium-review.googlesource.com/732072 Reviewed-by: Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#510812} [modify] https://crrev.com/183ad2f45380b3ec4a4c2afc71e841e21fc5e6cb/chrome/browser/subresource_filter/subresource_filter_content_settings_manager.cc [modify] https://crrev.com/183ad2f45380b3ec4a4c2afc71e841e21fc5e6cb/chrome/browser/subresource_filter/subresource_filter_content_settings_manager_unittest.cc
,
Oct 23 2017
I'd like to request a merge for the above change (once it has baked in canary for a bit) to M63. The change is very straightforward and fixes a fairly significant UI regression for a feature that is intended to launch in M63 (described in #4).
,
Oct 23 2017
Please add appropriate OSs.
,
Oct 23 2017
The following OSes are impacted, though this is predominantly an Android issue.
,
Oct 24 2017
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/705dece0dfef8a2ee64f6e4558d41de604492158 commit 705dece0dfef8a2ee64f6e4558d41de604492158 Author: Charles Harrison <csharrison@chromium.org> Date: Tue Oct 24 17:48:40 2017 [subresource_filter] Setting ADS setting to default shouldn't populate metadata TBR=shivanisha@chromium.org Bug: 777430 Change-Id: I85fc949e6257c00458533e2491f6d40fb5d12e2d Reviewed-on: https://chromium-review.googlesource.com/732072 Reviewed-by: Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#510812}(cherry picked from commit 183ad2f45380b3ec4a4c2afc71e841e21fc5e6cb) Reviewed-on: https://chromium-review.googlesource.com/735899 Reviewed-by: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#179} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/705dece0dfef8a2ee64f6e4558d41de604492158/chrome/browser/subresource_filter/subresource_filter_content_settings_manager.cc [modify] https://crrev.com/705dece0dfef8a2ee64f6e4558d41de604492158/chrome/browser/subresource_filter/subresource_filter_content_settings_manager_unittest.cc |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by csharrison@chromium.org
, Oct 23 2017