New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 777423 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: ----
Type: ----



Sign in to add a comment

http/tests/devtools/sources/debugger-ui/function-details.js failing (webkit_layout_tests failing on chromium.webkit/WebKit Mac10.12)

Project Member Reported by battre@chromium.org, Oct 23 2017

Issue description

webkit_layout_tests failing on chromium.webkit/WebKit Mac10.12

Builders failed on: 
- WebKit Mac10.12: 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.12


--- /b/s/w/io9TBmgY/layout-test-results/http/tests/devtools/sources/debugger-ui/function-details-expected.txt
+++ /b/s/w/io9TBmgY/layout-test-results/http/tests/devtools/sources/debugger-ui/function-details-actual.txt
@@ -1,3 +1,6 @@
+CONSOLE ERROR: line 57: Uncaught TypeError: Cannot read property 'dispatchMessage' of undefined
+CONSOLE ERROR: line 57: Uncaught TypeError: Cannot read property 'dispatchMessage' of undefined
+CONSOLE ERROR: line 57: Uncaught TypeError: Cannot read property 'dispatchMessage' of undefined
 Tests that Debugger.getFunctionDetails command returns correct location.  Bug 71808 
 

Flakiness started here but there is no obvious culprit:
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/63681
 

Comment 1 by battre@chromium.org, Oct 23 2017

Labels: -Sheriff-Chromium
Assigned it to you probably incorrectly due to your refactoring https://chromium-review.googlesource.com/c/chromium/src/+/728711

Can you help find an owner, please?
Components: Platform>DevTools
Cc: pfeldman@chromium.org
How does one disable a flaky DevTools JS test?
Labels: Test-Layout
Marking the test flaky in https://crrev.com/c/733460.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a70043e7f01603635c8307ccf418ccb8692f9ccf

commit a70043e7f01603635c8307ccf418ccb8692f9ccf
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Mon Oct 23 17:38:46 2017

[DevTools] Mark function-details.js flaky.

Bug:  777423 
Change-Id: Iabab30161d451ab1104ef96325a908ea529b9c61
TBR: pfeldman@chromium.org, chenwilliam@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/733460
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510837}
[modify] https://crrev.com/a70043e7f01603635c8307ccf418ccb8692f9ccf/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9926a8a52a0de59a3044d7838159ea0dca467c3a

commit 9926a8a52a0de59a3044d7838159ea0dca467c3a
Author: Will Chen <chenwilliam@chromium.org>
Date: Tue Nov 14 21:01:53 2017

DevTools: update TestExpectations in http/tests/devtools/sources/debugger-ui/function-details.js

These tests were disabled because of a flakiness with the new DevTools test
framework which has subsequently been fixed:
* https://chromium-review.googlesource.com/c/chromium/src/+/761957

TBR=rouslan@chromium.org

Bug:  777423 
Change-Id: I543e9fbe77c82bc3565f8eebd88e9de0fd20faca
Reviewed-on: https://chromium-review.googlesource.com/769345
Reviewed-by: Will Chen <chenwilliam@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516421}
[modify] https://crrev.com/9926a8a52a0de59a3044d7838159ea0dca467c3a/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Assigned)

Sign in to add a comment