New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 777408 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

84.2% regression in system_health.memory_mobile at 510508:510575

Project Member Reported by pmeenan@chromium.org, Oct 23 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Oct 23 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=777408

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=ecd7fa091e513ec682b62a9a6ec59d8dab5748508074790277972e2d001cb8dd


Bot(s) for this bug's original alert(s):

android-webview-nexus6
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Oct 23 2017

Cc: jvanverth@google.com
Owner: jvanverth@google.com
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author jvanverth@google.com ===

Hi jvanverth@google.com, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Jim Van Verth
  Commit : 58c3cce1144f83bc7e4ee5e93931b8721560735b
  Date   : Fri Oct 20 12:28:05 2017
  Subject: Clip text geometrically when possible.

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_chrome:skia:effective_size_avg/browse_social/browse_social_instagram
  Change       : 84.16% | 549316.0 -> 1011624.0

Revision                             Result              N
chromium@510507                      549316 +- 0.0       6      good
chromium@510541                      549316 +- 0.0       6      good
chromium@510543                      549316 +- 0.0       6      good
chromium@510543,skia@58c3cce114      1011624 +- 0.0      6      bad       <--
chromium@510543,skia@b68defab6d      1011624 +- 0.0      6      bad
chromium@510543,skia@dbfecd06ad      1011624 +- 0.0      6      bad
chromium@510543,skia@5a83f59091      1011624 +- 0.0      6      bad
chromium@510544                      1011624 +- 0.0      6      bad
chromium@510546                      1011624 +- 0.0      6      bad
chromium@510550                      1011624 +- 0.0      6      bad
chromium@510558                      1011624 +- 0.0      6      bad
chromium@510575                      1011624 +- 0.0      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.social.instagram system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8964938927147624624


For feedback, file a bug with component Speed>Bisection
Status: Fixed (was: Assigned)
Fixed by https://skia-review.googlesource.com/c/skia/+/62861.

Sign in to add a comment