New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 777399 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3% regression in smoothness.tough_animation_cases at 509186:509279

Project Member Reported by pmeenan@chromium.org, Oct 23 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Oct 23 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=777399

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=5e7af25e34da4843047d1a05bef554a2980dc7d9aa10e2111aafc13c4842bb0d


Bot(s) for this bug's original alert(s):

android-nexus5
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Oct 23 2017

Cc: fmalita@chromium.org
Owner: fmalita@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author fmalita@chromium.org ===

Hi fmalita@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Florin Malita
  Commit : e52c7e8f57c56d4b215406106eccabd11509d8eb
  Date   : Mon Oct 16 23:17:30 2017
  Subject: Remove support for conservative Path bounds

Bisect Details
  Configuration: android_nexus5_perf_bisect
  Benchmark    : smoothness.tough_animation_cases
  Metric       : frame_times/balls_javascript_canvas.html
  Change       : 1.69% | 200.478025899 -> 203.861365577

Revision             Result                  N
chromium@509185      200.478 +- 2.86577      6      good
chromium@509188      198.346 +- 3.14589      6      good
chromium@509190      198.889 +- 2.87115      6      good
chromium@509191      204.976 +- 4.18852      6      bad       <--
chromium@509197      204.591 +- 3.7121       6      bad
chromium@509209      205.263 +- 2.87652      6      bad
chromium@509232      204.199 +- 2.49516      6      bad
chromium@509279      203.861 +- 3.02061      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=balls.javascript.canvas.html smoothness.tough_animation_cases

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8964939090128130320


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Oct 23 2017

 Issue 777400  has been merged into this issue.
Cc: caryclark@chromium.org reed@google.com
A small regression is expected, as we are now computing accurate path bounds.

This is a correctness/speed trade-off, and given the minimal magnitude I'm inclined to close/wontfix.
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Oct 24 2017

Cc: kraynov@chromium.org
 Issue 777793  has been merged into this issue.
Status: WontFix (was: Assigned)
WontFix-ing per #5

Sign in to add a comment