InsertParagraphSeparator crashes with unusual HTML |
|||||||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=6591482592231424 Fuzzer: inferno_layout_test_unmodified Job Type: windows_syzyasan_chrome Platform Id: windows Crash Type: Null-dereference Crash Address: 0x00000008 Crash State: blink::InsertParagraphSeparatorCommand::DoApply blink::CompositeEditCommand::ApplyCommandToComposite blink::TypingCommand::InsertParagraphSeparator Memory Tool: SYZYASAN Regressed: https://clusterfuzz.com/revisions?job=windows_syzyasan_chrome&range=449250:449259 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6591482592231424 Issue filed automatically. See https://github.com/google/clusterfuzz-tools for more information.
,
Oct 23 2017
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/5b9a9a6f8c9c646ac542a9e1a2f18c59140849e6 (Check if the next text node has a leading white space). If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.
,
Oct 25 2017
Lower to Pri-3 since real world usage of InsertParagraphSeparator with unusual HTML is low.
,
Nov 2 2017
,
Nov 7 2017
,
Nov 7 2017
,
Dec 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de7b67f8a7810e6170d6a80ba01109791ca36915 commit de7b67f8a7810e6170d6a80ba01109791ca36915 Author: tanvir.rizvi <tanvir.rizvi@samsung.com> Date: Wed Dec 06 06:04:47 2017 [Clusterfuzz] crash in InsertParagraphSeperator InsertParagraphSeperator gets DCHECK(IsEditablePosition) when checking for leading white speace position. This happens on a unusual HTML having, webkit-appearance style applied. Since the layoutBlock in this scenario has a logical height because of appearance property, and layout for table elements like colgroup is LayoutBlockFlow, therefore the visuallyEquivalentAlgorithm considers it as a EditablePosition, and the command for InsertParagraph is executed. Bug: 777378 Change-Id: I2abce4d09e2526f081cd810fc663aec61cfb24bf Reviewed-on: https://chromium-review.googlesource.com/781331 Reviewed-by: yosin (OOO Dec 11 to Jan 8) <yosin@chromium.org> Reviewed-by: Yoichi Osato <yoichio@chromium.org> Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com> Cr-Commit-Position: refs/heads/master@{#522023} [modify] https://crrev.com/de7b67f8a7810e6170d6a80ba01109791ca36915/third_party/WebKit/Source/core/editing/BUILD.gn [modify] https://crrev.com/de7b67f8a7810e6170d6a80ba01109791ca36915/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp [modify] https://crrev.com/de7b67f8a7810e6170d6a80ba01109791ca36915/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.h [add] https://crrev.com/de7b67f8a7810e6170d6a80ba01109791ca36915/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommandTest.cpp
,
Dec 6 2017
ClusterFuzz has detected this issue as fixed in range 521421:521451. Detailed report: https://clusterfuzz.com/testcase?key=6591482592231424 Fuzzer: inferno_layout_test_unmodified Job Type: windows_asan_chrome Platform Id: windows Crash Type: Null-dereference Crash Address: 0x00000008 Crash State: blink::InsertParagraphSeparatorCommand::DoApply blink::CompositeEditCommand::ApplyCommandToComposite blink::TypingCommand::InsertParagraphSeparator Sanitizer: address (ASAN) Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=449250:449259 Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=521421:521451 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6591482592231424 See https://github.com/google/clusterfuzz-tools for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Dec 6 2017
ClusterFuzz testcase 6591482592231424 is verified as fixed, so closing issue as verified. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ClusterFuzz
, Oct 23 2017Labels: Test-Predator-AutoComponents