New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 777376 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Blink of 'Delete' icon with no image preview is seen after clicking on 'Take photo' in 'chrome://settings/changePicture' page

Project Member Reported by mmanchala@chromium.org, Oct 23 2017

Issue description

Chrome Version: 64.0.3246.0/10059.0.0 dev-channel Daisy,Candy and Reks
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> Go to 'chrome://settings/changePicture' page -> click on  'Take photo' option
(2)Now Capture Photo and observe blink of  'Delete' icon with no image preview is seen before Image preview is displayed(Please refer Video and screenshot)

Expected: After Capturing Photo Image preview should be displayed properly
Actual: Instead after clicking on 'Take photo' blink of 'Delete' icon with no image preview is seen

This is Regression Issue as same is working fine in 64.0.3241.0/10041.0.0 dev-channel Reks

@stevenjb : Please confirm the Issue
 
Actual_Preview.webm
2.3 MB View Download
Actual_Preview.jpg
105 KB View Download
Expected_Preview.webm
1008 KB View Download
Note : Issue is seen in Video Mode also i.e.  blink of 'Delete' icon with no Video preview is seen after clicking on 'Take photo' 

Cc: steve...@chromium.org
Owner: reve...@chromium.org
I guess it takes a short amount of time to load an image from an object URL vs using a data URL like before. Just setting the image height might be enough as that avoids having the delete button move.
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa4e970147ffd462b986d309f1aa7f0b39cdaa8c

commit fa4e970147ffd462b986d309f1aa7f0b39cdaa8c
Author: David Reveman <reveman@chromium.org>
Date: Mon Oct 23 22:52:18 2017

Change Picture: Always set height of image preview.

This makes the delay when loading the image less noticeable.

Bug:  777376 
Test: manual
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia9f60d6ef4f55d8635f803f458ffabbfa69a7c3c
Reviewed-on: https://chromium-review.googlesource.com/734230
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510950}
[modify] https://crrev.com/fa4e970147ffd462b986d309f1aa7f0b39cdaa8c/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_pane.html

Labels: M-63
Status: Fixed (was: Started)
Marking as fixed. However, it's not perfect as there's still some delay before the image is displayed but the delete icon is at least not moving anymore so it's much less noticeable. Please re-open if UX determines that more work is required to improve this.
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-63; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-63 label, otherwise remove Merge-TBD label. Thanks.
Status: Verified (was: Fixed)
Verified on M64 dev build (10109.0.0, 64.0.3261.0).
Labels: -Merge-TBD -M-63

Sign in to add a comment