New issue
Advanced search Search tips

Issue 777375 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Skia blurred rect results have changed

Project Member Reported by robertphillips@chromium.org, Oct 23 2017

Issue description


The Skia CL https://skia-review.googlesource.com/c/skia/+/62461 (Make GrRectBlurEffect use bilerp) changes Skia's blurred rects for the better.

It does, however, change the following layout tests:

virtual/gpu/fast/canvas/canvas-shadow-source-in.html
virtual/gpu/fast/canvas/canvas-transforms-fillRect-shadow.html
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6dcb0d096b3a473190af993229ac93ed9bf6e3a7

commit 6dcb0d096b3a473190af993229ac93ed9bf6e3a7
Author: Robert Phillips <robertphillips@google.com>
Date: Mon Oct 23 13:08:26 2017

Suppress layout test for upcoming Skia roll

Bug:  777375 
Change-Id: If5028344e415dce32e0448b8ea932cb986624994
Reviewed-on: https://chromium-review.googlesource.com/732036
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Cr-Commit-Position: refs/heads/master@{#510776}
[modify] https://crrev.com/6dcb0d096b3a473190af993229ac93ed9bf6e3a7/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ea3f4d679db5d23b0338287ad96787a9f76e970

commit 0ea3f4d679db5d23b0338287ad96787a9f76e970
Author: Robert Phillips <robertphillips@google.com>
Date: Mon Oct 23 15:19:57 2017

Manual Skia roll

Roll src/third_party/skia/ f04ff7696..e4498fd4b (7 commits)

https://skia.googlesource.com/skia.git/+log/f04ff7696d34..e4498fd4bd90

$ git log f04ff7696..e4498fd4b --date=short --no-merges --format='%ad %ae %s'
2017-10-23 angle-deps-roller Roll skia/third_party/externals/angle2/ 6d94f064a..4cd889ec0 (1 commit)
2017-10-22 angle-deps-roller Roll skia/third_party/externals/angle2/ 29ddcc992..6d94f064a (1 commit)
2017-10-22 update-skps Update SKP version
2017-10-22 angle-deps-roller Roll skia/third_party/externals/angle2/ 76e471e90..29ddcc992 (1 commit)
2017-10-21 angle-deps-roller Roll skia/third_party/externals/angle2/ fb9051a58..76e471e90 (1 commit)
2017-10-20 robertphillips Be considerate of GPUs lacking npot support when testing GrSimpleTextureEffect
2017-10-20 robertphillips Make GrRectBlurEffect use bilerp


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=mtklein@chromium.org

Bug:  777375 
Change-Id: I3ad1f3541365e0a56f9c0f9504e9e3c3721846dc
Reviewed-on: https://chromium-review.googlesource.com/732037
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Cr-Commit-Position: refs/heads/master@{#510797}
[modify] https://crrev.com/0ea3f4d679db5d23b0338287ad96787a9f76e970/DEPS
[modify] https://crrev.com/0ea3f4d679db5d23b0338287ad96787a9f76e970/third_party/WebKit/LayoutTests/fast/canvas/canvas-transforms-fillRect-shadow.html

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41d5a1c30234c0f3f6b0575346760b95f1c535bb

commit 41d5a1c30234c0f3f6b0575346760b95f1c535bb
Author: Robert Phillips <robertphillips@google.com>
Date: Wed Oct 25 00:57:54 2017

Remove suppressions for Skia rolls

Bug:  777375 ,  773013 
Change-Id: I3ce61c834c572fd112ad18c96b6e5d08f2b35da5
Reviewed-on: https://chromium-review.googlesource.com/735755
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511322}
[modify] https://crrev.com/41d5a1c30234c0f3f6b0575346760b95f1c535bb/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/41d5a1c30234c0f3f6b0575346760b95f1c535bb/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-shadow-source-in-expected.png
[add] https://crrev.com/41d5a1c30234c0f3f6b0575346760b95f1c535bb/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-expected.png
[add] https://crrev.com/41d5a1c30234c0f3f6b0575346760b95f1c535bb/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/images/color-profile-mask-image-svg-expected.png
[add] https://crrev.com/41d5a1c30234c0f3f6b0575346760b95f1c535bb/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-expected.png
[add] https://crrev.com/41d5a1c30234c0f3f6b0575346760b95f1c535bb/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu-rasterization/images/color-profile-mask-image-svg-expected.png
[modify] https://crrev.com/41d5a1c30234c0f3f6b0575346760b95f1c535bb/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-expected.png
[modify] https://crrev.com/41d5a1c30234c0f3f6b0575346760b95f1c535bb/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-png-expected.png
[modify] https://crrev.com/41d5a1c30234c0f3f6b0575346760b95f1c535bb/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-mask-image-svg-expected.png
[modify] https://crrev.com/41d5a1c30234c0f3f6b0575346760b95f1c535bb/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-shadow-source-in-expected.png
[modify] https://crrev.com/41d5a1c30234c0f3f6b0575346760b95f1c535bb/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-expected.png
[modify] https://crrev.com/41d5a1c30234c0f3f6b0575346760b95f1c535bb/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-png-expected.png
[add] https://crrev.com/41d5a1c30234c0f3f6b0575346760b95f1c535bb/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-mask-image-svg-expected.png
[modify] https://crrev.com/41d5a1c30234c0f3f6b0575346760b95f1c535bb/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-shadow-source-in-expected.png
[delete] https://crrev.com/9bce89359c786654e07c1b5017c8514d1875c206/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/color-profile-mask-image-svg-expected.png

Status: Fixed (was: Untriaged)

Sign in to add a comment