New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 777373 link

Starred by 5 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : No image is seen at User Id after selecting Google profile picture in chrome://settings/changePicture page

Project Member Reported by mmanchala@chromium.org, Oct 23 2017

Issue description

Chrome Version: 64.0.3246.0/10059.0.0 dev-channel Daisy,Candy and Reks
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> Go to chrome://settings/changePicture page
(2)Now click on 'Take photo' option ->Capture Photo -> Now click on 'Discard photo' so that captured picture will get discarded
(3)After discarding picture 'Google profile picture' is selected -> Click back button at 'Change picture'
(4)Observe No image is seen at User Id (Please refer Video and screenshot)

Expected: 'Google profile picture' should be seen at User Id under 'people' section
Actual: Instead No image is seen at User Id

This is Regression Issue as same is working fine in 64.0.3241.0/10041.0.0 dev-channel Reks

@stevenjb : Please confirm the Issue
 
Actual_NoImage.webm
1.2 MB View Download
Actual_NoImage.jpg
105 KB View Download
Expected_ProfilePhoto.webm
942 KB View Download
Expected_ProfilePhoto.jpg
79.3 KB View Download
Cc: sdantul...@chromium.org
Labels: M-63
Summary: Regression : No image is seen at User Id after selecting Google profile picture in chrome://settings/changePicture page (was: Regression : No image is seen at User Id after discarding photo in chrome://settings/changePicture page)
Issue also seen on M63 10032.8.0, 63.0.3239.13. Profile picture is always empty when Google Profile pic is selected.
Cc: steve...@chromium.org
Owner: reve...@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00acc6f68f5a8fd0c1664c33ec499fdce71b18f2

commit 00acc6f68f5a8fd0c1664c33ec499fdce71b18f2
Author: David Reveman <reveman@chromium.org>
Date: Tue Oct 24 02:40:47 2017

Change Picture: Support for PNGs with palette data.

Add support for PLTE chunks to PNG behavior. Profile pictures
may contain palette data and to be able to remove potential
animations from these images, the PNG behavior needs to support
PLTE chunks.

Bug:  777373 
Test: manual
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic118e29b88efd79f46a8c3286bdaf49ab26ff840
Reviewed-on: https://chromium-review.googlesource.com/733618
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511013}
[modify] https://crrev.com/00acc6f68f5a8fd0c1664c33ec499fdce71b18f2/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_png_behavior.js

Labels: Merge-Request-63
Status: Fixed (was: Started)

Comment 6 by gkihumba@google.com, Oct 25 2017

Labels: -Merge-Request-63 Merge-Approved-63
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 25 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b8a9dc6f20fc3da23c9dde56ce48ad3da140e79

commit 6b8a9dc6f20fc3da23c9dde56ce48ad3da140e79
Author: David Reveman <reveman@chromium.org>
Date: Wed Oct 25 15:38:34 2017

Change Picture: Support for PNGs with palette data.

Add support for PLTE chunks to PNG behavior. Profile pictures
may contain palette data and to be able to remove potential
animations from these images, the PNG behavior needs to support
PLTE chunks.

TBR=reveman@chromium.org

(cherry picked from commit 00acc6f68f5a8fd0c1664c33ec499fdce71b18f2)

Bug:  777373 
Test: manual
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic118e29b88efd79f46a8c3286bdaf49ab26ff840
Reviewed-on: https://chromium-review.googlesource.com/733618
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#511013}
Reviewed-on: https://chromium-review.googlesource.com/738351
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#216}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/6b8a9dc6f20fc3da23c9dde56ce48ad3da140e79/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_png_behavior.js

Cc: mkarkada@chromium.org abodenha@chromium.org dhadd...@chromium.org abod...@chromium.org
 Issue 778059  has been merged into this issue.
Status: Assigned (was: Fixed)
Issue is still reproducible on M63 10032.21.0, 63.0.3239.26
1. Open Settings -> People -> Change picture
2. Click on 'Choose a file' and pick any image file
3. Check chrome://settings/people

Result: Profile picture is empty
Status: Fixed (was: Assigned)
There's actually two issues here. One issue has been fixed by the CL above and the other can be tracked in 779042 and was just fixed in ToT.
Status: Verified (was: Fixed)
10032.29.0, 63.0.3239.37

Sign in to add a comment