New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 777372 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Unable to scroll "Google Chrome OS Terms" on using Up and Down arrow buttons

Project Member Reported by mmanchala@chromium.org, Oct 23 2017

Issue description

Chrome Version: 64.0.3246.0/10059.0.0 dev-channel Daisy,Candy and Reks
OS: Chrome

What steps will reproduce the problem?
(1)Recover build -> In OOBE screen click on "Let's go" > In 'Connect to Network' screen Connect to any Wi-Fi network 
(2)Now in EULA screen press 'Tab' button (observe focus traverses from 'System security setting') until focus reaches to 'Uber Tray' 
(3)Press 'Tab' button and now focus moves to "Google Chrome OS Terms" frame ->
 now use Up and Down arrow buttons from keyboard -> observe unable to scroll(Please refer Video) 

Expected: Should be able to scroll "Google Chrome OS Terms" on using Up and Down arrow buttons When focus is on "Google Chrome OS Terms" frame 
Actual: Instead unable to scroll "Google Chrome OS Terms" on using Up and Down arrow buttons

This is Regression Issue as same is working fine in 64.0.3241.0/10041.0.0 dev-channel Reks

@alemate : Please confirm the issue
 
Actual_NoScrolling.mp4
17.6 MB Download
Attaching expected video for reference
Expected_Scrolling.mp4
16.7 MB Download
After you press "Tab" at the status tray, focus is still in the native UI.
You have to press "Tab" one more time to focus EULA.
Cc: alemate@chromium.org xiy...@chromium.org osh...@chromium.org
Owner: warx@chromium.org

Comment 4 by xiy...@chromium.org, Oct 24 2017

Note I just landed a CL (https://chromium-review.googlesource.com/710738) to replace Eula iframe with webview. And maybe affect this. One thing worth trying is to add a tabIndex attribute to the webview tags and see that helps.

Comment 5 by warx@chromium.org, Oct 27 2017

Update: adding tabindex="0" could help. It will focus first on frame, and not able to scroll contents. Another tab will do the scroll. And another tab will move the focus to the next one. The expected behavior seems that it doesn't need a second tab for scrolling contents?
Ping as this has been open for some time as a P1.  Did we confirm the CL impact per #4?  Let's untag as RBS if possible.

Comment 7 by warx@chromium.org, Jan 5 2018

Status: Started (was: Assigned)
Confirmed that CL in #4 brings this bug. We need a work around here. The expected behavior is it shouldn't need a second tab to scroll the contents.

I personally think it is not a urgent bug (it happens when user tabs through system tray and then scrolls terms). It doesn't have to be RBS. Anyhow I would start looking.
Labels: -ReleaseBlock-Stable
Okay, removing RBS.  Thx.
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72ece810c9398440582d98c1162af5779461d30b

commit 72ece810c9398440582d98c1162af5779461d30b
Author: Qiang Xu <warx@chromium.org>
Date: Wed Jan 10 00:07:31 2018

cros: fix crosEulaFrame needs second tab for focus

changes:
Currently, we are able to scroll on terms contents when eula screen is
shown, not on focus returned from ash::SystemTray. This CL adds this
ability.

Bug:  777372 
Test: tested on emulator
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia20617ea43e35fd82cbbd469f08f9eecca3f1b6e
Reviewed-on: https://chromium-review.googlesource.com/853532
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528178}
[modify] https://crrev.com/72ece810c9398440582d98c1162af5779461d30b/chrome/browser/chromeos/login/ui/webui_login_view.cc
[modify] https://crrev.com/72ece810c9398440582d98c1162af5779461d30b/chrome/browser/resources/chromeos/login/login_shared.js
[modify] https://crrev.com/72ece810c9398440582d98c1162af5779461d30b/chrome/browser/resources/chromeos/login/md_login_shared.js
[modify] https://crrev.com/72ece810c9398440582d98c1162af5779461d30b/chrome/browser/resources/chromeos/login/oobe_screen_eula.js

Comment 10 by warx@chromium.org, Jan 10 2018

Labels: Merge-Request-64
Probably this is m64 wanted.
Project Member

Comment 11 by sheriffbot@chromium.org, Jan 10 2018

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: We are only 12 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
#7, #10 aren't very compelling, esp this late in the cycle (and since we agreed that it's not a blocker).  Is there a workaround?  Using the mouse to scroll?

Comment 13 by warx@chromium.org, Jan 16 2018

Cc: r...@chromium.org
Status: Fixed (was: Started)
I am fine we don't merge it. The content is always accessible (the bug just needs one more tab stop). Let me know if fix is desired in m64.
Labels: -M-64 -Merge-Review-64 M-65 Merge-Rejected-64
ok, moving to M65

Sign in to add a comment