New issue
Advanced search Search tips

Issue 777366 link

Starred by 1 user
Status: Fixed
Owner:
brat...@opera.com
Closed: Oct 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

public/web/WebTappedInfo.h exposes internal blink types to external users

Project Member Reported by brat...@opera.com, Oct 23 2017 
public/web/WebTappedInfo.h includes Node.h and IntPoint.h unconditionally. This exposes a lot of blink to non-blink code.

(This caused clashes in jumbo build experiments because both content/* and blink WTF declare STATIC_ASSERT_ENUM macros)
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c87ffbf2d5762673b8d9e7a008c449357c39fcc4

commit c87ffbf2d5762673b8d9e7a008c449357c39fcc4
Author: Daniel Bratell <bratell@opera.com>
Date: Mon Oct 23 13:24:25 2017

Hide Blink internal types from users of WebTappedInfo.h

A few internal types were accidentally exposed to the world.

Bug:  777366 
Change-Id: I293070e479e88d76926c8c463a3bec4f04475a6f
Reviewed-on: https://chromium-review.googlesource.com/733082
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#510777}
[modify] https://crrev.com/c87ffbf2d5762673b8d9e7a008c449357c39fcc4/third_party/WebKit/Source/core/exported/WebTappedInfo.cpp
[modify] https://crrev.com/c87ffbf2d5762673b8d9e7a008c449357c39fcc4/third_party/WebKit/public/web/WebTappedInfo.h

Comment 2 by brat...@opera.com, Oct 23 2017

Status: Fixed (was: Started)
►

Sign in to add a comment