New issue
Advanced search Search tips

Issue 777356 link

Starred by 1 user
Status: Assigned
Owner:
achuith@chromium.org
Cc:
hendrich@chromium.org
emaxx@chromium.org
pmarko@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

private auth apis for smart card login

Project Member Reported by achuith@chromium.org, Oct 23 2017 
Design document
http://go/extended-login-smart-cards

The following 2 api calls are definitely needed:

chrome.authPrivate.setUserForSignin = function(object details, function callback)
where
	(optional) details: An object with the following keys:
		ArrayBuffer		certificate		The DER encoding of an X.509 certificate.
		This parameter should be omitted when no user is currently available for sign-in.
	callback: function(), which will be called back by Chrome. If there is an error, it will be reported
		through the chrome.runtime.lastError variable.


chrome.authPrivate.getLoginStatus(function callback)
	where:
		callback: function(object details)
		details: An object with the following properties:
			boolean	isLoggedIn
			boolean	isScreenLocked
	chrome.authPrivate.onLoginStatusChanged.addListener(function callback)
	where:
		callback: function()
	chrome.authPrivate.onLoginStatusChanged.removeListener(function callback)
	chrome.authPrivate.isUnderSigninProfile(function callback)
	where:
		callback: function(boolean underSigninProfile)
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1201996ddf2d60fe6a5401b3e8bc9d84d946084

commit e1201996ddf2d60fe6a5401b3e8bc9d84d946084
Author: Achuith Bhandarkar <achuith@chromium.org>
Date: Wed Jul 18 22:36:44 2018

Introduce usersPrivate.getLoginStatus

This method is intended to be used by the smart-card extension to monitor login
status.

* cros-specific usersPrivate.getLoginStatus returns a dictionary with
data members isLoggedIn and isScreenLocked.
* tests for logged-in user, and screenlock cases.

Bug: 777356
Test: browser_tests --gtest_filter=UsersPrivateApiLo\*
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ib0ba29d3c715fb0ce162ba234ca9be657d40582c
Reviewed-on: https://chromium-review.googlesource.com/1094203
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576235}
[modify] https://crrev.com/e1201996ddf2d60fe6a5401b3e8bc9d84d946084/chrome/browser/chromeos/extensions/users_private/OWNERS
[modify] https://crrev.com/e1201996ddf2d60fe6a5401b3e8bc9d84d946084/chrome/browser/chromeos/extensions/users_private/users_private_api.cc
[modify] https://crrev.com/e1201996ddf2d60fe6a5401b3e8bc9d84d946084/chrome/browser/chromeos/extensions/users_private/users_private_api.h
[modify] https://crrev.com/e1201996ddf2d60fe6a5401b3e8bc9d84d946084/chrome/browser/chromeos/extensions/users_private/users_private_apitest.cc
[modify] https://crrev.com/e1201996ddf2d60fe6a5401b3e8bc9d84d946084/chrome/common/extensions/api/_api_features.json
[modify] https://crrev.com/e1201996ddf2d60fe6a5401b3e8bc9d84d946084/chrome/common/extensions/api/_permission_features.json
[modify] https://crrev.com/e1201996ddf2d60fe6a5401b3e8bc9d84d946084/chrome/common/extensions/api/users_private.idl
[modify] https://crrev.com/e1201996ddf2d60fe6a5401b3e8bc9d84d946084/chrome/test/data/extensions/api_test/users_private/test.js
[modify] https://crrev.com/e1201996ddf2d60fe6a5401b3e8bc9d84d946084/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/e1201996ddf2d60fe6a5401b3e8bc9d84d946084/extensions/common/api/test.json
[modify] https://crrev.com/e1201996ddf2d60fe6a5401b3e8bc9d84d946084/third_party/closure_compiler/externs/users_private.js
[modify] https://crrev.com/e1201996ddf2d60fe6a5401b3e8bc9d84d946084/tools/metrics/histograms/enums.xml
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/838df240efe9c4fdb5a286b528c64b1403727c30

commit 838df240efe9c4fdb5a286b528c64b1403727c30
Author: Achuith Bhandarkar <achuith@chromium.org>
Date: Thu Jul 26 16:19:18 2018

users_private_apitest cleanup.

Don't need OS_CHROMEOS since this is only built on chromeos.

Bug: 777356
Test: this is the test.
Change-Id: I3088890e2ff8e5d11da1a487517c68c8e1eec720
Reviewed-on: https://chromium-review.googlesource.com/1144438
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578325}
[modify] https://crrev.com/838df240efe9c4fdb5a286b528c64b1403727c30/chrome/browser/chromeos/extensions/users_private/users_private_apitest.cc

Comment 3 by zalcorn@chromium.org, Nov 21

Components: Enterprise
Labels: -Pri-1 Pri-3
<triage> Moving to P3 due to lack of target milestone and activity, please update if this is a priority. </triage>

Comment 4 by hendrich@chromium.org, Dec 6

Cc: hendrich@chromium.org
►

Sign in to add a comment