Non-Regression: Same tool tips are observed in both Camera /video mode of changePicture overlay |
||||||||||||||
Issue descriptionChrome Version:64.0.3246.0/10059.0.0 dev-channel Daisy,Candy,Reks OS:Chrome OS What steps will reproduce the problem? (1)Sign into user ->Launch chrome,open chrome://settings/changePicture (2)click to Take video & Discard it in video mode and Observe the tool tips Actual: In video mode, Take photo/Discard photo tool tips are seen(Refer attachments 1,2,5) Expected :Instead,they could be as Take video/Record video and Discard video Similarly.. Actual:'Switch camera mode' tool tip is seen for both Camera/video modes. Expected:Instead, it can be as 'Switch to video mode'for video(Refer attachments 3,4) This is a Non-Regression as it is seen from 63.0.3230.0/9997.0.0 dev channel Daisy Note:Issue is not seen in Linux,Windows OS @stevenjb: Please confirm the issue
,
Oct 23 2017
This is currently WAI. Elizabeth, let me know what strings are preferred and I'll update the UI.
,
Nov 14 2017
Camera: Switch to camera mode. Video: Switch to video recorder.
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d26c4db292d4f734aa007a2879de3004264c3b9f commit d26c4db292d4f734aa007a2879de3004264c3b9f Author: David Reveman <reveman@chromium.org> Date: Wed Nov 15 22:20:03 2017 Change Picture: Update camera mode switch labels. Camera: Switch to camera mode. Video: Switch to video recorder. Bug: 777354 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie7b911c0eb0e3c3a329b80be24056598779a294e Reviewed-on: https://chromium-review.googlesource.com/770147 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#516855} [modify] https://crrev.com/d26c4db292d4f734aa007a2879de3004264c3b9f/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/d26c4db292d4f734aa007a2879de3004264c3b9f/chrome/app/settings_strings.grdp [modify] https://crrev.com/d26c4db292d4f734aa007a2879de3004264c3b9f/chrome/browser/resources/chromeos/login/oobe_change_picture.html [modify] https://crrev.com/d26c4db292d4f734aa007a2879de3004264c3b9f/chrome/browser/resources/settings/people_page/change_picture.html [modify] https://crrev.com/d26c4db292d4f734aa007a2879de3004264c3b9f/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc [modify] https://crrev.com/d26c4db292d4f734aa007a2879de3004264c3b9f/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/d26c4db292d4f734aa007a2879de3004264c3b9f/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_camera.html [modify] https://crrev.com/d26c4db292d4f734aa007a2879de3004264c3b9f/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_camera.js [modify] https://crrev.com/d26c4db292d4f734aa007a2879de3004264c3b9f/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.js [modify] https://crrev.com/d26c4db292d4f734aa007a2879de3004264c3b9f/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_pane.html [modify] https://crrev.com/d26c4db292d4f734aa007a2879de3004264c3b9f/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_pane.js
,
Nov 15 2017
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by steve...@chromium.org
, Oct 23 2017Labels: -Pri-2 Pri-3
Owner: reve...@chromium.org