New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 777328 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1% regression in v8.browsing_desktop at 509918:509997

Project Member Reported by petermarshall@chromium.org, Oct 23 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Oct 23 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=777328

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=afa9349bd30e42da3fd74306bba9a1c9721602cb629a3066de2d4e279b412670


Bot(s) for this bug's original alert(s):

chromium-rel-mac-retina
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Oct 23 2017

Cc: napper@chromium.org
Owner: napper@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author napper@chromium.org ===

Hi napper@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Jon Napper
  Commit : be3a712c6c8f56b9195f36c642c04d2c6f94f97d
  Date   : Wed Oct 18 23:24:02 2017
  Subject: Revert "Added missing well-known conflicting language codes"

Bisect Details
  Configuration: mac_retina_perf_bisect
  Benchmark    : v8.browsing_desktop
  Metric       : memory:chrome:renderer_processes:reported_by_chrome:v8:heap:allocated_objects_size_avg/browse_search/browse_search_google_india
  Change       : 0.84% | 10819796.3175 -> 10910393.6497

Revision             Result                   N
chromium@509917      10819796 +- 123822       9      good
chromium@509920      10795965 +- 132357       9      good
chromium@509921      10940197 +- 80057.7      6      bad       <--
chromium@509922      10916854 +- 272350       9      bad
chromium@509927      10931485 +- 37964.2      6      bad
chromium@509937      10937258 +- 11730.8      6      bad
chromium@509957      10967275 +- 145027       6      bad
chromium@509997      10910394 +- 216268       9      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.search.google.india v8.browsing_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8964954922265959744


For feedback, file a bug with component Speed>Bisection

Comment 4 by napper@chromium.org, Oct 23 2017

The original CL (https://chromium-review.googlesource.com/c/chromium/src/+/720578) was reverted due to a reported regression (https://bugs.chromium.org/p/chromium/issues/detail?id=775828). This CL is the revert (https://chromium-review.googlesource.com/c/chromium/src/+/726680).

I think this revert is being incorrectly detected as causing a regression.
Status: WontFix (was: Assigned)

Sign in to add a comment