factory: Goofy: TestGroup might be not marked pass after all the sub tests passed. |
|||||
Issue descriptionVersion: 5cc66a421d215672fce8aec1f5cd975024d875fd What steps will reproduce the problem? (1) Run a TestGroup and make all its sub tests pass. (Maybe need some skipped test item inside) What is the expected result? The TestGroup itself should be marked as pass. What happens instead? The color of the TestGroup itself is still white(blank).
,
Oct 24 2017
Minimum reproduce example:
{
"inherit": ["base.test_list"],
"label": "Test",
"options": {
"phase": "EVT",
"skipped_tests": {
"EVT": ["TestGroup.Display"]
}
},
"tests": [
{
"inherit": "TestGroup",
"subtests": [
{
"pytest_name": "display"
}
]
}
]
}
The subtest is skipped, but the TestGroup is not marked as skipped.
,
Oct 24 2017
,
Oct 24 2017
,
Oct 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/8477acf43931d51e0c933f256b143428b65cfc09 commit 8477acf43931d51e0c933f256b143428b65cfc09 Author: Wei-Han Chen <stimim@google.com> Date: Tue Oct 24 14:29:42 2017 test list: update status from children before leaving a group BUG= chromium:777327 TEST=make test, manual test Change-Id: Iadbdf86f9b8227a74cf5910f2bf7688bcef9dc4f Reviewed-on: https://chromium-review.googlesource.com/735301 Commit-Ready: Youcheng Syu <youcheng@chromium.org> Tested-by: Youcheng Syu <youcheng@chromium.org> Reviewed-by: Wei-Han Chen <stimim@chromium.org> [modify] https://crrev.com/8477acf43931d51e0c933f256b143428b65cfc09/py/goofy/test_list_iterator_unittest.py [modify] https://crrev.com/8477acf43931d51e0c933f256b143428b65cfc09/py/goofy/test_list_iterator.py
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/2134a2b31e48544a00ecd430906634533ff1c526 commit 2134a2b31e48544a00ecd430906634533ff1c526 Author: Wei-Han Chen <stimim@google.com> Date: Wed Oct 25 08:26:01 2017 test list: update status from children before leaving a group BUG= chromium:777327 TEST=make test, manual test Change-Id: Iadbdf86f9b8227a74cf5910f2bf7688bcef9dc4f Reviewed-on: https://chromium-review.googlesource.com/737890 Reviewed-by: Wei-Han Chen <stimim@chromium.org> Commit-Queue: Wei-Han Chen <stimim@chromium.org> Tested-by: Wei-Han Chen <stimim@chromium.org> [modify] https://crrev.com/2134a2b31e48544a00ecd430906634533ff1c526/py/goofy/test_list_iterator_unittest.py [modify] https://crrev.com/2134a2b31e48544a00ecd430906634533ff1c526/py/goofy/test_list_iterator.py
,
Nov 15 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by youcheng@chromium.org
, Oct 23 2017Status: Assigned (was: Untriaged)