Regression: Browser gets crashed after navigating to chrome://interventions-internals in 'Guest' mode.
Reported by
db...@etouch.net,
Oct 23 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version: 64.0.3247.0 f82a02e15b3f72736818cbc449df901b90622ecd-refs/heads/master@{#510691}(32/64 bit) OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6) What steps will reproduce the problem? (1) Launch chrome switch to Guest mode and navigate to chrome://interventions-internals/ (2) Observe Actual: Browser gets crashed Crash Id: Uploaded Crash Report ID be4e07f815206c6f (Local Crash ID: 59506d24-7195-4d8e-bf35-6d6696af7f1f) Expected: Browser should not crash. This is a regression issue, broken in 'M63', will soon update the other info: Good Build: 63.0.3236.0 Bad Build: 63.0.3238.0
,
Oct 23 2017
,
Oct 23 2017
You are probably looking for a change made after 508089 (known good), but no later than 508090 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/bbe776a20641c354b23e9d79c14c7a2392ec86e1..c52018d4a712ff7f74d920f2c5271947c4e80d22 Suspecting: https://chromium.googlesource.com/chromium/src/+/c52018d4a712ff7f74d920f2c5271947c4e80d22
,
Oct 23 2017
Tagging with blocker label, please undo if not the case.
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c489f2c7dca913aa85f6cd3a8d23419086c8df59 commit c489f2c7dca913aa85f6cd3a8d23419086c8df59 Author: Thanh Le <thanhdle@chromium.org> Date: Wed Oct 25 05:00:31 2017 Fix crash in 'Guest mode' when navigate to chrome://interventions-internals. Check for PreviewsService before initialize sources, display error message saying that the page is not supported in 'Guest Mode'. Screenshot: https://drive.google.com/open?id=0B_MBksOU85S3ZVRZWGNJd2ZJVnc Bug: 777323 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5c4a6dc40381d600d4d017d58e9fb85516df8f9c Reviewed-on: https://chromium-review.googlesource.com/733853 Commit-Queue: Thanh Le <thanhdle@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Tim Sergeant <tsergeant@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#511375} [modify] https://crrev.com/c489f2c7dca913aa85f6cd3a8d23419086c8df59/chrome/browser/browser_resources.grd [modify] https://crrev.com/c489f2c7dca913aa85f6cd3a8d23419086c8df59/chrome/browser/resources/interventions_internals/index.css [add] https://crrev.com/c489f2c7dca913aa85f6cd3a8d23419086c8df59/chrome/browser/resources/interventions_internals/unsupported_page.html [modify] https://crrev.com/c489f2c7dca913aa85f6cd3a8d23419086c8df59/chrome/browser/ui/webui/interventions_internals/interventions_internals_ui.cc
,
Oct 25 2017
,
Oct 25 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-63; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-63 label, otherwise remove Merge-TBD label. Thanks.
,
Oct 25 2017
Requesting merge for 63, since this can crash there.
,
Oct 25 2017
,
Oct 26 2017
,
Oct 26 2017
This bug requires manual review: There is .grd file changes and we are only 39 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 26 2017
Just to update: Above issue is fixed on Latest canary build 64.0.3250.0
,
Oct 26 2017
Approving merge to M63 branch 3239 as this is M63 regression and marked as "RBS". Please merge to M63 branch ASAP as it includes .grd file change and we need to submit string for translation.
,
Oct 26 2017
Will merge today. Thanks you.
,
Oct 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01fc89481452edc1577da79f7df4901f575c6179 commit 01fc89481452edc1577da79f7df4901f575c6179 Author: Thanh Le <thanhdle@chromium.org> Date: Thu Oct 26 20:08:21 2017 Fix crash in 'Guest mode' when navigate to chrome://interventions-internals. Check for PreviewsService before initialize sources, display error message saying that the page is not supported in 'Guest Mode'. Screenshot: https://drive.google.com/open?id=0B_MBksOU85S3ZVRZWGNJd2ZJVnc Bug: 777323 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5c4a6dc40381d600d4d017d58e9fb85516df8f9c Reviewed-on: https://chromium-review.googlesource.com/733853 Commit-Queue: Thanh Le <thanhdle@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Tim Sergeant <tsergeant@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#511375}(cherry picked from commit c489f2c7dca913aa85f6cd3a8d23419086c8df59) Reviewed-on: https://chromium-review.googlesource.com/739763 Cr-Commit-Position: refs/branch-heads/3239@{#248} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/01fc89481452edc1577da79f7df4901f575c6179/chrome/browser/browser_resources.grd [modify] https://crrev.com/01fc89481452edc1577da79f7df4901f575c6179/chrome/browser/resources/interventions_internals/index.css [add] https://crrev.com/01fc89481452edc1577da79f7df4901f575c6179/chrome/browser/resources/interventions_internals/unsupported_page.html [modify] https://crrev.com/01fc89481452edc1577da79f7df4901f575c6179/chrome/browser/ui/webui/interventions_internals/interventions_internals_ui.cc
,
Oct 26 2017
,
Nov 1 2017
Just to update: Retested above issue on Windows(7,8,10), Mac(10.12.6) & Linux (14.04 LTS) OS using Beta #63.0.3239.30 build and issue is fixed. Kindly review an attached video.
|
||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||
Comment 1 by ranjitkan@chromium.org
, Oct 23 2017