New issue
Advanced search Search tips

Issue 777309 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

4.3%-5.6% regression in v8.runtimestats.browsing_mobile at 510357:510386

Project Member Reported by tebbi@chromium.org, Oct 23 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Oct 23 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=777309

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=2d8d35cbdb91d2764c843014988a2cd3c0a0131b5bf28dd30df3d676cc4904c2


Bot(s) for this bug's original alert(s):

android-webview-nexus6
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Oct 23 2017

Cc: alph@chromium.org
Owner: alph@chromium.org

=== Auto-CCing suspected CL author alph@chromium.org ===

Hi alph@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Alexei Filippov
  Commit : d0cf729782cf311d39d3b8934ef150ccf3ef9127
  Date   : Thu Oct 19 18:21:02 2017
  Subject: [runtime-call-stats] Temporarily change DCHECK to CHECK in RCS::Enter and LEAVE

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : v8.runtimestats.browsing_mobile
  Metric       : JavaScript:duration_avg/browse_shopping/browse_shopping_lazada
  Change       : 5.00% | 2018.65766667 -> 2119.57233333

Revision                           Result                  N
chromium@510356                    2018.66 +- 51.9341      6      good
chromium@510371                    2042.07 +- 41.2054      6      good
chromium@510379                    2040.32 +- 51.8312      6      good
chromium@510381                    2048.17 +- 32.0647      6      good
chromium@510382                    2047.91 +- 38.7068      6      good
chromium@510382,v8@0454a842d1      2013.25 +- 17.813       6      good
chromium@510382,v8@9b51519e52      2004.82 +- 46.4864      6      good
chromium@510382,v8@f65251be3c      2029.69 +- 44.3498      6      good
chromium@510382,v8@d0cf729782      2155.4 +- 22.2242       6      bad       <--
chromium@510383                    2133.96 +- 18.9172      6      bad
chromium@510386                    2119.57 +- 16.9         6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.shopping.lazada v8.runtimestats.browsing_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8964956573385447168


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Oct 23 2017

 Issue 777307  has been merged into this issue.

Comment 5 by alph@chromium.org, Oct 23 2017

That is expected. We are going to revert the patch in a week.
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Oct 26 2017

Cc: verwaest@google.com
 Issue 778664  has been merged into this issue.

Comment 7 by alph@chromium.org, Nov 15 2017

Status: Fixed (was: Assigned)
The change had been reverted https://chromium.googlesource.com/v8/v8/+/4a26804cf06833108d048800233a4899f2d04f96

Sign in to add a comment