extension browsertests failing in official win builds |
|||||
Issue descriptionIt started here: https://build.chromium.org/p/chromium.clang/builders/CrWinClang%20tester/builds/204 Since this happens on the pin clanned bots and there was on roll nearby, I assume this is due to a Chromium change. Example failure: [ RUN ] ExtensionViewTests/ExtensionViewTest.ShimSrcAttribute/1 [6032:3200:1020/203726.114:WARNING:chrome_browser_main_win.cc(612)] Command line too long for RegisterApplicationRestart: --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=ExtensionViewTests/ExtensionViewTest.ShimSrcAttribute/1 --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir6280_15902\results6280_27508\test_results.xml" --test-launcher-summary-output="e:\b\s\w\ioekncwl\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir6280_15902\d6280_23598" --disable-offline-auto-reload --no-first-run --no-default-browser-check --enable-logging=stderr --safebrowsing-disable-auto-update --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --enable-features=GuestViewCrossProcessFrames --disable-features=NetworkPrediction --flag-switches-begin --flag-switches-end --restore-last-session about:blank ../../chrome/browser/extensions/extension_browsertest.cc(513): error: Expected: num_before + expected_change Which is: 4 To be equal to: num_after Which is: 3 ../../chrome/browser/apps/app_browsertest_util.cc(126): error: Value of: extension Actual: false Expected: true Received fatal exception EXCEPTION_ACCESS_VIOLATION Backtrace: extensions::Extension::id [0x03A91744+0] content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x0297110F+239] ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x0303556C+3514] ChromeBrowserMainParts::PreMainMessageLoopRun [0x030346F6+150] content::BrowserMainLoop::PreMainMessageLoopRun [0x01BA56E2+66] content::StartupTaskRunner::RunAllTasksNow [0x01E05D8E+34] content::BrowserMainLoop::CreateStartupTasks [0x01BA4293+487] content::BrowserMainRunnerImpl::Initialize [0x01BA7D0B+507] content::BrowserMain [0x01BA2C51+97] content::RunNamedProcessTypeMain [0x0282548F+123] content::ContentMainRunnerImpl::Run [0x028258B2+146] service_manager::Main [0x03893B64+620] content::ContentMain [0x028253BD+49] content::BrowserTestBase::SetUp [0x02970F5B+1227] InProcessBrowserTest::SetUp [0x028E3F37+279] testing::Test::Run [0x016C4E53+113] testing::TestInfo::Run [0x016C5545+213] testing::TestCase::Run [0x016C58F2+246] testing::internal::UnitTestImpl::RunAllTests [0x016C96EE+606] testing::UnitTest::Run [0x016C93B4+178] base::TestSuite::Run [0x028FA368+100] ChromeTestSuiteRunner::RunTestSuite [0x0513B3AB+75] content::LaunchTests [0x02966B8B+299] LaunchChromeTests [0x0513B6D3+143] main [0x0513B324+112] __scrt_common_main_seh [0x05B9CC8A+248] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283) BaseThreadInitThunk [0x75B1336A+18] RtlInitializeExceptionChain [0x77DE9902+99] RtlInitializeExceptionChain [0x77DE98D5+54]
,
Oct 23 2017
Reverting https://chromium-review.googlesource.com/729239 makes the test pass. I'll prepare a revert.
,
Oct 23 2017
,
Oct 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c8e102e00db2cbe0d3189e71bd5d450d93eaf55 commit 4c8e102e00db2cbe0d3189e71bd5d450d93eaf55 Author: Hans Wennborg <hans@chromium.org> Date: Mon Oct 23 10:25:52 2017 Revert "Install verifier: Remove migration logic from IsFromStore" This reverts commit 63405aa4ef5bd5f0191e73c9d4c21711487b8215. Reason for revert: It broke browser_tests in chrome-branded builds (see bug). Original change's description: > Install verifier: Remove migration logic from IsFromStore > > Bug: 775860 > Change-Id: I57198b52cc013bc2a9cb9544894451b297b4e49b > Reviewed-on: https://chromium-review.googlesource.com/729239 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Commit-Queue: proberge <proberge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#510644} TBR=rdevlin.cronin@chromium.org,proberge@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 775860 , 777297 Change-Id: Icf1ee4c5c6fea2a09456375f69e64ba9274bae6c Reviewed-on: https://chromium-review.googlesource.com/732937 Reviewed-by: Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#510754} [modify] https://crrev.com/4c8e102e00db2cbe0d3189e71bd5d450d93eaf55/chrome/browser/extensions/install_verifier.cc
,
Oct 23 2017
,
Oct 23 2017
Thanks for reverting the CL. The fieldtrial_testing_config for the InstallVerifier feature misleadingly claims that the feature is tested as enabled on Chromium Windows and MacOS bots. In fact, some logic is within an #if GOOGLE_CHROME block. To avoid running into this issue again, I will reconcile the test behavior between Chromium and Chrome bots.
,
Oct 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4226f65a65c94c6cd304b5009d7eba3cd81c1535 commit 4226f65a65c94c6cd304b5009d7eba3cd81c1535 Author: proberge <proberge@chromium.org> Date: Tue Oct 24 18:01:43 2017 InstallVerifier: enable testing on Chromium trybots The ExtensionInstallVerification entry in fieldtrial_testing_config.json claims that the experiment is enabled on mac and win. This is a red herring: the InstallVerifier's GetExperimentStatus logic is surrounded by a #if defined(GOOGLE_CHROME_BUILD) block. Despite the fieldtrial testing config, Install Verification is always disabled on Chromium trybots. This change should unify the behavior tested by the Chromium and Chrome bots. Bug: 777297 Change-Id: Ia4376f678508568feaab338a10f4ad2a4206e39a Reviewed-on: https://chromium-review.googlesource.com/733504 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#511209} [modify] https://crrev.com/4226f65a65c94c6cd304b5009d7eba3cd81c1535/chrome/browser/extensions/install_verifier.cc
,
Oct 30 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by h...@chromium.org
, Oct 23 2017