Regression: Flickering of CC menu is observed after playing video
Reported by
nutan.ga...@etouch.net,
Oct 23 2017
|
||||||||||
Issue descriptionChrome Version: 64.0.3247.0 f82a02e15b3f72736818cbc449df901b90622ecd-refs/heads/master@{#510691} OS: Win(7,8,10), Mac(10.12.6) and Linux(14.04 LTS). Steps to reproduce: 1. Launch chrome, navigate to https://mounirlamouri.github.io/sandbox/media/dynamic-controls.html 2. Click on Play icon then click on CC (closed captions)icon and observe menu Actual: Flickering of CC menu is observed after playing video Expected: CC menu should be seen properly This is regression issue broken in ‘M-63’, will soon provide bisect info: Good Build: 63.0.3226.0 Bad Build: 63.0.3227.0
,
Oct 23 2017
The menu is positioned wrongly in the expected video too so I don't think the range is valid here. @mlamouri - could this have something to do with your menu positioning change?
,
Oct 23 2017
The flickering is definitely something that was introduced with your CL, though, as you pointed, the position is off so if I can find the flickering source at the same time, I will fix both.
,
Oct 23 2017
,
Oct 24 2017
,
Oct 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db17c3ccab2dbe2ce85e2317c26f7104570ec28e commit db17c3ccab2dbe2ce85e2317c26f7104570ec28e Author: Mounir Lamouri <mlamouri@chromium.org> Date: Tue Oct 24 15:25:42 2017 Media Controls: add "px" to media controls popup menu rule to position. Otherwise, depending on the element for which the popup menu is created, the position might be off. Bug: 777278 Change-Id: I2e5ffbc08ffa88997a42a3ee09d0dec65798c097 Reviewed-on: https://chromium-review.googlesource.com/735611 Reviewed-by: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#511155} [modify] https://crrev.com/db17c3ccab2dbe2ce85e2317c26f7104570ec28e/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
,
Oct 24 2017
,
Oct 25 2017
Rechecked this issue on Windows 10 64.0.3249.2 Canary and 64.0.3249.0 Canary for Mac 10.12.6 & Ubuntu 14.04, fix is working as intended. No Flickering of CC menu is observed after playing video Adding TE-Verified labels for M64
,
Oct 25 2017
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 25 2017
Please merge your change to M63 branch 3239 by 4:00 PM PT, tomorrow (Wednesday). Thank you.
,
Oct 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb819a8cf0df220a3e9a4405e23a7fc5afe358ac commit fb819a8cf0df220a3e9a4405e23a7fc5afe358ac Author: Mounir Lamouri <mlamouri@chromium.org> Date: Thu Oct 26 10:15:39 2017 Media Controls: add "px" to media controls popup menu rule to position. Otherwise, depending on the element for which the popup menu is created, the position might be off. TBR=mlamouri@chromium.org (cherry picked from commit db17c3ccab2dbe2ce85e2317c26f7104570ec28e) Bug: 777278 Change-Id: I2e5ffbc08ffa88997a42a3ee09d0dec65798c097 Reviewed-on: https://chromium-review.googlesource.com/735611 Reviewed-by: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#511155} Reviewed-on: https://chromium-review.googlesource.com/737998 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#236} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/fb819a8cf0df220a3e9a4405e23a7fc5afe358ac/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
,
Oct 26 2017
,
Nov 1 2017
Retested above issue on Windows(7,8,10), Mac(10.12.6) & Linux (14.04 LTS) OS using Beta #63.0.3239.30 build and issue is fixed. Kindly review an attached video. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by nutan.ga...@etouch.net
, Oct 23 2017Owner: beccahughes@chromium.org
Status: Assigned (was: Unconfirmed)