fast/reflections/reflection-masks-outset.html flaky on WebKit Win7 |
|||||||
Issue descriptionMaybe related to Issue 713891 Regular failures in https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7?numbuilds=200 example: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/56811 The poor kid's head is getting chopped off https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win7/56811/layout-test-results/results.html Failures go back to https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/56698 There's an ANGLE roll, but my main suspect is r509902 -> [Re-Land] Use GPU Discardable in Image Decode Cache -> https://chromium-review.googlesource.com/706593
,
Oct 23 2017
This also flakes on Win10
,
Oct 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38f6240f4e4fa5eb0f123b3c77bde5ec5e6a588a commit 38f6240f4e4fa5eb0f123b3c77bde5ec5e6a588a Author: Dominic Battre <battre@chromium.org> Date: Mon Oct 23 12:08:54 2017 Mark fast/reflections/reflection-masks-outset.html as failing on more platforms TBR=ericrk@chromium.org Bug: 777259 Change-Id: I682c832a105c68d7b93b401481bc29b834945662 Reviewed-on: https://chromium-review.googlesource.com/732982 Reviewed-by: Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#510770} [modify] https://crrev.com/38f6240f4e4fa5eb0f123b3c77bde5ec5e6a588a/third_party/WebKit/LayoutTests/TestExpectations
,
Oct 27 2017
Manually bisected this. I think it's been going on a bit longer than originally expected. I was able to repro on my mac and got the following revision range: https://chromium.googlesource.com/chromium/src/+log/943bceea4a2c0ba976f06d4c29e3b974aa28767f..f700327e57a6f7d06404f57d7f4c54c636a40e7d Suspecting https://chromium-review.googlesource.com/c/chromium/src/+/667756 as it has to do with filters. wangxianzhu@, can you take a look? Thanks!
,
Oct 30 2017
It seems more flaky on faster bots: it's more stable on debug and CQ bots with DCHECK, but more flaky on waterfall bots without DCHECK. This seems caused by lack of change observation for reflection mask images.
,
Oct 30 2017
The latter half of #5 is incorrect. We do have reflection mask image change observation in LayoutBox::ImageChanged(). The flakiness might be because test might finish earlier than the final mask image change.
,
Oct 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a536ab7a942696e6c6253c2c0686084fdcb90d96 commit a536ab7a942696e6c6253c2c0686084fdcb90d96 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Tue Oct 31 18:01:00 2017 Try to deflake fast/reflections/reflection-masks-outset.html Ensure the reflection mask image is loaded before ending the test. Will update TestExpectations later if the test will no longer be flaky. Bug: 777259 Change-Id: I2ed912f650c80a12ac51308799173a54ffe35314 Reviewed-on: https://chromium-review.googlesource.com/744288 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#512872} [modify] https://crrev.com/a536ab7a942696e6c6253c2c0686084fdcb90d96/third_party/WebKit/LayoutTests/fast/reflections/reflection-masks-outset-expected.txt [modify] https://crrev.com/a536ab7a942696e6c6253c2c0686084fdcb90d96/third_party/WebKit/LayoutTests/fast/reflections/reflection-masks-outset.html
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa3ba22051a7837faaa47b6e6de03414492738dd commit aa3ba22051a7837faaa47b6e6de03414492738dd Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Thu Nov 16 21:08:19 2017 Rebaseline text expectation of fast/reflections/reflection-masks-outset.html The test seems still flaky, but the incorrect text expectation shadowed the image flakiness. Rebaseline the text expectations to expose the real image flakiness. Bug: 777259 Change-Id: I176c37017288122becd018aa154f44465b5e574c Reviewed-on: https://chromium-review.googlesource.com/774501 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#517192} [add] https://crrev.com/aa3ba22051a7837faaa47b6e6de03414492738dd/third_party/WebKit/LayoutTests/platform/mac/fast/reflections/reflection-masks-outset-expected.txt
,
Dec 4 2017
With a modified test, I can always reproduce the failure:
<!DOCTYPE html>
<img id="target"
style="margin:20px; outline:20px solid green;
-webkit-box-reflect: below 2px url(resources/vignette-mask.png) 75 / auto / 25px stretch">
<script src="../../resources/run-after-layout-and-paint.js"></script>
<script>
runAfterLayoutAndPaint(function() {
target.src = 'resources/kate.png';
}, true);
It seems that the reflection is not correctly updated when the image object changes.
,
Dec 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/46367c60003ed45d9fc3f2f448ca9482f8b89ffd commit 46367c60003ed45d9fc3f2f448ca9482f8b89ffd Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Wed Dec 06 20:31:47 2017 [PE] Update reference filters on box resize Bug: 777259 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id10b46d54508fc3332c2a20336deaa0f74027554 Reviewed-on: https://chromium-review.googlesource.com/806441 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#522178} [modify] https://crrev.com/46367c60003ed45d9fc3f2f448ca9482f8b89ffd/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/46367c60003ed45d9fc3f2f448ca9482f8b89ffd/third_party/WebKit/LayoutTests/fast/reflections/reflection-masks-outset-expected.png [modify] https://crrev.com/46367c60003ed45d9fc3f2f448ca9482f8b89ffd/third_party/WebKit/LayoutTests/fast/reflections/reflection-masks-outset-expected.txt [modify] https://crrev.com/46367c60003ed45d9fc3f2f448ca9482f8b89ffd/third_party/WebKit/LayoutTests/fast/reflections/reflection-masks-outset.html [add] https://crrev.com/46367c60003ed45d9fc3f2f448ca9482f8b89ffd/third_party/WebKit/LayoutTests/paint/invalidation/reflection/reflection-resize-expected.html [add] https://crrev.com/46367c60003ed45d9fc3f2f448ca9482f8b89ffd/third_party/WebKit/LayoutTests/paint/invalidation/reflection/reflection-resize.html [add] https://crrev.com/46367c60003ed45d9fc3f2f448ca9482f8b89ffd/third_party/WebKit/LayoutTests/platform/android/fast/reflections/reflection-masks-outset-expected.png [add] https://crrev.com/46367c60003ed45d9fc3f2f448ca9482f8b89ffd/third_party/WebKit/LayoutTests/platform/android/fast/reflections/reflection-masks-outset-expected.txt [delete] https://crrev.com/5268b0836c941ed7718082caafeea4d02c745c4a/third_party/WebKit/LayoutTests/platform/mac/fast/reflections/reflection-masks-outset-expected.txt [delete] https://crrev.com/5268b0836c941ed7718082caafeea4d02c745c4a/third_party/WebKit/LayoutTests/platform/win7/fast/reflections/reflection-masks-expected.png [modify] https://crrev.com/46367c60003ed45d9fc3f2f448ca9482f8b89ffd/third_party/WebKit/Source/core/paint/PaintLayer.cpp [modify] https://crrev.com/46367c60003ed45d9fc3f2f448ca9482f8b89ffd/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp [modify] https://crrev.com/46367c60003ed45d9fc3f2f448ca9482f8b89ffd/third_party/WebKit/Source/core/style/FilterOperations.cpp
,
Dec 7 2017
One M64 change https://chromium-review.googlesource.com/c/chromium/src/+/791919 actually exposed the issue more stably (that is, increased the flakiness, so I could debug the issue and found the cause). Need to merge into M64 to avoid the increased flakiness of the situation.
,
Dec 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf8135d0bce64496b872062a07b427ddff825ec5 commit bf8135d0bce64496b872062a07b427ddff825ec5 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Fri Dec 08 01:05:27 2017 [PE] Avoid null pointer for objects with reflection but no effect Reflection only has effect if we create layer for the object. Some objects (e.g. SVG text) having reflection style but doesn't create layers. Should check for the condition. Bug: 792727 , 777259 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I09528df085002f8d30e1f20fd07a7e7b3f2d3cf1 Reviewed-on: https://chromium-review.googlesource.com/814894 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#522661} [modify] https://crrev.com/bf8135d0bce64496b872062a07b427ddff825ec5/third_party/WebKit/Source/core/layout/LayoutBox.cpp [modify] https://crrev.com/bf8135d0bce64496b872062a07b427ddff825ec5/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp [modify] https://crrev.com/bf8135d0bce64496b872062a07b427ddff825ec5/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
,
Dec 8 2017
,
Dec 8 2017
Merge is not necessary. https://chromium-review.googlesource.com/c/chromium/src/+/791919 is not in m64. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Oct 23 2017