disable-new-zip-unpacker flag is broken |
|||||||||||||
Issue descriptionChrome Version: ToT OS: Chrome What steps will reproduce the problem? (1) Enable --disable-new-zip-unpacker flag (2) Open a zip file What is the expected result? Zip file should be mounted. What happens instead? Nothing happens.
,
Oct 23 2017
IIUC, expected behavior of --disable-new-zip-unpacker flag is to fall back to avfs based zip support. Sometimes, zip unpacker is unavailable, e.g. issue 643060 . The flag is there as a last resort.
,
Oct 23 2017
,
Oct 23 2017
,
Oct 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/2207431a86936d7f5c12ae4809e022e024d0258c commit 2207431a86936d7f5c12ae4809e022e024d0258c Author: Yuki Awano <yawano@google.com> Date: Thu Oct 26 04:59:05 2017 cros-disks: bring back avfs based zip support avfs based zip unpack support is used when user enables --disable-new-zip-unpacker flag. BUG= chromium:777254 TEST=enable --disable-new-zip-unpacker flag and confirm that zip can be unpacked. Change-Id: I19b89b337dcd1687d8131008c7ac11963f84576d Reviewed-on: https://chromium-review.googlesource.com/732797 Commit-Ready: Ben Chan <benchan@chromium.org> Commit-Ready: Yuki Awano <yawano@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/2207431a86936d7f5c12ae4809e022e024d0258c/cros-disks/archive_manager.cc
,
Oct 26 2017
Request merge a CL in comment 5 (https://chromium-review.googlesource.com/c/chromiumos/platform2/+/732797) to M62 and M63.
,
Oct 26 2017
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 26 2017
,
Oct 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/fb1049af45d812e87ae0918c9febe46fef9c024c commit fb1049af45d812e87ae0918c9febe46fef9c024c Author: Ben Chan <benchan@chromium.org> Date: Thu Oct 26 16:42:58 2017 Revert "Remove platform_CrosDisksArchive test." This reverts commit 38b7871f8af661df4c1dd6c78f274dd4d1eb58d6. CL:465507 removed platform_CrosDisksArchive as support for ZIP and TAR archive was removed from cros-disks. However, we need to resurrect platform_CrosDisksArchive for the following reasons: CL:732797 temporarily re-enables ZIP archive support in cros-disks, so we would like to temporarily resurrect platform_CrosDisksArchive to verify ZIP archive support in cros-disks. Also, to prevent future regressions on RAR archive support, we will extend platform_CrosDisksArchive to verify RAR archive support in cros-disks. BUG= chromium:763225 BUG= chromium:777254 TEST=Run platform_CrosDisksArchive. Change-Id: I1cdcc7223da38a5bd0af6e1c6ddaa3429b373ecd Reviewed-on: https://chromium-review.googlesource.com/737941 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [add] https://crrev.com/fb1049af45d812e87ae0918c9febe46fef9c024c/client/site_tests/platform_CrosDisksArchive/control [add] https://crrev.com/fb1049af45d812e87ae0918c9febe46fef9c024c/client/site_tests/platform_CrosDisksArchive/platform_CrosDisksArchive.py
,
Oct 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/f71adcbbc552cea9df8c5ea09e72162f7469f865 commit f71adcbbc552cea9df8c5ea09e72162f7469f865 Author: Ben Chan <benchan@chromium.org> Date: Thu Oct 26 22:57:45 2017 Revert "autotest-tests: remove platform_CrosDisksArchive test" This reverts commit 84e4d7433beb8c75d0a3abf8ed64f0d7feb17196. CL:465507 removed platform_CrosDisksArchive as support for ZIP and TAR archive was removed from cros-disks. However, we need to resurrect platform_CrosDisksArchive for the following reasons: CL:732797 temporarily re-enables ZIP archive support in cros-disks, so we would like to temporarily resurrect platform_CrosDisksArchive to verify ZIP archive support in cros-disks. Also, to prevent future regressions on RAR archive support, we will extend platform_CrosDisksArchive to verify RAR archive support in cros-disks. BUG= chromium:763225 BUG= chromium:777254 CQ-DEPEND=CL:737941 CQ-DEPEND=CL:737942 TEST=Remote trybot runs. Change-Id: I7a745b884e41aa6fd0dee938eddf8d587cd8cdd2 Reviewed-on: https://chromium-review.googlesource.com/738797 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/f71adcbbc552cea9df8c5ea09e72162f7469f865/chromeos-base/autotest-tests-cros-disks/autotest-tests-cros-disks-9999.ebuild
,
Oct 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/0140a6687f015d5f890701f1b922fb0b3e1c16ac commit 0140a6687f015d5f890701f1b922fb0b3e1c16ac Author: Yuki Awano <yawano@google.com> Date: Fri Oct 27 08:06:42 2017 cros-disks: bring back avfs based zip support avfs based zip unpack support is used when user enables --disable-new-zip-unpacker flag. BUG= chromium:777254 TEST=enable --disable-new-zip-unpacker flag and confirm that zip can be unpacked. Change-Id: I19b89b337dcd1687d8131008c7ac11963f84576d Reviewed-on: https://chromium-review.googlesource.com/732797 Commit-Ready: Ben Chan <benchan@chromium.org> Commit-Ready: Yuki Awano <yawano@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> (cherry picked from commit 2207431a86936d7f5c12ae4809e022e024d0258c) Reviewed-on: https://chromium-review.googlesource.com/741122 Reviewed-by: Yuki Awano <yawano@chromium.org> Commit-Queue: Yuki Awano <yawano@chromium.org> Tested-by: Yuki Awano <yawano@chromium.org> [modify] https://crrev.com/0140a6687f015d5f890701f1b922fb0b3e1c16ac/cros-disks/archive_manager.cc
,
Oct 27 2017
,
Oct 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/ab5ef6d387bfc9f22ae73a0d9c2aece05bd6b5f5 commit ab5ef6d387bfc9f22ae73a0d9c2aece05bd6b5f5 Author: Yuki Awano <yawano@google.com> Date: Mon Oct 30 11:02:09 2017 cros-disks: bring back avfs based zip support avfs based zip unpack support is used when user enables --disable-new-zip-unpacker flag. BUG= chromium:777254 TEST=enable --disable-new-zip-unpacker flag and confirm that zip can be unpacked. Change-Id: I19b89b337dcd1687d8131008c7ac11963f84576d Reviewed-on: https://chromium-review.googlesource.com/732797 Commit-Ready: Ben Chan <benchan@chromium.org> Commit-Ready: Yuki Awano <yawano@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> (cherry picked from commit 2207431a86936d7f5c12ae4809e022e024d0258c) Reviewed-on: https://chromium-review.googlesource.com/743641 Reviewed-by: Yuki Awano <yawano@chromium.org> Commit-Queue: Yuki Awano <yawano@chromium.org> Tested-by: Yuki Awano <yawano@chromium.org> [modify] https://crrev.com/ab5ef6d387bfc9f22ae73a0d9c2aece05bd6b5f5/cros-disks/archive_manager.cc
,
Oct 31 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 1 2017
The CL has merged to M62 and M63. Removing Merge-Approved labels and making the issue as fixed for now.
,
Jan 22 2018
,
Jan 23 2018
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by yawano@chromium.org
, Oct 23 2017