[css-typed-om] CSSSkew constructor should reject non-angles. |
|||||
Issue descriptionCSSSkew constructor should only take angles, and throw an error if not given angle values. Spec: https://drafts.css-houdini.org/css-typed-om-1/#cssskew Test failure: FAIL Constructing a CSSSkew with a number CSSUnitValue throws a TypeError assert_throws: function "() => new CSSSkew(value, CSS.deg(0))" did not throw
,
Oct 31 2017
Should be easy. Added to Hotlist-GoodFirstBug.
,
Oct 31 2017
I will try to check this issue.
,
Oct 31 2017
,
Nov 3 2017
Submitted https://chromium-review.googlesource.com/c/chromium/src/+/750542 for review.
,
Nov 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be8cb489375a0838f529387f4dfd4595e7cd2ca4 commit be8cb489375a0838f529387f4dfd4595e7cd2ca4 Author: nikhil <nikhil.sahni@samsung.com> Date: Mon Nov 06 07:44:52 2017 CSSSkew constructor should reject non-angles. CSSSkew constructor should only take angles, and throw an error if not given angle values. Bug: 777248 Change-Id: I2b00f9bfddf0e6f542faccd6e6d6e84a266cb5e9 Reviewed-on: https://chromium-review.googlesource.com/750542 Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#514097} [delete] https://crrev.com/178bdd683de4e97e0f18df4e109683e190a10393/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/cssSkew-expected.txt [modify] https://crrev.com/be8cb489375a0838f529387f4dfd4595e7cd2ca4/third_party/WebKit/Source/core/css/cssom/CSSSkew.cpp [modify] https://crrev.com/be8cb489375a0838f529387f4dfd4595e7cd2ca4/third_party/WebKit/Source/core/css/cssom/CSSSkew.h [modify] https://crrev.com/be8cb489375a0838f529387f4dfd4595e7cd2ca4/third_party/WebKit/Source/core/css/cssom/CSSSkew.idl
,
Nov 17 2017
,
Nov 29 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dtapu...@chromium.org
, Oct 25 2017