NativeWidgetMacTest.VisibleAfterNativeParent{Show,Deminiaturize} flake (rarely) on 10.10, 10.11 |
||||||||
Issue descriptionChrome Version : 63.0.3236.0 OS Version: OS X 10.10, 10.12 The 10.10 and 10.12 waterfall bots occasionally fail on this test. NativeWidgetMacTest.VisibleAfterNativeParentDeminiaturize which is added in https://chromium-review.googlesource.com/c/chromium/src/+/706879 is flaky on Mac10.10 Tests. failure log: [ RUN ] NativeWidgetMacTest.VisibleAfterNativeParentDeminiaturize ../../ui/views/widget/native_widget_mac_unittest.mm:816: Failure Value of: [native_parent isVisible] Actual: true Expected: false ../../ui/views/widget/native_widget_mac_unittest.mm:817: Failure Value of: child->IsVisible() Actual: true Expected: false [ FAILED ] NativeWidgetMacTest.VisibleAfterNativeParentDeminiaturize (126 ms) sample failure link: https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/25167 There's one for NativeWidgetMacTest.VisibleAfterNativeParentShow in https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/25192 the last one for NativeWidgetMacTest.VisibleAfterNativeParentDeminiaturize was in https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/25185 these are probably related. I tried really hard to get this to flake on 10.12 without success. I found a NativeWidgetMacTest.VisibleAfterNativeParentShow on 10.11 - https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.11%20Tests/builds/19429 Nothing appears in chromium-try-flakes Nothing appears on - https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests?numbuilds=200 or - https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.12%20Tests?numbuilds=200
,
Oct 31 2017
This is showing up with some regularity on 10.10 -- https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=views_unittests&tests=NativeWidgetMacTest.VisibleAfterNativeParentDeminiaturize It's not anywhere else in a significant way. I'll just disable on 10.10 for now - I suspect an AppKit/WindowServer glitch.
,
Oct 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6fafe2c6d6126cdb75e76fb99af77db1ac354c1 commit b6fafe2c6d6126cdb75e76fb99af77db1ac354c1 Author: Trent Apted <tapted@chromium.org> Date: Tue Oct 31 06:35:20 2017 Disable NativeWidgetMacTest.VisibleAfterNativeParentDeminiaturize on 10.10 It flakes out on 10.10 (only) at a sufficiently annoying rate. TBR=tapted@chromium.org,ellyjones@chromium.org Bug: 777247 Change-Id: I01fb8f576804f76f419976825d68c711aa81d964 Reviewed-on: https://chromium-review.googlesource.com/746382 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#512766} [modify] https://crrev.com/b6fafe2c6d6126cdb75e76fb99af77db1ac354c1/ui/views/widget/native_widget_mac_unittest.mm
,
Jan 23 2018
,
Mar 26 2018
MacViews triage: tagging this for cleanup, marking available, and marking M-X since it seems very rare.
,
Jun 5 2018
,
Jun 5 2018
NativeWidgetMacTest.VisibleAfterNativeParentShow has started flaking on 10.13 bots [ RUN ] NativeWidgetMacTest.VisibleAfterNativeParentShow ../../ui/views/widget/native_widget_mac_unittest.mm:877: Failure Value of: child->IsVisible() Actual: false Expected: true Stack trace: 0 views_unittests 0x000000010e01b93b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91 1 views_unittests 0x000000010e01b2f9 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89 2 views_unittests 0x000000010d6098d6 views::test::NativeWidgetMacTest_VisibleAfterNativeParentShow_Test::TestBody() + 1014 [ FAILED ] NativeWidgetMacTest.VisibleAfterNativeParentShow (10320 ms) This is using -[NSApp hide] which might be suffering from global state conflicts.. sending a disable CL
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6dc93c0bac364d7696216e9fdb71f137c16ae7f commit a6dc93c0bac364d7696216e9fdb71f137c16ae7f Author: Trent Apted <tapted@chromium.org> Date: Tue Jun 05 07:05:00 2018 Disable NativeWidgetMacTest.VisibleAfterNativeParentShow It's started flaking unexpectedly on 10.13. TBR=tapted@chromium.org Bug: 777247 Change-Id: I0920be738aa23632f77ce449d3ebaf32030cdb44 Reviewed-on: https://chromium-review.googlesource.com/1086812 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#564385} [modify] https://crrev.com/a6dc93c0bac364d7696216e9fdb71f137c16ae7f/ui/views/widget/native_widget_mac_unittest.mm
,
Jun 5 2018
Detected 3 new flakes for test/step "NativeWidgetMacTest.VisibleAfterNativeParentShow". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOwsSBUZsYWtlIjBOYXRpdmVXaWRnZXRNYWNUZXN0LlZpc2libGVBZnRlck5hdGl2ZVBhcmVudFNob3cM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Jun 5 2018
last flake was 2018-06-05 01:14:34 UTC which is 22 hours ago.
,
Jun 21 2018
,
Jul 21
,
Nov 19
***UI Mass Triage *** |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by tapted@chromium.org
, Oct 23 2017