New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 777231 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Undefined-shift in WebRtcAgc_ProcessVad

Project Member Reported by ClusterFuzz, Oct 22 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6505591718805504

Fuzzer: libFuzzer_audio_processing_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Undefined-shift
Crash Address: 
Crash State:
  WebRtcAgc_ProcessVad
  WebRtcAgc_AddMic
  webrtc::GainControlImpl::AnalyzeCaptureAudio
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=509903:509934

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6505591718805504

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Cc: msrchandra@chromium.org ale...@webrtc.org henrik.lundin@webrtc.org pnangunoori@chromium.org
Components: Blink>WebRTC
Labels: M-64 Test-Predator-Correct-CLs
Test Predator has given the following results:

Improving APM fuzzer coverage. by aleloi@webrtc.org
Suspected changelist touched file(s) in the directory test/fuzzers, which appears in the stack trace.

@aleloi  -- Could you please look into this issue, kindly reassign if it has nothing to do with your changes.

Note: As the suspect is out of chromium adding, suspect in CC.

Thank You.

Cc: -ale...@webrtc.org -henrik.lundin@webrtc.org hlundin@chromium.org
Owner: aleloi@chromium.org

Comment 3 by guidou@chromium.org, Oct 23 2017

Components: -Blink>WebRTC Blink>WebRTC>Audio Internals>WebRTC
Status: Assigned (was: Untriaged)

Comment 4 by mmoroz@chromium.org, Oct 24 2017

For more information, please see https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md.

The link referenced in the description is no longer valid.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/b9f536167c951558cce8ab18a5012e0822d18855

commit b9f536167c951558cce8ab18a5012e0822d18855
Author: Alex Loiko <aleloi@webrtc.org>
Date: Wed Oct 25 13:35:36 2017

Removing undefined left shifts in AudioProcessing

This CL replaces 5 left shifts where the shifted value may be 
negative. The shifts are replaced with equivalent multiplications.

Bug:  chromium:777231 ,  chromium:776719 ,  chromium:776624 ,  chromium:776286 
Change-Id: Ifb27d5506eac779e60f238432bdf9e4bc5b2da4c
Reviewed-on: https://webrtc-review.googlesource.com/14800
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Commit-Queue: Alex Loiko <aleloi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20430}
[modify] https://crrev.com/b9f536167c951558cce8ab18a5012e0822d18855/common_audio/signal_processing/resample_by_2.c
[modify] https://crrev.com/b9f536167c951558cce8ab18a5012e0822d18855/common_audio/vad/vad_filterbank.c
[modify] https://crrev.com/b9f536167c951558cce8ab18a5012e0822d18855/modules/audio_processing/agc/legacy/digital_agc.c

Project Member

Comment 6 by ClusterFuzz, Oct 26 2017

ClusterFuzz has detected this issue as fixed in range 511516:511546.

Detailed report: https://clusterfuzz.com/testcase?key=6505591718805504

Fuzzer: libFuzzer_audio_processing_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Undefined-shift
Crash Address: 
Crash State:
  WebRtcAgc_ProcessVad
  WebRtcAgc_AddMic
  webrtc::GainControlImpl::AnalyzeCaptureAudio
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=509903:509934
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=511516:511546

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6505591718805504

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Oct 26 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6505591718805504 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment