New issue
Advanced search Search tips

Issue 777220 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

DownloadContentTest.{Cancel,Remove}ResumedDownload - content_browsertests failing on chromium.win/Win7 Tests (dbg)(1) and on Android

Project Member Reported by tapted@chromium.org, Oct 22 2017

Issue description

content_browsertests failing on chromium.win/Win7 Tests (dbg)(1)

Builders failed on: 
- Win7 Tests (dbg)(1): 
  https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29


DownloadContentTest.RemoveResumedDownload and DownloadContentTest.CancelResumedDownload have been failing quite (but not completely) reliably since

https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/64103

Suspect r510605 "Rewrite download browsertests that rely on TestDownloadRequestHandler" -> https://chromium-review.googlesource.com/722201

Errors like

[ RUN      ] DownloadContentTest.RemoveResumedDownload
DevTools listening on ws://127.0.0.1:53956/devtools/browser/21a38941-fe95-42a0-9591-cc71dbd11bb7
[5884:3364:1020/173144.703:9794741:FATAL:url_request_context.cc(162)] Check failed: false. Leaked 1 URLRequest(s). First URL: http://1.default.example.com:53957/download/.
Backtrace:
	base::debug::StackTrace::StackTrace [0x026C7097+55]
	base::debug::StackTrace::StackTrace [0x026C6911+17]
	logging::LogMessage::~LogMessage [0x0271C26E+94]
	net::URLRequestContext::AssertNoURLRequests [0x07836205+421]
	std::vector<std::unique_ptr<net::URLRequestInterceptor,std::default_delete<net::URLRequestInterceptor> >,std::allocator<std::unique_ptr<net::URLRequestInterceptor,std::default_delete<net::URLRequestInterceptor> > > >::~vector<std::unique_ptr<net::URLReque [0x0783DEBF+159]
	net::`anonymous namespace'::ContainerURLRequestContext::`scalar deleting destructor' [0x0784015F+15]
	std::default_delete<net::URLRequestContext>::operator() [0x019A4D49+41]
	std::unique_ptr<net::URLRequestContext,std::default_delete<net::URLRequestContext> >::reset [0x019A7B4A+58]
	std::unique_ptr<net::URLRequestContext,std::default_delete<net::URLRequestContext> >::operator= [0x019A4531+17]
	content::ShellURLRequestContextGetter::NotifyContextShuttingDown [0x019A5AC6+214]
	??$Invoke@V?$scoped_refptr@VShellURLRequestContextGetter@content@@@@$$V@?$FunctorTraits@P8ShellURLRequestContextGetter@content@@AEXXZX@internal@base@@SAXP8ShellURLRequestContextGetter@content@@AEXXZ$$QAV?$scoped_refptr@VShellURLRequestContextGetter@conten [0x019982D3+19]
	base::internal::InvokeHelper<0,void>::MakeItSo<void (__thiscall content::ShellURLRequestContextGetter::*)(void),scoped_refptr<content::ShellURLRequestContextGetter> > [0x01998368+40]
	base::internal::Invoker<base::internal::BindState<void (__thiscall content::ShellURLRequestContextGetter::*)(void),scoped_refptr<content::ShellURLRequestContextGetter> >,void __cdecl(void)>::RunImpl<void (__thiscall content::ShellURLRequestContextGetter:: [0x019983B4+52]
	base::internal::Invoker<base::internal::BindState<void (__thiscall content::ShellURLRequestContextGetter::*)(void),scoped_refptr<content::ShellURLRequestContextGetter> >,void __cdecl(void)>::RunOnce [0x01999B36+54]
	base::OnceCallback<void __cdecl(void)>::Run [0x0266FAF5+53]
	base::debug::TaskAnnotator::RunTask [0x026CC523+483]
 

Comment 1 by tapted@chromium.org, Oct 22 2017

Labels: OS-Linux
Hunh - this is also failing on Cast_Linux

 -> https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/44913

that's r510618 so r510605 is still possible for the start of the flakes.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff3388aa7a90483d5b26ecbc925ad5fcaa7ced23

commit ff3388aa7a90483d5b26ecbc925ad5fcaa7ced23
Author: Trent Apted <tapted@chromium.org>
Date: Sun Oct 22 23:32:37 2017

Disable DownloadContentTest.{Cancel,Remove}ResumedDownload

Flaky since
 - https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/64103
 - https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/44913

Possibly r510605.

TBR=qinmin@chromium.org,

No-Try: true
Bug: 777220
Change-Id: I4922cfe375f56473ea274c2549ea1a108e04e7a3
Reviewed-on: https://chromium-review.googlesource.com/731986
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510711}
[modify] https://crrev.com/ff3388aa7a90483d5b26ecbc925ad5fcaa7ced23/content/browser/download/download_browsertest.cc

Comment 4 by battre@chromium.org, Oct 23 2017

Labels: -Sheriff-Chromium
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/468f87e9b4ed8d06280334aa48e6584b3a5983c4

commit 468f87e9b4ed8d06280334aa48e6584b3a5983c4
Author: Min Qin <qinmin@chromium.org>
Date: Tue Oct 24 03:25:05 2017

Reenable 2 disabled download browsertests

When a download is cancelled/removed, the embedded test server may still
in the middle of sending responses.
As a result, the tests failed as the URLRequest is not yet removed.
We have to wait until server finishes sending all responses before terminating the test.
The added new WaitForServerToFinishAllResponses() method also allow us to validate
the number of requests sent to the server.

BUG=777220

Change-Id: I5792a83536425176d6b2047510b3b7573295053c
Reviewed-on: https://chromium-review.googlesource.com/733812
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511029}
[modify] https://crrev.com/468f87e9b4ed8d06280334aa48e6584b3a5983c4/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/468f87e9b4ed8d06280334aa48e6584b3a5983c4/content/browser/download/test_download_http_response.cc

Comment 6 by kbr@chromium.org, Jan 4 2018

Labels: OS-Android
Summary: DownloadContentTest.RemoveResumedDownload - content_browsertests failing on chromium.win/Win7 Tests (dbg)(1) and on Android (was: DownloadContentTest.RemoveResumedDownload - content_browsertests failing on chromium.win/Win7 Tests (dbg)(1))
At least DownloadContentTest.CancelResumedDownload is still flaky on the android_n5x_swarming_rel tryserver:

https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/332422

[ RUN      ] DownloadContentTest.CancelResumedDownload
[WARNING:dns_config_service_posix.cc(341)] Failed to read DnsConfig.
[ERROR:devtools_http_handler.cc(249)] Cannot start http server for devtools. Stop devtools.
[WARNING:child_process_launcher_helper_posix.cc(118)] Ignoring invalid file assets/snapshot_blob_32.bin
[WARNING:simple_synchronous_entry.cc(1170)] Could not open platform files for entry.
[FATAL:lock_impl_posix.cc(51)] Check failed: rv == 0 (16 vs. 0). Device or resource busy

[ERROR:test_suite.cc(298)] Currently running: DownloadContentTest.CancelResumedDownload
Searching for native crashes in: /b/swarming/w/itwWPG_w/tmp7abqD4
Unknown Android release, consider passing --packed-lib.
Reading Android symbols from: /b/swarming/w/ir
Searching for Chrome symbols from within: /b/swarming/w/ir/out/Release/lib.unstripped:/b/swarming/w/ir/out/Release/lib:/b/swarming/w/ir/out/Release

Stack Trace:
  RELADDR   FUNCTION                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           FILE:LINE
  0000000000ddc043  logging::LogMessage::~LogMessage()                                                                                                                                                                                                                                                                                                                                                                                                                                                                                 /b/c/b/android_n5x_swarming_rel/src/base/logging.cc:581:29
  0000000000e1d8ff  base::internal::LockImpl::~LockImpl()                                                                                                                                                                                                                                                                                                                                                                                                                                                                              /b/c/b/android_n5x_swarming_rel/src/base/synchronization/lock_impl_posix.cc:51:3
  0000000000e1d3ab  base::Lock::~Lock()                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                /b/c/b/android_n5x_swarming_rel/src/base/synchronization/lock.cc:20:1
  v------>  base::WaitableEvent::WaitableEventKernel::~WaitableEventKernel()                                                                                                                                                                                                                                                                                                                                                                                                                                                   /b/c/b/android_n5x_swarming_rel/src/base/synchronization/waitable_event_posix.cc:377:58
  v------>  void base::RefCountedThreadSafe<base::WaitableEvent::WaitableEventKernel, base::DefaultRefCountedThreadSafeTraits<base::WaitableEvent::WaitableEventKernel> >::DeleteInternal<base::WaitableEvent::WaitableEventKernel>(base::WaitableEvent::WaitableEventKernel const*)                                                                                                                                                                                                                                           /b/c/b/android_n5x_swarming_rel/src/base/memory/ref_counted.h:397:0
  v------>  base::DefaultRefCountedThreadSafeTraits<base::WaitableEvent::WaitableEventKernel>::Destruct(base::WaitableEvent::WaitableEventKernel const*)                                                                                                                                                                                                                                                                                                                                                                       /b/c/b/android_n5x_swarming_rel/src/base/memory/ref_counted.h:350:0
  v------>  base::RefCountedThreadSafe<base::WaitableEvent::WaitableEventKernel, base::DefaultRefCountedThreadSafeTraits<base::WaitableEvent::WaitableEventKernel> >::Release() const                                                                                                                                                                                                                                                                                                                                          /b/c/b/android_n5x_swarming_rel/src/base/memory/ref_counted.h:386:0
  v------>  scoped_refptr<base::WaitableEvent::WaitableEventKernel>::Release(base::WaitableEvent::WaitableEventKernel*)                                                                                                                                                                                                                                                                                                                                                                                                        /b/c/b/android_n5x_swarming_rel/src/base/memory/scoped_refptr.h:269:0
  v------>  scoped_refptr<base::WaitableEvent::WaitableEventKernel>::~scoped_refptr()                                                                                                                                                                                                                                                                                                                                                                                                                                          /b/c/b/android_n5x_swarming_rel/src/base/memory/scoped_refptr.h:197:0
  0000000000e1dc4f  base::WaitableEvent::~WaitableEvent()                                                                                                                                                                                                                                                                                                                                                                                                                                                                              /b/c/b/android_n5x_swarming_rel/src/base/synchronization/waitable_event_posix.cc:49:0
...


Seemed to flake 3 times before failing. Please see the logcats:

https://00e9e64bac81a7889e4e5e36b9a8aaa8934cb42ebbde380943-apidata.googleusercontent.com/download/storage/v1/b/chromium-result-details/o/html%2Fcontent_browsertests_android_n5x_swarming_rel_332422_2017_12_31_T22_40_29-UTC?qk=AD5uMEs26l_IKrHAsbZbmJUVxaIFCgaH0Hy_2NxzvoLFuTJE07B4qLPvJ3fzqXkWQphFEqmaufAhOd8axH13mRIhHF_rAElByhIXa6o3Y2Xui50jQlfLLoDneHMuYUYkdLv0-V7ZNo7oZLbD1f8-TthvWkAOuQPzXa9f5nQ9HgYbc8B1Wq-w__IVY24jIzdPozErHDmiFEzJjMlVsL8vl6_hNiCKfZVQz_71ljZ9BvzcCv-MzfMyBvA4_6WmR0fn2iskjX0n-EKOmLUiQnek_eYVpH29su6ieyd-Tv3QvjZqczL65o8hh7orumVs2pvUCsikB_TwIm9JPXFCGwkQqGqsNM1Gyrd8iRZK_EVnb5ZkUJcbR-UsyZaH0kazS3VWZDyt2Xi0VadHUuFvkJzf_khvdlKD2qmSmHjAC4cYnGHoSUyhAN0KuuVDzLeP73nau8a4O2d6KGlU2WAMzpqLqDkuE18DzG_xHv3sTVkHoB0CKxJB14zsSgC6Qgy5A9VhtaYBRZVO0T2vAFD-NWwnYuePOQYzUfiXKo8e7nbMBjRrzdFVgLxEFxW2bvKjwOlImfkYglO0nFOjInTFIfHsBHFlPe6a4TDBifsgxUvZRuGl9PqRIMhoOyRX6-9cUhFk4qy_EVKjNnW1J8zbI1luTvlhIagLEOZw6pP6Co2CMde2gRJocvYBwVh2gz5XSIgGj4AGbwJ9qVA7uuRPMfNLjDh3JsAFa-FlT5b-qDYPMQHjWrVlqouMXmeQqHhATvWMcfi33ROZNjiGhl4FgKn1r-hrRvjnLMMNFz0npb86aitprGCDjCJ5A8PWAWrgcJ0vVF-BGfLV-rvUvv2XzNsjApWUqrs9tnOejg

Comment 7 by kbr@chromium.org, Jan 4 2018

Summary: DownloadContentTest.{Cancel,Remove}ResumedDownload - content_browsertests failing on chromium.win/Win7 Tests (dbg)(1) and on Android (was: DownloadContentTest.RemoveResumedDownload - content_browsertests failing on chromium.win/Win7 Tests (dbg)(1) and on Android)

Sign in to add a comment