performance tab in dev tools shows incorrect line number of where a function call occurs after formatting minified JavaScript code.
Reported by
nnkpar...@gmail.com,
Oct 22 2017
|
|||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36 Steps to reproduce the problem: All details are here (not sure if its a bug or not): https://stackoverflow.com/questions/46869692/chrome-dev-tool-not-showing-the-correct-line-number-where-function-call-occurs-u 1. Launch Chrome. 2. Load https://github.com/nnkparikh/devtool1 in one tab. 3. Open dev tools and go to the "sources" tab. 4. Pretty-print the minified JavaScript "app-bundle.js" file in the "dist" folder. 5. Go to the "performance" tab in dev tools. 6. Profile the page and while profiling is happening click the button on the page. 7. Stop profiling. 8. In the results given, find the click Event for that button on the "main" section. 9. You will notice that the click event leads to a function call at line 1 even after pretty-printing the minified JavaScript code. What is the expected behavior? The line numbers shown under the performance tab should change to indicate the line number after pretty printing minified JavaScript code. What went wrong? Not sure. Did this work before? N/A Chrome version: 61.0.3163.100 Channel: n/a OS Version: OS X 10.12.0 Flash Version: Take a look here: https://stackoverflow.com/questions/46869692/chrome-dev-tool-not-showing-the-correct-line-number-where-function-call-occurs-u
,
Oct 23 2017
,
Oct 23 2017
Edit: In step 2, I meant "Load https://nnkparikh.github.io/devtool1/".
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9044af2941b48986a24c65852281146d07e11df0 commit 9044af2941b48986a24c65852281146d07e11df0 Author: Alexei Filippov <alph@chromium.org> Date: Wed Oct 25 02:28:41 2017 DevTools: Report column number for FunctionCall trace events. This is needed to properly map pretty-printed source. BUG= 777159 Change-Id: I3b78e70d96a26461369f9543ac5cb03e24e2ca1f Reviewed-on: https://chromium-review.googlesource.com/734424 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#511333} [modify] https://crrev.com/9044af2941b48986a24c65852281146d07e11df0/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-time/timeline-timer-expected.txt [modify] https://crrev.com/9044af2941b48986a24c65852281146d07e11df0/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp [modify] https://crrev.com/9044af2941b48986a24c65852281146d07e11df0/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
,
Oct 25 2017
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e956deeaf2ab913c3f1f82b56fc9f7e885209fc commit 9e956deeaf2ab913c3f1f82b56fc9f7e885209fc Author: Alexei Filippov <alph@chromium.org> Date: Wed Oct 25 20:54:33 2017 Revert "DevTools: Report column number for FunctionCall trace events." This reverts commit 9044af2941b48986a24c65852281146d07e11df0. Reason for revert: Accusingly broke http/tests/devtools/tracing/frame-model-instrumentation.html Original change's description: > DevTools: Report column number for FunctionCall trace events. > > This is needed to properly map pretty-printed source. > > BUG= 777159 > > Change-Id: I3b78e70d96a26461369f9543ac5cb03e24e2ca1f > Reviewed-on: https://chromium-review.googlesource.com/734424 > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Commit-Queue: Alexei Filippov <alph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#511333} TBR=alph@chromium.org,caseq@chromium.org Change-Id: Ia3b1ab1afbfd88c07b52f899a4ed5252558cde67 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 777159 , 778271 Reviewed-on: https://chromium-review.googlesource.com/738632 Reviewed-by: Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#511580} [modify] https://crrev.com/9e956deeaf2ab913c3f1f82b56fc9f7e885209fc/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-time/timeline-timer-expected.txt [modify] https://crrev.com/9e956deeaf2ab913c3f1f82b56fc9f7e885209fc/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp [modify] https://crrev.com/9e956deeaf2ab913c3f1f82b56fc9f7e885209fc/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
,
Oct 25 2017
,
Oct 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf8a5cff72097dec425c3ccf8395d7241f11e942 commit cf8a5cff72097dec425c3ccf8395d7241f11e942 Author: Alexei Filippov <alph@chromium.org> Date: Fri Oct 27 00:33:43 2017 Reland "DevTools: Report column number for FunctionCall trace events." This is a reland of 9044af2941b48986a24c65852281146d07e11df0 Original change's description: > DevTools: Report column number for FunctionCall trace events. > > This is needed to properly map pretty-printed source. > > BUG= 777159 > > Change-Id: I3b78e70d96a26461369f9543ac5cb03e24e2ca1f > Reviewed-on: https://chromium-review.googlesource.com/734424 > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Commit-Queue: Alexei Filippov <alph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#511333} TBR=caseq@chromium.org Bug: 777159 Change-Id: If68c51db6072b794262b0ca0a7c60c89db17385a Reviewed-on: https://chromium-review.googlesource.com/740941 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#512042} [modify] https://crrev.com/cf8a5cff72097dec425c3ccf8395d7241f11e942/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-time/timeline-timer-expected.txt [modify] https://crrev.com/cf8a5cff72097dec425c3ccf8395d7241f11e942/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp [modify] https://crrev.com/cf8a5cff72097dec425c3ccf8395d7241f11e942/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
,
Nov 2 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by nyerramilli@chromium.org
, Oct 23 2017