Table cell wraps unnecessarily at 125% zoom level
Reported by
rudiedi...@gmail.com,
Oct 22 2017
|
|||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.62 Safari/537.36 Example URL: https://jsfiddle.net/rudiedirkx/062k4871/ Steps to reproduce the problem: 1. See table with content. Not too little, not too much. What is the expected behavior? Cells only wrap their content if they have to. This case has plenty of room left. What went wrong? The longest cell wraps. In case you don't see this madness, screenshot attached. Chrome Canary 64 has the same exact bug. Does it occur on multiple sites: Yes Is it a problem with a plugin? N/A Did this work before? Yes 61 or 60? Does this work in other browsers? Yes Chrome version: 62.0.3202.62 Channel: stable OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: Works fine in IE 11, Firefox 56.
,
Oct 22 2017
My Windows 7 DPI/zoom is 125% btw. That might be relevant. Chrome itself works well with that, as do Firefox and IE. I haven't tried on any other PC.
,
Oct 23 2017
,
Oct 23 2017
Unable to reproduce the issue on reported version 62.0.3202.62 and latest canary 64.0.3247.0 using Win 7 and Win 10 with DPI 125% @ rudiedirkx : Could you please re-try the scenario by creating a new profile Please follow below steps to create a New profile (i)Launch chrome>>go to Settings) (ii)Under the section headed People, Click on link Manage other people>>Add person Please find the screenshot attached. If the issue still persist please provide your observation for further triaging the issue
,
Oct 23 2017
Huh... Guest profile and new profile in Canary and Stable all have this problem... The only thing covering all those scenario's is Windows... I'll try on a Win 10 with and without 125% DPI tomorrow. Is there any way to debug layout calc? Something in Devtools?
,
Oct 23 2017
Thank you for providing more feedback. Adding requester "divya.padigela@techmahindra.com" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 23 2017
,
Oct 24 2017
I can't reproduce on another PC. Win 10, with and without scaling, in any profile, with any zoom. More screenshots from where it's broken. It's just the last word, whatever the word, whatever the needed width.
,
Oct 24 2017
`white-space: nowrap;` still 'works', but that breaks lines that are actually too long. I've no idea. It's kind of confusing, but it hasn't been a real problem.
,
Oct 24 2017
Thank you for providing more feedback. Adding requester "dglazkov@chromium.org" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 24 2017
I'm able to reproduce this on Chrome Linux 63.0.3236.7 by setting the browser zoom to 125% (hit Ctrl-+ twice). I suspect some rounding error in table layout. On Browserstack I can see this works fine on Chrome 61 Windows, but fails Chrome 63 Windows. So there's a regression here somewhere. Can we get a bisect?
,
Oct 24 2017
Woohoo it exists, I'm not crazy! 100% and 110% zoom break here. 90% and 125% are good.
,
Oct 25 2017
Able to reproduce the issue on Windows 10, Ubuntu 14.04 and Mac 10.12.6 using chrome stable version #62.0.3202.62 and latest canary #64.0.3248.2. Bisect Information: ===================== Good build: 62.0.3189.0 Revision(495410) Bad Build : 62.0.3190.0 Revision(495757) Change Log URL: https://chromium.googlesource.com/chromium/src/+log/47bf178b9802260a023f43f3170ca7b4e6242163..27d732d9364e1f139dafdbacc813318b5a9a852f From the above change log suspecting below change Change-Id: I7264901fb26426689d05427893bbf709ea5046ac Reviewed-on: https://chromium-review.googlesource.com/619603 wangxianzhu@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: Adding label ReleaseBlock-Stable as it seems to be a recent regression. Thanks...!!
,
Oct 25 2017
The NextAction date has arrived: 2017-10-25
,
Oct 26 2017
M-62 is already serving Stable, hence punting this to M-63. Please feel free to update if someone thinks otherwise. Thank you!
,
Oct 27 2017
,
Oct 27 2017
Reduced test case:
<style>
table {
border-spacing: 0;
}
td {
border: 1px solid black;
padding: 0;
}
</style>
<table>
<tr>
<td>Tennis- en squashcentrum Nieuwe Sloot</td>
</tr>
</table>
,
Oct 27 2017
Actually this is not a new issue. With my reduced test case, I can even reproduce the issue with the revision before my CL. My CL perhaps just changed how the bug behaves in some particular cases. This seems a result of incomplete subpixel layout support in tables (crbug.com/377847). I feel there might be a quick fix for the issue by changing the method of rounding cell preferred logical width to int (into column_layout.max_logical_width and column_layout.min_logical_width) from truncation to round or ceil. Am trying it.
,
Oct 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e16b03e287a4a593f5899f4de3d605be81f364b commit 1e16b03e287a4a593f5899f4de3d605be81f364b Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Fri Oct 27 23:10:42 2017 Ceil table cell's preferred logical width Table layout still uses integers in many places (crbug.com/377847). Previously we ceiled table cell's preferred logical width before adding border and padding widths, sometimes causing inadequate width when border and padding have subpixels. Now ceil after adding border and padding widths. Bug: 777156 Change-Id: I0f9ebafe8b8e1ebbdea01716a7dca14961dbb678 Reviewed-on: https://chromium-review.googlesource.com/742141 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#512341} [add] https://crrev.com/1e16b03e287a4a593f5899f4de3d605be81f364b/third_party/WebKit/LayoutTests/fast/table/auto-fit-cell-page-zoom-expected.html [add] https://crrev.com/1e16b03e287a4a593f5899f4de3d605be81f364b/third_party/WebKit/LayoutTests/fast/table/auto-fit-cell-page-zoom.html [modify] https://crrev.com/1e16b03e287a4a593f5899f4de3d605be81f364b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
,
Oct 30 2017
,
Oct 30 2017
This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 30 2017
This issue is reported on M62 and per comment #19 this is not a regression and stable blocker. M63 is already promoted to Beta and we're only taking critical merges in. Can't this wait until M64?
,
Oct 30 2017
,
Dec 27 2017
|
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by rudiedi...@gmail.com
, Oct 22 201757.8 KB
57.8 KB View Download