New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 777097 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Cannot select value in text box from previous values

Reported by qwer1...@gmail.com, Oct 21 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3245.0 Safari/537.36

Steps to reproduce the problem:
1. Go to a site with a text box which has a previous values 
2. Type the first letter of the entry
3. The previous value should appear below the box
4. Select the value

What is the expected behavior?
The previous value should be selected and copied into the text box

What went wrong?
The value is not copied

Did this work before? Yes Recently

Chrome version: 64.0.3245.0  Channel: canary
OS Version: 10.0
Flash Version:
 

Comment 1 by qwer1...@gmail.com, Oct 21 2017

l_entered file shows what happens after letter 'l' is entered. You can see there're two previous entries for the text box.

mouse_on file shows what happens when the cursor is brought onto the first entry.

after_click shows what happens after that entry is clicked on. Note that the entry was NOT copied into the text box.

l_entered.jpg
273 KB View Download
mouse_on.jpg
313 KB View Download
after_click.jpg
337 KB View Download
Labels: Needs-Triage-M64 Needs-Bisect
Cc: pnangunoori@chromium.org
Labels: -Needs-Bisect hasbisect-per-revision M-64 OS-Linux OS-Mac
Owner: se...@chromium.org
Status: Assigned (was: Unconfirmed)
Tested on latest Chrome Stable #62.0.3202.62, Canary #64.0.3247.0 on Windows 10, Mac 10.12.6 and Ubuntu 14.04 and able to reproduce the issue on latest Canary.

Using the per-revision bisect providing the bisect results,
Good build: 64.0.3244.0 (509944)
Bad build: 64.0.3245.0 (510270)

You are probably looking for a change made after 509960 (known good), but no later than 509961 (first known bad).

CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+/962a26fe7d0355903d4c2721faddcbe51e0ee45c

From the CL above, assigning the issue to the owner concerned.

@sebsg:  Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to owner concerned.

Review-URL: https://chromium-review.googlesource.com/702056

Note: Issue is not reproduced on latest Stable #62.0.3202.62.



Comment 4 by qwer1...@gmail.com, Oct 26 2017

BTW, just noticed, that if don't input anything in text box but just click inside and then select an entry, the entry is selected as expected.
So the bug manifests itself when a partial text is input in the text box.

Comment 5 by se...@chromium.org, Oct 30 2017

Status: Started (was: Assigned)
I have a fix ready, sending it in for review.

Comment 6 by se...@chromium.org, Oct 30 2017

Cc: rbasuvula@chromium.org se...@chromium.org
 Issue 779373  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/018bf76b5eb54811482aff02d07c14f4e1ce3c36

commit 018bf76b5eb54811482aff02d07c14f4e1ce3c36
Author: sebsg <sebsg@chromium.org>
Date: Mon Oct 30 18:45:57 2017

[Autofill] Fill Autocomplete correctly after suggestion.

Tbr-ing tkent@ for the TODO comment I added in WebInputElement.h

Bug:  777097 
Change-Id: Ia7c9b839521211d4527f067f848cd7988a49f64c
Tbr: tkent@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/734104
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512553}
[modify] https://crrev.com/018bf76b5eb54811482aff02d07c14f4e1ce3c36/components/autofill/content/renderer/autofill_agent.cc
[modify] https://crrev.com/018bf76b5eb54811482aff02d07c14f4e1ce3c36/third_party/WebKit/public/web/WebInputElement.h

Comment 8 by se...@chromium.org, Oct 30 2017

Status: Fixed (was: Started)
Labels: TE-Verified-M64 TE-Verified-64.0.3254.0
Tested the issue on Windows 10, Mac 10.12.6 and Ubuntu 14.04 using Chrome Canary version M64 - 64.0.3254.0 as per the issue mentioned in original comment. Observed that issue is working as intended (After typing some text in a text box and selecting the text from suggestions, then the complete text is populated in the text box). Hence adding TE-Verified labels. Attached the screencast for reference.

Thank you!
777097.mp4
3.0 MB View Download
Cc: ranjitkan@chromium.org
 Issue 781091  has been merged into this issue.

Sign in to add a comment