New issue
Advanced search Search tips

Issue 777071 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

<select><option> cannot be styled with 'Exo 2' Google Web Font

Reported by johnmill...@gmail.com, Oct 21 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36

Steps to reproduce the problem:
1. Create a <select> element.
2. Create dependent <option> elements.
3. Style the <option>s with font-family 'Exo 2' (assumed: 'Exo 2' Google Web Font has been loaded).

What is the expected behavior?
Options should display in 'Exo 2' font.

What went wrong?
Options display in default font.

Did this work before? No 

Does this work in other browsers? Yes

Chrome version: 61.0.3163.100  Channel: stable
OS Version: 10.0
Flash Version: Shockwave Flash 27.0 r0

1) No problem if <option>s are styled with with font-family 'Exo'.
2) Other elements styled with with font-family 'Exo 2' display correctly.
 
select-bug-chrome.txt
266 bytes View Download
Follow-up: I'm attaching screenshots to illustrate.
compare-options-exo2.png
11.6 KB View Download
Components: Blink>WebFonts Blink>Forms>Select

Comment 3 by kochi@chromium.org, Oct 23 2017

Components: -Blink>DOM Blink>CSS
Components: -Blink>CSS -Blink>Forms>Select
Components: Blink>Forms>Select
Status: Untriaged (was: Unconfirmed)
Confirmed.

It is interesting that "Exo" works where "Exo 2" doesn't. That suggests lack of quotation for font-family strings, probably somewhere in the popup code.

https://www.w3.org/TR/css-fonts-3/#family-name-value

"Font family names other than generic families must either be given quoted as strings, or unquoted as a sequence of one or more identifiers. This means most punctuation characters and digits at the start of each token must be escaped in unquoted font family names."

Owner: ksakamoto@chromium.org
Status: Started (was: Untriaged)
https://chromium-review.googlesource.com/c/chromium/src/+/734501
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bef32860383f6e548c06278c25a3f73555952ab2

commit bef32860383f6e548c06278c25a3f73555952ab2
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Tue Oct 24 07:35:37 2017

SELECT popup: Properly quote font family strings

This fixes a bug where SELECT popup cannot be styled with fonts with
certain font family names (e.g. have digits at the start of token).

Bug:  777071 
Change-Id: Ifb5ec4cf6f4a165b766749510b919b4b48c5da03
Reviewed-on: https://chromium-review.googlesource.com/734501
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511052}
[add] https://crrev.com/bef32860383f6e548c06278c25a3f73555952ab2/third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-font-face.html
[modify] https://crrev.com/bef32860383f6e548c06278c25a3f73555952ab2/third_party/WebKit/Source/core/html/forms/resources/listPicker.js

Status: Fixed (was: Started)

Sign in to add a comment