New issue
Advanced search Search tips

Issue 777059 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
STS
Team-Accessibility

Blocking:
issue 785330



Sign in to add a comment

[Select to Speak] Issue reading comboboxes

Project Member Reported by lpalmaro@chromium.org, Oct 21 2017

Issue description

OS: Chrome 
Versions: multiple 

Noticing an issue with selecting a combobox as part of text to be read (for example on the Select to Speak settings page). When you select all the text on that small page to be read, TTS verbalizes all the options in the combobox, even if just the one is displayed (i.e. the combobox is not expanded). When a combobox is collapsed, we should not be reading all of the different list items, only the one displayed.  
 
Components: UI>Accessibility>ChromeVox

Comment 2 by katydek@google.com, Oct 31 2017

Cc: katie@chromium.org

Comment 3 by katydek@google.com, Oct 31 2017

Cc: -katydek@google.com

Comment 4 by katie@chromium.org, Nov 13 2017

Owner: katie@chromium.org

Comment 5 by katie@chromium.org, Nov 13 2017

Status: Assigned (was: Available)
1. Select-to-speak needs to ignore nodes with an 'invisible' state, this will keep it from reading other options when <select> is not expanded.

2. Select drop-downs don't update node states to remove 'invisible' when expanded. Except, after ChromeVox reads a <option>, it is updated properly. Updating 'invisible' will let it read other options when <select> is expanded.

3. Select drop-downs don't seem to have location for children in popup menu. This will make it hard to read individual pop-up menu elements. That seems lower priority.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2d045d7940f9604560c798539a5ea3f05f0471e

commit a2d045d7940f9604560c798539a5ea3f05f0471e
Author: Katie Dektar <katydek@google.com>
Date: Wed Nov 15 01:39:42 2017

Opening and closing select tag updates children state.

Previously, the 'invisible' tag was not removed from <select>
popup's children elements even when the <select> was expanded. This
change causes all children of a <select> popup to be updated when
the popup is opened or closed.

In addition, the change causes Select-to-speak will ignore
'invisible' nodes. See go/chrome-a11y-offscreen-invisible for more.

With these two changes combined now Select-to-speak will not read
aloud all the options in a closed combobox, but will still read
them all if that combo box is expanded.

Bug:  777059 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2424fdf04248b7b91c607388376ee957beea8e06
Reviewed-on: https://chromium-review.googlesource.com/769674
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Katie D <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516549}
[modify] https://crrev.com/a2d045d7940f9604560c798539a5ea3f05f0471e/chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js
[modify] https://crrev.com/a2d045d7940f9604560c798539a5ea3f05f0471e/content/renderer/accessibility/render_accessibility_impl.cc
[modify] https://crrev.com/a2d045d7940f9604560c798539a5ea3f05f0471e/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp

Comment 7 by katie@chromium.org, Nov 15 2017

Status: Fixed (was: Assigned)
I'm going to mark this as fixed, and open a separate bug for #3.

To verify, make sure that:
1. Select-to-speak only reads the selected option when the combobox is closed
2. When the combobox is expanded, and the user highlights the combobox itself (not the popup menu), all the options should be read.
3. After closing the combobox again, only the selected option should be read.

Comment 8 by katie@chromium.org, Nov 15 2017

Blocking: 785330

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 10 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
Components: UI>Accessibility>SelectToSpeak
Moving from just having STS label to also having the UI>Accessibility>SelectToSpeak component to make searching easier in the future. 

Sign in to add a comment