New issue
Advanced search Search tips

Issue 777055 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

DCHECK failure in !microtask_context_ in api.h

Project Member Reported by ClusterFuzz, Oct 21 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6696870234816512

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  !microtask_context_ in api.h
  EnterMicrotaskContext
  v8::internal::Isolate::RunMicrotasksInternal
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=48067:48068

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6696870234816512

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Oct 21 2017

Labels: Test-Predator-AutoOwner
Owner: ca...@igalia.com
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/88a4cf736ef10b213d2e29a841ac73934b8eccc7 ([esnext] ship --harmony-async-iteration).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 2 by sheriffbot@chromium.org, Oct 22 2017

Labels: Pri-1

Comment 3 by vakh@chromium.org, Nov 2 2017

Cc: ishell@chromium.org adamk@chromium.org
caitp@igalia.com -- can you please take a look at this high severity security bug and fix it soon? thanks.

Comment 4 by ca...@igalia.com, Nov 3 2017

I'm taking a look... But looking at the reproduction, it looks like %RunMicrotasks is being called recursively from within one of the microtask handlers, which is an error and has always crashed, afaik.

The only thing this test really has to do with async iteration is that it would have failed with a SyntaxError before shipping.

Comment 5 by ca...@igalia.com, Nov 3 2017

And that's exactly what's happening. Since %RunMicrotasks is a test API, it's probably better to crash than throw an exception when it's invoked recursively, otherwise it will be very easy to write tests which seem to pass when they shouldn't.

Is there a way to prevent this pattern from occurring in future clusterfuzz tests?

Comment 6 by ca...@igalia.com, Nov 5 2017

Cc: ca...@igalia.com
Owner: ----
Status: WontFix (was: Assigned)
I'm going to mark this as WontFix for now, but lets re-open if there's something I can do to get this pattern out of clusterfuzz
Labels: -Test-Predator-AutoOwner Test-Predator-Auto-Owner
Project Member

Comment 8 by ClusterFuzz, Nov 12 2017

Labels: Needs-Feedback
ClusterFuzz testcase 6696870234816512 is still reproducing on tip-of-tree build (trunk).

If this testcase was not reproducible locally or unworkable, ignore this notification and we will file another bug soon with hopefully a better and workable testcase.

Otherwise, if this is not intended to be fixed (e.g. this is an intentional crash), please add ClusterFuzz-Ignore label to prevent future bug filing with similar crash stacktrace.

Comment 9 by ca...@igalia.com, Nov 12 2017

Labels: ClusterFuzz-Ignore
Project Member

Comment 10 by ClusterFuzz, Dec 5 2017

ClusterFuzz has detected this issue as fixed in range 49841:49842.

Detailed report: https://clusterfuzz.com/testcase?key=6696870234816512

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  !microtask_context_ in api.h
  EnterMicrotaskContext
  v8::internal::Isolate::RunMicrotasksInternal
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=48067:48068
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=49841:49842

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6696870234816512

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 11 by sheriffbot@chromium.org, Feb 12 2018

Labels: -Restrict-View-SecurityTeam allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment