New issue
Advanced search Search tips

Issue 777041 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Crash in blink::PersistentBase<blink::DummyGCBase,

Project Member Reported by ClusterFuzz, Oct 21 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5788486597869568

Fuzzer: inferno_layout_test_fuzzer
Job Type: linux_asan_chrome_mp
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x7ecd931a1928
Crash State:
  blink::PersistentBase<blink::DummyGCBase,
  blink::CrossThreadPersistentRegion::PrepareForThreadStateTermination
  blink::ThreadState::RunTerminationGC
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mp&range=473072:473106

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5788486597869568

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Oct 21 2017

Components: Blink>MemoryAllocator>GarbageCollection
Labels: Test-Predator-AutoComponents
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by sheriffbot@chromium.org, Oct 22 2017

Labels: M-63
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 22 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Oct 22 2017

Labels: Pri-1
Project Member

Comment 5 by sheriffbot@chromium.org, Oct 23 2017

Labels: -Security_Impact-Head Security_Impact-Beta

Comment 6 by gov...@chromium.org, Oct 30 2017

[Bulk Edit]
URGENT - PTAL.
M63 Stable promotion is coming soon and your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP. Thank you.

Comment 7 by vakh@chromium.org, Nov 2 2017

Cc: horo@chromium.org
Owner: keishi@chromium.org
Status: Assigned (was: Untriaged)
keishi@ -- can you please help triage this and find the right owner quickly? thanks.

Comment 8 by horo@chromium.org, Nov 2 2017

Cc: nhiroki@chromium.org
Components: Blink>Workers
Cc: awhalley@chromium.org
+awhalley@, PTAL and expedite the fix if it is indeed M63 Stable blocker. Thank you.
Project Member

Comment 10 by sheriffbot@chromium.org, Nov 4 2017

keishi: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
M63 Stable promotion is coming soon and your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge to M63 ASAP. Thank you.
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components
Project Member

Comment 14 by sheriffbot@chromium.org, Nov 8 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: och...@chromium.org
Labels: -ReleaseBlock-Stable
keishi@ - thanks for looking into this. Note that for security issues it doesn't matter if there haven't been any reports in the wild - we're primarily interested in preventing an active exploitation of the bug, rather than the stability issue.
Project Member

Comment 16 by sheriffbot@chromium.org, Nov 9 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Security_Impact-Beta -ReleaseBlock-Stable -M-63 M-64 Security_Impact-Stable
Project Member

Comment 18 by ClusterFuzz, Nov 14 2017

ClusterFuzz has detected this issue as fixed in range 511144:511192.

Detailed report: https://clusterfuzz.com/testcase?key=5788486597869568

Fuzzer: inferno_layout_test_fuzzer
Job Type: linux_asan_chrome_mp
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x7ecd931a1928
Crash State:
  blink::PersistentBase<blink::DummyGCBase,
  blink::CrossThreadPersistentRegion::PrepareForThreadStateTermination
  blink::ThreadState::RunTerminationGC
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mp&range=510290:510324
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mp&range=511144:511192

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5788486597869568

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 19 by ClusterFuzz, Nov 14 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5788486597869568 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Re c#13, I've also tried to reproduce this locally and haven't succeeded. After that, I've kicked off Progression task on CF testcase and now it's marked as fixed.

Not sure why the fix was not recognized before. The fix range points to the revision landed ~20 days ago: https://chromium.googlesource.com/chromium/src/+log/75b1c3aed7e1265eab65c1fc5516ca5cfda59284..5f207b6db7148720c335155fe1a89a276e256af9?pretty=fuller&n=10000

I'll file a separate bug to investigate that on CF side.
Project Member

Comment 21 by sheriffbot@chromium.org, Nov 15 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 22 by sheriffbot@chromium.org, Feb 21 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 23 by sheriffbot@chromium.org, Mar 27 2018

Labels: -M-64 M-65

Sign in to add a comment