As part of the effort to deprecate UtilityProcessMojoClient we should make a service of the ShellHandlerWin and have: chrome/browser/shell_integration_win.cc chrome/browser/win/chrome_select_file_dialog_factory.cc use the service directly.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8232f416077967da4c3e79a499ae31f7ac17f020 commit 8232f416077967da4c3e79a499ae31f7ac17f020 Author: Jay Civelli <jcivelli@chromium.org> Date: Tue Oct 31 00:09:44 2017 Servicifying ShellHandlerWin. As part of the effort to deprecate UtilityProcessMojoClient, changing ShellHandlerWin to a service and consumers to bind the service through the service manager. Renamed the interface from ShellHandlerWin to WinShellUtil. Bug: 777032 Change-Id: I71a45a38a5fd0d5d02a8a0bccabf6a7e140acbd7 Reviewed-on: https://chromium-review.googlesource.com/736147 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#512682} [modify] https://crrev.com/8232f416077967da4c3e79a499ae31f7ac17f020/chrome/app/BUILD.gn [modify] https://crrev.com/8232f416077967da4c3e79a499ae31f7ac17f020/chrome/app/generated_resources.grd [modify] https://crrev.com/8232f416077967da4c3e79a499ae31f7ac17f020/chrome/browser/BUILD.gn [modify] https://crrev.com/8232f416077967da4c3e79a499ae31f7ac17f020/chrome/browser/DEPS [modify] https://crrev.com/8232f416077967da4c3e79a499ae31f7ac17f020/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/8232f416077967da4c3e79a499ae31f7ac17f020/chrome/browser/chrome_content_browser_manifest_overlay.json [modify] https://crrev.com/8232f416077967da4c3e79a499ae31f7ac17f020/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc [modify] https://crrev.com/8232f416077967da4c3e79a499ae31f7ac17f020/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics_unittest.cc [modify] https://crrev.com/8232f416077967da4c3e79a499ae31f7ac17f020/chrome/browser/shell_integration_win.cc [modify] https://crrev.com/8232f416077967da4c3e79a499ae31f7ac17f020/chrome/browser/shell_integration_win.h [modify] https://crrev.com/8232f416077967da4c3e79a499ae31f7ac17f020/chrome/browser/ui/webui/welcome_win10_handler.cc [modify] https://crrev.com/8232f416077967da4c3e79a499ae31f7ac17f020/chrome/browser/win/chrome_select_file_dialog_factory.cc [modify] https://crrev.com/8232f416077967da4c3e79a499ae31f7ac17f020/chrome/common/BUILD.gn [add] https://crrev.com/8232f416077967da4c3e79a499ae31f7ac17f020/chrome/services/DEPS [add] https://crrev.com/8232f416077967da4c3e79a499ae31f7ac17f020/chrome/services/OWNERS [add] https://crrev.com/8232f416077967da4c3e79a499ae31f7ac17f020/chrome/services/util_win/BUILD.gn [add] https://crrev.com/8232f416077967da4c3e79a499ae31f7ac17f020/chrome/services/util_win/DEPS [add] https://crrev.com/8232f416077967da4c3e79a499ae31f7ac17f020/chrome/services/util_win/OWNERS [add] https://crrev.com/8232f416077967da4c3e79a499ae31f7ac17f020/chrome/services/util_win/manifest.json [add] https://crrev.com/8232f416077967da4c3e79a499ae31f7ac17f020/chrome/services/util_win/public/interfaces/BUILD.gn [add] https://crrev.com/8232f416077967da4c3e79a499ae31f7ac17f020/chrome/services/util_win/public/interfaces/OWNERS [add] https://crrev.com/8232f416077967da4c3e79a499ae31f7ac17f020/chrome/services/util_win/public/interfaces/constants.mojom [rename] https://crrev.com/8232f416077967da4c3e79a499ae31f7ac17f020/chrome/services/util_win/public/interfaces/shell_util_win.mojom [rename] https://crrev.com/8232f416077967da4c3e79a499ae31f7ac17f020/chrome/services/util_win/public/interfaces/shell_util_win.typemap [rename] https://crrev.com/8232f416077967da4c3e79a499ae31f7ac17f020/chrome/services/util_win/shell_util_win_impl.cc [add] https://crrev.com/8232f416077967da4c3e79a499ae31f7ac17f020/chrome/services/util_win/shell_util_win_impl.h [add] https://crrev.com/8232f416077967da4c3e79a499ae31f7ac17f020/chrome/services/util_win/util_win_service.cc [add] https://crrev.com/8232f416077967da4c3e79a499ae31f7ac17f020/chrome/services/util_win/util_win_service.h [modify] https://crrev.com/8232f416077967da4c3e79a499ae31f7ac17f020/chrome/typemaps.gni [modify] https://crrev.com/8232f416077967da4c3e79a499ae31f7ac17f020/chrome/utility/BUILD.gn [modify] https://crrev.com/8232f416077967da4c3e79a499ae31f7ac17f020/chrome/utility/DEPS [modify] https://crrev.com/8232f416077967da4c3e79a499ae31f7ac17f020/chrome/utility/chrome_content_utility_client.cc [delete] https://crrev.com/4ef8db7d96d253976913fa3e3af4d17aecd6224c/chrome/utility/shell_handler_impl_win.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c52f5bd43b2c0392e65ed900c36529d6b32fc511 commit c52f5bd43b2c0392e65ed900c36529d6b32fc511 Author: Makoto Shimazu <shimazu@chromium.org> Date: Tue Oct 31 00:47:23 2017 Revert "Servicifying ShellHandlerWin." This reverts commit 8232f416077967da4c3e79a499ae31f7ac17f020. Reason for revert: Google Chrome Win builder failed. shell_handler_win.mojom.h is still included by shell_integration_win.cc which was renamed by the original CL. I'm wondering why the trybots missed this. Original change's description: > Servicifying ShellHandlerWin. > > As part of the effort to deprecate UtilityProcessMojoClient, changing > ShellHandlerWin to a service and consumers to bind the service through > the service manager. > Renamed the interface from ShellHandlerWin to WinShellUtil. > > Bug: 777032 > Change-Id: I71a45a38a5fd0d5d02a8a0bccabf6a7e140acbd7 > Reviewed-on: https://chromium-review.googlesource.com/736147 > Commit-Queue: Jay Civelli <jcivelli@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Patrick Monette <pmonette@chromium.org> > Cr-Commit-Position: refs/heads/master@{#512682} TBR=sky@chromium.org,thestig@chromium.org,jcivelli@chromium.org,noel@chromium.org,tsepez@chromium.org,pmonette@chromium.org Change-Id: I03bb3ac7bfa0e9e98fc63034d7e81a62fcdfd21a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 777032 Reviewed-on: https://chromium-review.googlesource.com/745461 Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#512693} [modify] https://crrev.com/c52f5bd43b2c0392e65ed900c36529d6b32fc511/chrome/app/BUILD.gn [modify] https://crrev.com/c52f5bd43b2c0392e65ed900c36529d6b32fc511/chrome/app/generated_resources.grd [modify] https://crrev.com/c52f5bd43b2c0392e65ed900c36529d6b32fc511/chrome/browser/BUILD.gn [modify] https://crrev.com/c52f5bd43b2c0392e65ed900c36529d6b32fc511/chrome/browser/DEPS [modify] https://crrev.com/c52f5bd43b2c0392e65ed900c36529d6b32fc511/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/c52f5bd43b2c0392e65ed900c36529d6b32fc511/chrome/browser/chrome_content_browser_manifest_overlay.json [modify] https://crrev.com/c52f5bd43b2c0392e65ed900c36529d6b32fc511/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc [modify] https://crrev.com/c52f5bd43b2c0392e65ed900c36529d6b32fc511/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics_unittest.cc [modify] https://crrev.com/c52f5bd43b2c0392e65ed900c36529d6b32fc511/chrome/browser/shell_integration_win.cc [modify] https://crrev.com/c52f5bd43b2c0392e65ed900c36529d6b32fc511/chrome/browser/shell_integration_win.h [modify] https://crrev.com/c52f5bd43b2c0392e65ed900c36529d6b32fc511/chrome/browser/ui/webui/welcome_win10_handler.cc [modify] https://crrev.com/c52f5bd43b2c0392e65ed900c36529d6b32fc511/chrome/browser/win/chrome_select_file_dialog_factory.cc [modify] https://crrev.com/c52f5bd43b2c0392e65ed900c36529d6b32fc511/chrome/common/BUILD.gn [rename] https://crrev.com/c52f5bd43b2c0392e65ed900c36529d6b32fc511/chrome/common/shell_handler_win.mojom [rename] https://crrev.com/c52f5bd43b2c0392e65ed900c36529d6b32fc511/chrome/common/shell_handler_win.typemap [delete] https://crrev.com/f2061c449e671b7c8b16bbc7c5b7fbe57c01114d/chrome/services/DEPS [delete] https://crrev.com/f2061c449e671b7c8b16bbc7c5b7fbe57c01114d/chrome/services/OWNERS [delete] https://crrev.com/f2061c449e671b7c8b16bbc7c5b7fbe57c01114d/chrome/services/util_win/BUILD.gn [delete] https://crrev.com/f2061c449e671b7c8b16bbc7c5b7fbe57c01114d/chrome/services/util_win/DEPS [delete] https://crrev.com/f2061c449e671b7c8b16bbc7c5b7fbe57c01114d/chrome/services/util_win/OWNERS [delete] https://crrev.com/f2061c449e671b7c8b16bbc7c5b7fbe57c01114d/chrome/services/util_win/manifest.json [delete] https://crrev.com/f2061c449e671b7c8b16bbc7c5b7fbe57c01114d/chrome/services/util_win/public/interfaces/BUILD.gn [delete] https://crrev.com/f2061c449e671b7c8b16bbc7c5b7fbe57c01114d/chrome/services/util_win/public/interfaces/OWNERS [delete] https://crrev.com/f2061c449e671b7c8b16bbc7c5b7fbe57c01114d/chrome/services/util_win/public/interfaces/constants.mojom [delete] https://crrev.com/f2061c449e671b7c8b16bbc7c5b7fbe57c01114d/chrome/services/util_win/shell_util_win_impl.h [delete] https://crrev.com/f2061c449e671b7c8b16bbc7c5b7fbe57c01114d/chrome/services/util_win/util_win_service.cc [delete] https://crrev.com/f2061c449e671b7c8b16bbc7c5b7fbe57c01114d/chrome/services/util_win/util_win_service.h [modify] https://crrev.com/c52f5bd43b2c0392e65ed900c36529d6b32fc511/chrome/typemaps.gni [modify] https://crrev.com/c52f5bd43b2c0392e65ed900c36529d6b32fc511/chrome/utility/BUILD.gn [modify] https://crrev.com/c52f5bd43b2c0392e65ed900c36529d6b32fc511/chrome/utility/DEPS [modify] https://crrev.com/c52f5bd43b2c0392e65ed900c36529d6b32fc511/chrome/utility/chrome_content_utility_client.cc [rename] https://crrev.com/c52f5bd43b2c0392e65ed900c36529d6b32fc511/chrome/utility/shell_handler_impl_win.cc [add] https://crrev.com/c52f5bd43b2c0392e65ed900c36529d6b32fc511/chrome/utility/shell_handler_impl_win.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4b8905fdeb7cc38b5ef924a6045be2fa9b44122 commit d4b8905fdeb7cc38b5ef924a6045be2fa9b44122 Author: Jay Civelli <jcivelli@chromium.org> Date: Tue Oct 31 17:48:25 2017 Relanding "Servicifying ShellHandlerWin." Relanding "Servicifying ShellHandlerWin.". It was breaking the Windows build due to a left over include for a file that does not exist anymore. This reverts commit c52f5bd43b2c0392e65ed900c36529d6b32fc511. BUG= 777032 TBR=sky@chromium.org,pmonette@chromium.org,tsepez@chromium.org Change-Id: I0f495649aed6091ff287852f813cc10917c4e7f8 Reviewed-on: https://chromium-review.googlesource.com/745984 Reviewed-by: Jay Civelli <jcivelli@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#512868} [modify] https://crrev.com/d4b8905fdeb7cc38b5ef924a6045be2fa9b44122/chrome/app/BUILD.gn [modify] https://crrev.com/d4b8905fdeb7cc38b5ef924a6045be2fa9b44122/chrome/app/generated_resources.grd [modify] https://crrev.com/d4b8905fdeb7cc38b5ef924a6045be2fa9b44122/chrome/browser/BUILD.gn [modify] https://crrev.com/d4b8905fdeb7cc38b5ef924a6045be2fa9b44122/chrome/browser/DEPS [modify] https://crrev.com/d4b8905fdeb7cc38b5ef924a6045be2fa9b44122/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/d4b8905fdeb7cc38b5ef924a6045be2fa9b44122/chrome/browser/chrome_content_browser_manifest_overlay.json [modify] https://crrev.com/d4b8905fdeb7cc38b5ef924a6045be2fa9b44122/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc [modify] https://crrev.com/d4b8905fdeb7cc38b5ef924a6045be2fa9b44122/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics_unittest.cc [modify] https://crrev.com/d4b8905fdeb7cc38b5ef924a6045be2fa9b44122/chrome/browser/shell_integration_win.cc [modify] https://crrev.com/d4b8905fdeb7cc38b5ef924a6045be2fa9b44122/chrome/browser/shell_integration_win.h [modify] https://crrev.com/d4b8905fdeb7cc38b5ef924a6045be2fa9b44122/chrome/browser/ui/webui/welcome_win10_handler.cc [modify] https://crrev.com/d4b8905fdeb7cc38b5ef924a6045be2fa9b44122/chrome/browser/win/chrome_select_file_dialog_factory.cc [modify] https://crrev.com/d4b8905fdeb7cc38b5ef924a6045be2fa9b44122/chrome/common/BUILD.gn [add] https://crrev.com/d4b8905fdeb7cc38b5ef924a6045be2fa9b44122/chrome/services/DEPS [add] https://crrev.com/d4b8905fdeb7cc38b5ef924a6045be2fa9b44122/chrome/services/OWNERS [add] https://crrev.com/d4b8905fdeb7cc38b5ef924a6045be2fa9b44122/chrome/services/util_win/BUILD.gn [add] https://crrev.com/d4b8905fdeb7cc38b5ef924a6045be2fa9b44122/chrome/services/util_win/DEPS [add] https://crrev.com/d4b8905fdeb7cc38b5ef924a6045be2fa9b44122/chrome/services/util_win/OWNERS [add] https://crrev.com/d4b8905fdeb7cc38b5ef924a6045be2fa9b44122/chrome/services/util_win/manifest.json [add] https://crrev.com/d4b8905fdeb7cc38b5ef924a6045be2fa9b44122/chrome/services/util_win/public/interfaces/BUILD.gn [add] https://crrev.com/d4b8905fdeb7cc38b5ef924a6045be2fa9b44122/chrome/services/util_win/public/interfaces/OWNERS [add] https://crrev.com/d4b8905fdeb7cc38b5ef924a6045be2fa9b44122/chrome/services/util_win/public/interfaces/constants.mojom [rename] https://crrev.com/d4b8905fdeb7cc38b5ef924a6045be2fa9b44122/chrome/services/util_win/public/interfaces/shell_util_win.mojom [rename] https://crrev.com/d4b8905fdeb7cc38b5ef924a6045be2fa9b44122/chrome/services/util_win/public/interfaces/shell_util_win.typemap [rename] https://crrev.com/d4b8905fdeb7cc38b5ef924a6045be2fa9b44122/chrome/services/util_win/shell_util_win_impl.cc [add] https://crrev.com/d4b8905fdeb7cc38b5ef924a6045be2fa9b44122/chrome/services/util_win/shell_util_win_impl.h [add] https://crrev.com/d4b8905fdeb7cc38b5ef924a6045be2fa9b44122/chrome/services/util_win/util_win_service.cc [add] https://crrev.com/d4b8905fdeb7cc38b5ef924a6045be2fa9b44122/chrome/services/util_win/util_win_service.h [modify] https://crrev.com/d4b8905fdeb7cc38b5ef924a6045be2fa9b44122/chrome/typemaps.gni [modify] https://crrev.com/d4b8905fdeb7cc38b5ef924a6045be2fa9b44122/chrome/utility/BUILD.gn [modify] https://crrev.com/d4b8905fdeb7cc38b5ef924a6045be2fa9b44122/chrome/utility/DEPS [modify] https://crrev.com/d4b8905fdeb7cc38b5ef924a6045be2fa9b44122/chrome/utility/chrome_content_utility_client.cc [delete] https://crrev.com/bafe78889d58613c2aaae534d5154840fb66b995/chrome/utility/shell_handler_impl_win.h
Comment 1 by bugdroid1@chromium.org
, Oct 31 2017