New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 777031 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 776951
issue 781853



Sign in to add a comment

Write alternative recipe for flake tryjobs that only builds and isolates tests (no running)

Project Member Reported by robert...@chromium.org, Oct 20 2017

Issue description

The idea is to allow the flake pipelines to choose either recipe based on a configuration setting. If they choose, this new "flake_isolate_only" recipe then the pipelines would be responsible for triggering swarming tasks for actually running the tests based on the isolates uploaded by this new recipe.

 
Status: Started (was: Untriaged)
Cc: robert...@chromium.org
 Issue 775706  has been merged into this issue.

Comment 3 by st...@chromium.org, Oct 27 2017

Is it possible to just add a new flag like run_test(=true by default for current behavior) instead of a new recipe?

We'd like to default to no-run later IMO.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/0898cc95b69c520d08058e97fb9de87e55521611

commit 0898cc95b69c520d08058e97fb9de87e55521611
Author: Roberto Carrillo <robertocn@google.com>
Date: Fri Nov 10 20:11:25 2017

[Findit recipes] Allow flake recipe to build and isolate only.

This change adds the 'skip_tests' property and if set to true, the
recipe will not actually run the tests. The compile and isolate steps
should work as expected.

R=stgao,lijeffrey,chanli,wylieb

Bug:  777031 
Change-Id: I88d33ebd4dc1a642bd9a6ededd2d814d185a20fc
Reviewed-on: https://chromium-review.googlesource.com/740571
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/0898cc95b69c520d08058e97fb9de87e55521611/scripts/slave/recipe_modules/findit/api.py
[modify] https://crrev.com/0898cc95b69c520d08058e97fb9de87e55521611/scripts/slave/recipes/findit/chromium/flake.py
[modify] https://crrev.com/0898cc95b69c520d08058e97fb9de87e55521611/scripts/slave/recipes/findit/chromium/flake.expected/flakiness_swarming_tests.json
[modify] https://crrev.com/0898cc95b69c520d08058e97fb9de87e55521611/scripts/slave/recipes/findit/chromium/flake.expected/use_build_parameter_for_tests.json
[modify] https://crrev.com/0898cc95b69c520d08058e97fb9de87e55521611/scripts/slave/recipes/findit/chromium/flake.expected/flakiness_non-swarming_tests.json
[modify] https://crrev.com/0898cc95b69c520d08058e97fb9de87e55521611/scripts/slave/README.recipes.md
[modify] https://crrev.com/0898cc95b69c520d08058e97fb9de87e55521611/scripts/slave/recipes/findit/chromium/flake.expected/record_infra_failure.json
[add] https://crrev.com/0898cc95b69c520d08058e97fb9de87e55521611/scripts/slave/recipes/findit/chromium/flake.expected/flakiness_isolate_only.json

Status: Fixed (was: Started)
Blocking: 781853

Sign in to add a comment