New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 777028 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 777578



Sign in to add a comment

Enable S13nSafeBrowsingParallelUrlCheck

Project Member Reported by yzshen@chromium.org, Oct 20 2017

Issue description

A detailed description of this feature could be found in this design doc:

https://docs.google.com/a/chromium.org/document/d/1p0yYIxUtgLOWwYe51pyWhORB5_BdR_xVpaJs-9Qs7D8/edit?usp=sharing
 

Comment 1 Deleted

Comment 2 by yzshen@chromium.org, Oct 23 2017

Blockedon: 777578
Status: Started (was: WontFix)
777578 is the formal launch bug for the features. While this bug is referenced by related CLs, so that CL commits won't pollute the lunch bug. 

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c310d7826c99786affa4c0704c6071a90b09b4c

commit 9c310d7826c99786affa4c0704c6071a90b09b4c
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Mon Oct 30 01:29:05 2017

Enable S13nSafeBrowsingParallelUrlCheck in testing configuration.

BUG= 777028 

Change-Id: I7b77f86990dc65998927a264bd8165570b7d04fa
Reviewed-on: https://chromium-review.googlesource.com/734209
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512429}
[modify] https://crrev.com/9c310d7826c99786affa4c0704c6071a90b09b4c/testing/variations/fieldtrial_testing_config.json

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f69279f3c83a0de09fea1b1c066e0bd1227e0fd

commit 0f69279f3c83a0de09fea1b1c066e0bd1227e0fd
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Mon Jan 08 22:25:54 2018

Make S13nSafeBrowsingParallelUrlCheck the default behavior.

This CL removes the old behavior and the feature flag.

BUG= 777028 , 715673 

Change-Id: Idaee7f5161d77b146930150c0b98afa6952fed99
Reviewed-on: https://chromium-review.googlesource.com/847819
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527784}
[modify] https://crrev.com/0f69279f3c83a0de09fea1b1c066e0bd1227e0fd/android_webview/browser/aw_safe_browsing_resource_throttle.cc
[modify] https://crrev.com/0f69279f3c83a0de09fea1b1c066e0bd1227e0fd/android_webview/browser/aw_safe_browsing_resource_throttle.h
[modify] https://crrev.com/0f69279f3c83a0de09fea1b1c066e0bd1227e0fd/chrome/browser/loader/safe_browsing_resource_throttle.cc
[modify] https://crrev.com/0f69279f3c83a0de09fea1b1c066e0bd1227e0fd/chrome/browser/loader/safe_browsing_resource_throttle.h
[modify] https://crrev.com/0f69279f3c83a0de09fea1b1c066e0bd1227e0fd/components/safe_browsing/BUILD.gn
[delete] https://crrev.com/69ce64a1b5eabdf06186c33f91d8f8ba76cd2f02/components/safe_browsing/base_resource_throttle.cc
[delete] https://crrev.com/69ce64a1b5eabdf06186c33f91d8f8ba76cd2f02/components/safe_browsing/base_resource_throttle.h
[modify] https://crrev.com/0f69279f3c83a0de09fea1b1c066e0bd1227e0fd/components/safe_browsing/browser/base_parallel_resource_throttle.h
[modify] https://crrev.com/0f69279f3c83a0de09fea1b1c066e0bd1227e0fd/components/safe_browsing/browser/browser_url_loader_throttle.h
[modify] https://crrev.com/0f69279f3c83a0de09fea1b1c066e0bd1227e0fd/components/safe_browsing/browser/safe_browsing_url_checker_impl.cc
[modify] https://crrev.com/0f69279f3c83a0de09fea1b1c066e0bd1227e0fd/components/safe_browsing/browser/safe_browsing_url_checker_impl.h
[modify] https://crrev.com/0f69279f3c83a0de09fea1b1c066e0bd1227e0fd/components/safe_browsing/features.cc
[modify] https://crrev.com/0f69279f3c83a0de09fea1b1c066e0bd1227e0fd/components/safe_browsing/features.h
[delete] https://crrev.com/69ce64a1b5eabdf06186c33f91d8f8ba76cd2f02/components/safe_browsing/net_event_logger.cc
[delete] https://crrev.com/69ce64a1b5eabdf06186c33f91d8f8ba76cd2f02/components/safe_browsing/net_event_logger.h
[modify] https://crrev.com/0f69279f3c83a0de09fea1b1c066e0bd1227e0fd/testing/variations/fieldtrial_testing_config.json

Comment 5 by yzshen@chromium.org, Jan 18 2018

Status: Fixed (was: Started)

Sign in to add a comment