Find-in-page not working correctly in the Chrome PDF Viewer |
|||||||
Issue descriptionChrome Version: 62.x to 64.0.3245.0 OS: Desktop platforms What steps will reproduce the problem? See https://bugs.chromium.org/p/pdfium/issues/detail?id=921 The underlying issue is in PDFium. This is just the Chromium side bug for the same issue to help keep track of merges to M-63 and maybe M-62.
,
Oct 24 2017
There's a fix in PDFium, but the DEPS roll hasn't landed yet. So we'll have to wait a day or two to check on Canary.
,
Oct 24 2017
We should be able to verify the fix with 64.0.3249.0 and newer.
,
Oct 24 2017
Thanks for fix! Let's aim to get this in for M63.
,
Oct 24 2017
Pls request a merge to M63 once change is well baked/verified in canary and safe to merge. Thank you.
,
Oct 26 2017
Verified that it is in Chrome and working.
,
Oct 26 2017
This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 26 2017
Is the merge request for CLs listed at #17 and #19 in https://bugs.chromium.org/p/pdfium/issues/detail?id=921?
,
Oct 26 2017
We only need to merge #17, it has the actual fix. #19 is for adding a test to make sure it doesn't regress.
,
Oct 26 2017
Approving merge for cl listed at (https://bugs.chromium.org/p/pdfium/issues/detail?id=921#c17) to M63 branch 3239 based on comment #6 and #9. Please merge ASAP. Thank you.
,
Oct 26 2017
The following revision refers to this bug: https://pdfium.googlesource.com/pdfium/+/f0a7da7ec654a8a33b5f347074de69a5a8b769e2 commit f0a7da7ec654a8a33b5f347074de69a5a8b769e2 Author: Ryan Harrison <rharrison@chromium.org> Date: Thu Oct 26 18:31:58 2017 [Merge M63] Fix cpdf_textpage so it doesn't omit spaces. TBR=thestig@chromium.org Bug: pdfium:921 , chromium:777024 Change-Id: I8864fd2ebdccc5f94aaf70cd8295068bf4db8b68 Reviewed-on: https://pdfium-review.googlesource.com/16492 Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Commit-Queue: Ryan Harrison <rharrison@chromium.org> (cherry picked from commit 25e763e99932a4d12cbd51b3c36411b44163c5d8) Reviewed-on: https://pdfium-review.googlesource.com/16932 [modify] https://crrev.com/f0a7da7ec654a8a33b5f347074de69a5a8b769e2/core/fpdftext/cpdf_textpage.cpp
,
Oct 26 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by rharrison@chromium.org
, Oct 23 2017